From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 225E4C4332F for ; Fri, 16 Dec 2022 16:24:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CCA48E0003; Fri, 16 Dec 2022 11:24:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 855A98E0002; Fri, 16 Dec 2022 11:24:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CF388E0003; Fri, 16 Dec 2022 11:24:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 593408E0002 for ; Fri, 16 Dec 2022 11:24:47 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F0BB4810C5 for ; Fri, 16 Dec 2022 16:24:46 +0000 (UTC) X-FDA: 80248692972.19.E2D4782 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id BC000A0018 for ; Fri, 16 Dec 2022 16:24:44 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f5Y3+KeT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671207885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XA1mi3/yvF2SMJgghhMSPk1ys5oNzMW3ysl1aCR5HSU=; b=Cj1MkcV1X+a1QP9V21yl6p7tJ/WZk+flxxsrFpTJxzh13Cw8tPy74P/Al379AJyurkPfac hxmzNT0DOK8ZHWQRt7GHx4L0YeKKQlAhzjGZ++U5anvhf4szVjTUmsaxu00tyqFDykoymK 2CFJHZw2l5GjMpq96GqnTUPCJPndo/o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f5Y3+KeT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671207885; a=rsa-sha256; cv=none; b=XMS0Ho0OVzwRShwJP1DPidim/uOLylsfQ1N2kI/JObRILr2iGREbIcYwJHpXd+puyRMkul Iqvqar3UmvZRHeRGMM/PS9+4NlgLv2ldF6PJLfuQql/fTu017A3/WeSnmAQwFT17bG4jZC sKYGwkpxalw79FXDLhJxr0ZMtd7gW48= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671207884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XA1mi3/yvF2SMJgghhMSPk1ys5oNzMW3ysl1aCR5HSU=; b=f5Y3+KeTlw5bWIsAd/2jheHrZqsYHuwCxhJ/O/u+RYk2dCS/PH2vsrUuEVIZca8gatRqbD X4Yf6Td1MvwkYBvcdCkkTZTOwZkMu3+ajMKGU1HgBxUa7duSkcw5h9G/eGlRpm+DxQDlJ7 S1pVh6L9QVOpyFM6kC97rZJ775chqpI= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-19-Ns9Wd7whOFqg9_b97qE62w-1; Fri, 16 Dec 2022 11:24:43 -0500 X-MC-Unique: Ns9Wd7whOFqg9_b97qE62w-1 Received: by mail-vk1-f197.google.com with SMTP id d130-20020a1f9b88000000b003b87d0db0d9so1072615vke.15 for ; Fri, 16 Dec 2022 08:24:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XA1mi3/yvF2SMJgghhMSPk1ys5oNzMW3ysl1aCR5HSU=; b=gVuDnNpgdG0Bmfz9A35ygWv7h6NAVCAcak5OfngzbCXQeDKUVKIOMEs9tWbYv0pGLc PY+B06oyylOF/HgSRdXKgW5eoVBwNgiqJTUoiyfE9QTBFd48MTsar9v42/A3IOWq1lNV LhTDx5nfwoSZ7MpHNSbrIrznFseTuWwJ+K15EWpPtHdL0eAa03Mvk1sWEo8ZYLzIso6E JYwjO9WJygBD005whzfqWglv95yBZ/xGlN3sg+EWXPDMHpge4KR3kK7+PuxJi4O1UUjV yQFqmcx76fmogqYrscW6bf/fOhzdY8u2BBpQqGErVe06p8Boj7Cu9gOj2Y8d6sgYxKGg cDTA== X-Gm-Message-State: ANoB5plm7SIloiP+LgiN7BDTCVkR3QkSVtz+W0gA+qWKLgBrUcH6PP/b NLp/djLw/rEPU4dmXyDBVVwunPgUrxCNjvGYUb3xqfMm0atTwQ6b+6S5rTJFSMx5RhreUahUdow fO8ylc3I2yYQ= X-Received: by 2002:a67:dd10:0:b0:3b3:6ddc:97f with SMTP id y16-20020a67dd10000000b003b36ddc097fmr15187494vsj.29.1671207882416; Fri, 16 Dec 2022 08:24:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf6OJlfzNjkPvaVv4RHsPHN78/T6Vk/8cntq0gr0I50Jwzh7j9GHfeHPbvrFscG2qYOO36b7iQ== X-Received: by 2002:a67:dd10:0:b0:3b3:6ddc:97f with SMTP id y16-20020a67dd10000000b003b36ddc097fmr15187469vsj.29.1671207882204; Fri, 16 Dec 2022 08:24:42 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-45-70-31-26-132.dsl.bell.ca. [70.31.26.132]) by smtp.gmail.com with ESMTPSA id de26-20020a05620a371a00b006cfc01b4461sm1688741qkb.118.2022.12.16.08.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 08:24:41 -0800 (PST) Date: Fri, 16 Dec 2022 11:24:40 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , Pengfei Xu , Nadav Amit , Andrew Morton , Miaohe Lin , Huang Ying , stable@vger.kernel.org Subject: Re: [PATCH 1/2] mm/uffd: Fix pte marker when fork() without fork event Message-ID: References: <20221214200453.1772655-1-peterx@redhat.com> <20221214200453.1772655-2-peterx@redhat.com> <618b69be-0e99-e35f-04b3-9c63d78ece50@redhat.com> <8c36dd0a-90be-91bf-0ded-55b34ee0a770@redhat.com> MIME-Version: 1.0 In-Reply-To: <8c36dd0a-90be-91bf-0ded-55b34ee0a770@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BC000A0018 X-Stat-Signature: soesu9rhw4ykeb6oa858wner3wn7hpfw X-HE-Tag: 1671207884-373124 X-HE-Meta: U2FsdGVkX18xOF3WBhohk48sLBrbuc/U2ZRyfXQY/nGe5Ycam2tBrKKmv5kWrO6+pUMrl5AcpqSMiN+d4o7D0N7fsbnsQpAikEbtZTSVlYUR81NzTyGe6rM+QQhj79yZH8Cxtw+m/ce5P1ze+r8WjItkUnvEfUFU2/vY4FoJ7tF41SC0IzoHHxcSarLCKMc3dJb3ZcBzBBjZkyrzB/QDdATaFw5I0xVXPWGdStJ82HuuClnQLhyqU+m9OrW2HMDGrNNugAOUpJlsFQ1iDwWyI2+abUS+rZOOc6lEVgTt4htA4YgdKxAglti3YQzFDvhsgvzgNDtfkb5MoBrXrX5N3L2HgI0UXslCOiQmCYaRXeCOhV+OmpnkwIOPMbWYmG4uATRDgpqc9n625QQfKMYOT2gcVGF4uTk1wwH8Bc9dESirO5Kvrv4HlHDDCBWPoj1GJRs7SEIH/cqmzTeC19lnsuPFUHfV3C9kainN/rx4dgGOtiQiTFlZyFb4lfAqAYJD2lFFYkitt9ayyI/Rh75WJIaRBYBlOimQltkiaNweifuh0d/5YFUfFhl1ICigxzFVn7oG5gCa6ykVAdA57HgoxeausR3Z1HABpmnzey4lTcywduyDtTpgECWq08jufrvlG7xK5JcDLxaCLicFkBoB9gBswwA71Vwncg+DT8N9dD/6OAKiEB5LPGNItEfOYgLGTpYf0mN8SePGCNgwPSwmx19EdwAVfB3Oji5emNbxCkzLj3qTBPIrmRvu2iU6mQyV4sZhLJZcy4drdvQGyoP6dk5tdHTy34K881DVRd1otzV5zfpcqlKmboRUzPNpqIv9tv4PpLvrfc4CFMzdhaxa5skW6BPltMQaKC9oi/cOnuJq5po4O/aEutrpDmpa4X8trZ8W+7+K1GkzLfFgCp6LTSzIVqQbJcKjqkJNJJbGYYSdN/S4R0RrPWHq07eVO7F5isJCZSeNATGIhWQbhZV BLnbcncm io6sUB494Fh1bntgm5UHWe9onfcbEG9iDDYYQv5YCTcp94ZbUx0pFLxZuWCLf8fg3ke4854E4iaNeWhtm2TTW3OlOp2nZgwDMc+pnpbd6feQ9mIZXG6MabOnTwr4wd7pvwA+ZsNGDtAHvxdMElJlt1aWsNxmNv6U2N3y9Mn8dyvAiCS+0Aim4lf0DUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 04:57:33PM +0100, David Hildenbrand wrote: > I'm more concerned about backports, when one backports #1 but not #2. In > theory, patch #2 fixes patch #1, because that introduced IMHO a real > regression -- a possible memory corruption when discarding a hwpoison > marker. Warnings are not nice but at least indicate that something needs a > second look. Note that backporting patch 1 only is exactly what I wanted to do here - it means his/her tree should not have the swapin error pte markers at all. The swapin error pte marker change only existed for a few days in Linus's tree, so no one should be backporting patch 2. Thanks, -- Peter Xu