From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrea Arcangeli <aarcange@redhat.com>,
Pengfei Xu <pengfei.xu@intel.com>,
Nadav Amit <nadav.amit@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
Huang Ying <ying.huang@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/uffd: Fix pte marker when fork() without fork event
Date: Fri, 16 Dec 2022 11:24:40 -0500 [thread overview]
Message-ID: <Y5ybyFa5U9VzVcwg@x1n> (raw)
In-Reply-To: <8c36dd0a-90be-91bf-0ded-55b34ee0a770@redhat.com>
On Fri, Dec 16, 2022 at 04:57:33PM +0100, David Hildenbrand wrote:
> I'm more concerned about backports, when one backports #1 but not #2. In
> theory, patch #2 fixes patch #1, because that introduced IMHO a real
> regression -- a possible memory corruption when discarding a hwpoison
> marker. Warnings are not nice but at least indicate that something needs a
> second look.
Note that backporting patch 1 only is exactly what I wanted to do here - it
means his/her tree should not have the swapin error pte markers at all.
The swapin error pte marker change only existed for a few days in Linus's
tree, so no one should be backporting patch 2.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2022-12-16 16:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 20:04 [PATCH 0/2] mm: Fixes on pte markers Peter Xu
2022-12-14 20:04 ` [PATCH 1/2] mm/uffd: Fix pte marker when fork() without fork event Peter Xu
2022-12-16 9:04 ` David Hildenbrand
2022-12-16 14:54 ` Peter Xu
2022-12-16 15:57 ` David Hildenbrand
2022-12-16 16:24 ` Peter Xu [this message]
2022-12-16 16:37 ` David Hildenbrand
2022-12-17 2:59 ` Miaohe Lin
2022-12-14 20:04 ` [PATCH 2/2] mm: Fix a few rare cases of using swapin error pte marker Peter Xu
2022-12-15 7:12 ` Huang, Ying
2022-12-15 14:05 ` Peter Xu
2022-12-16 0:06 ` Huang, Ying
2022-12-16 16:01 ` David Hildenbrand
2022-12-16 16:04 ` David Hildenbrand
2022-12-17 2:59 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5ybyFa5U9VzVcwg@x1n \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nadav.amit@gmail.com \
--cc=pengfei.xu@intel.com \
--cc=stable@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox