From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A44FC4167B for ; Fri, 16 Dec 2022 15:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE4C68E0007; Fri, 16 Dec 2022 10:47:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A94C28E0002; Fri, 16 Dec 2022 10:47:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 935E48E0007; Fri, 16 Dec 2022 10:47:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 843238E0002 for ; Fri, 16 Dec 2022 10:47:07 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 483271604BF for ; Fri, 16 Dec 2022 15:47:07 +0000 (UTC) X-FDA: 80248598094.13.1593EC3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id C0474C0010 for ; Fri, 16 Dec 2022 15:47:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A1fXn9zj; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671205625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LxMkecyGYG9dLIpgBNsZUPusnmfyW4vuV2TgoZY8b1I=; b=xGOgVvzjctNg06uBVIyAZzcOT6lOZ2Fx1MojjvgO3ok9muMy08vsOfND4BuaAPW3TfCfLV Ph8ma7EW84BLRUj5icGQOIXpUOhHgzr9HSxJEOpxz2b7g7/38qRWb2d8zcHZ1LiPMNUh7F T0Vccjz29cutZ6BGG17ucOztJWdVNP0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A1fXn9zj; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671205625; a=rsa-sha256; cv=none; b=x8i1RwaNGhBP88Yu+Xz9asNH678LMrskynbuUY7mzDED8YexjIZK1ahebQ4LhwWkBD1JVX iaxR/+ZzgBL2Tb2Ps4KdasHJvwZu+AcjWUr2vV1n/KOTt2twMoXeuQDdieWiW7DHggzIC9 +idxF5a7VzjIxCqh1IkJVuUt8tajsRM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671205624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LxMkecyGYG9dLIpgBNsZUPusnmfyW4vuV2TgoZY8b1I=; b=A1fXn9zjQ901DtvygIiyjjRKQzc4DqxvufQO1InD+mby2JrcmFAsrEotH/wQk55KkGvQMn CXwuC1DZ0jGVg2Q5Dbc19xL94w6zpHJmU5CMQ2JG2mpxWIC/WOaH1QwDVnRYqitkZQAYmy eLrxmaQe15/kqGhAvJIz2gQAN5NMGzI= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-562-39lLcvaROsGj7u1jBXxi5w-1; Fri, 16 Dec 2022 10:47:02 -0500 X-MC-Unique: 39lLcvaROsGj7u1jBXxi5w-1 Received: by mail-qt1-f199.google.com with SMTP id j26-20020ac84c9a000000b003a7e6d38e01so1783096qtv.14 for ; Fri, 16 Dec 2022 07:47:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LxMkecyGYG9dLIpgBNsZUPusnmfyW4vuV2TgoZY8b1I=; b=uHoOk0QqovFjAMJJaUJoMl1+2hXbm+BULbynd8YrIFVHfirDJx1jI7W1pLz8zU16aT i3mi5qDvfeu3fYR3wTfiGaGCaVIoDSqjzyjZWs1oY50yPgWHBLiKrWQI/XS4s2ZKRhxn PTgXbebH9gNP3fEpjru+jezsUzRxKgof93k8fV7ljPLgn/4NuWfL11e7d65g5Bk6PwSl UU01F28q1yDv1KF5ddZ2yghcMylOKSeTWWKo0GHoe38d6eRNP1aB8qxnW2DVTzHSEZn3 pjU0OMS8LiCUl+BYtXV1wFIu+8G5JTii7+ZlsK0Ymqz4r0Wa1ouI/zKCp2gWHcVuqJjU cF6A== X-Gm-Message-State: ANoB5pmxsq3Uztkdz3nJfaJ2qmINFRJCnyrtozP84R+7FGS5bMQMULGV fqnDw8b9hxxV+ylh9L/DaYlCdqDj2kBFd3JzzBq5/TM1loqNbae36JJ4M2Vt7EM/3Lt3igdJT0i pj2ksu0K9RJ0= X-Received: by 2002:a05:622a:40c5:b0:3a5:306f:b124 with SMTP id ch5-20020a05622a40c500b003a5306fb124mr45697438qtb.10.1671205622304; Fri, 16 Dec 2022 07:47:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf5eK8zxu4MtCAROwOHMPjA4TRfLrCS+AsiC6Si+i4v1cyQH5maRZ4RJ3yJvRLlW+Au04FcIJQ== X-Received: by 2002:a05:622a:40c5:b0:3a5:306f:b124 with SMTP id ch5-20020a05622a40c500b003a5306fb124mr45697411qtb.10.1671205622117; Fri, 16 Dec 2022 07:47:02 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-45-70-31-26-132.dsl.bell.ca. [70.31.26.132]) by smtp.gmail.com with ESMTPSA id a5-20020ac844a5000000b003a68af60591sm1466597qto.70.2022.12.16.07.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 07:47:01 -0800 (PST) Date: Fri, 16 Dec 2022 10:46:59 -0500 From: Peter Xu To: Jeff Xu Cc: Kees Cook , jeffxu@chromium.org, skhan@linuxfoundation.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org, kernel test robot Subject: Re: [PATCH v6 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC Message-ID: References: <20221207154939.2532830-1-jeffxu@google.com> <20221207154939.2532830-4-jeffxu@google.com> <202212080821.5AE7EE99@keescook> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C0474C0010 X-Rspam-User: X-Stat-Signature: f4utn7cs8ee6euetfwk6amicntim993h X-HE-Tag: 1671205624-317356 X-HE-Meta: U2FsdGVkX1/qS2j6OPc5iHiaady6GmXGPPXS5pfLuG/ZX4pW90AAcND3jzlkzB5/R8U7zdXqWoqG6aPane6ZIs89UZ37yC8okJJqOLPwlLn6XJ4qQkY3xwh+DPEo7qsQjeot+UNJ7eYjCaXnw3Mp77C2GgiWPTyFUtEYKOJYBtDDiV2fIls4P2y9xVkFWdT983T+cTqqWmEJoKwSbcXWkzIVOFOP5EJU505/zG/aCvaWp8rgCkbiCUcEIWc2aLCFoFmtgAtgAydIDh4CoGQXuTo+Fzn/2wBKIBRhR9FiRc/Lmh/5RO8Ul3Ypnz5uUu/qFxbMsHiUun2VbBLL/RmPSJk7eynMJrt3a4eTL7P8IFDRLaZ2MdReALMEWDaAHK1Yn1JxHqqytBSJXaaf/uMOpDf+wRANoPUk15UUQg27GhtLLk238+QcbF4aNe/aVadv50Ag6cv3BAa1F48vAApGa/h2dneUjtr10e6NqNEXBY4HWfdSCWbsUC/LN3rof9ceJwvbgGgbDAija2SoUi/RhxGfbhpvF+klds4rBAV+ZbaKWC44qPxUPleBGntqCzKa7sNBhWKzaYnGUMbRijmMnlOi7T1kXcERsSPRI7K1WYh6k+rDWu/P8XtVJLpPgkQJ7DyBKg0sJ9N0ZNTpNAHePG2NKPZoohiNKKysdY9W7bFwNiwjxZWGuNd5m5oBAK/lcdfZGAt8oFY90w+CmtjmZ9C8MLNZbn4H+8XAq15VEiIw0mm0GKlPjXeyfEiRCN/XDhCZTMTwdMOHZRIl9ejHHtLVlUAOa//4CnvFuQ0AMonGNSChrgExjpwfpdfJUUY0mkOAHwSP50oCuI0zAWe03ZOpNyaopc91mVnNrzjOJ5RzI/bwrt8vOG1y4rbC0SeYwX1wvQvUF2UDPIuW+Edko44Gx7TN5lyRCHdjpUiCEaYU9HMcBrWmB4pr9SpJHRDp+zRtwFcfzwagrjH4nX7 +IcZAOTI fdfsFLIxPGuvtMWKOyZlO7ZEwJrWngeWhwrGJSebBaqFv/yS4p8E8LTm/tkxRh6E5YMfphTyrdL/zjgUrNHYS4FcZx2t95tc3KsLvhYxVFwZ0NUO4rh6Nt9ZuHlJVNI2IqJTuqP1d8Yitsyu9cmUq6sFrTb2A90hUnubwiTwAUowPWMj/8tcej7Q2bX7iAiO5cT8RZJAh4kGBnpnlzJhYxdZ5lkdjRUO2bHc1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000140, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Jeff, On Thu, Dec 08, 2022 at 02:55:45PM -0800, Jeff Xu wrote: > > > + if (!(flags & (MFD_EXEC | MFD_NOEXEC_SEAL))) { [...] > > > + pr_warn_ratelimited( > > > + "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=%d '%s'\n", > > > + task_pid_nr(current), get_task_comm(comm, current)); This will be frequently dumped right now with mm-unstable. Is that what it wanted to achieve? [ 10.822575] memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=491 'systemd' [ 10.824743] memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=495 '(sd-executor)' ... If there's already a sane default value (and also knobs for the user to change the default) not sure whether it's saner to just keep it silent as before? -- Peter Xu