From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371C9C4332F for ; Fri, 16 Dec 2022 07:42:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91D488E0003; Fri, 16 Dec 2022 02:42:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CCDD8E0002; Fri, 16 Dec 2022 02:42:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76EAD8E0003; Fri, 16 Dec 2022 02:42:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 64CC78E0002 for ; Fri, 16 Dec 2022 02:42:42 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1F5FBA0446 for ; Fri, 16 Dec 2022 07:42:42 +0000 (UTC) X-FDA: 80247377364.04.56CC308 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf15.hostedemail.com (Postfix) with ESMTP id 73F97A000A for ; Fri, 16 Dec 2022 07:42:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ixvI7Ak3; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671176560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p11g1cwrNZTNPGZ9JOLQCCww3AgSudE2cVlNLnF16zc=; b=7Rql7nEzALW+G2bvlnAOBe4P1oHD3LKPmWtXX3lEobRNj2EePIASQAzdAdlUB66igQ2otB udSt1d21dSHL0JFjGewqDaexm5KKVatbkPIWK/CIroFW2jTooqZpLOPYLGLyyPBo+H0ovz f1PWiNbdAbpRoTtXd3RBUiAGYilLQZQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ixvI7Ak3; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671176560; a=rsa-sha256; cv=none; b=JZMRd5AJyg8OY3fTWq9On+tSlBbYcs4QpVtXYNVs6LaX3SjuAy/udey9sskcCFql45EtkP HDslWOg5ukKmcGSKDu8hfpJjxmJQ1GbSjPwoaQzDNAqztpApB2xGVODRjTmKRTvEacFY+R UbjP4WO20AJ0lFyY42xHUQXZbUwiLwo= Received: by mail-pl1-f180.google.com with SMTP id d3so1496444plr.10 for ; Thu, 15 Dec 2022 23:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p11g1cwrNZTNPGZ9JOLQCCww3AgSudE2cVlNLnF16zc=; b=ixvI7Ak3I75fySctV1/dd+sdZTABsHg8bu7hFpLuyN8BHKmGfN3z1Aj/0VKzeMjcv3 Yx2YarpUotQqLooLXd7KrsAYxed3b55Q1KiMlbqTzvob8qcVCsK4zQv+5Jyj4Zzc3r5R SHdVgW2Siaz+bwQ8R8ziN5juuRyjNlYJzZHVeLs32oSEmmAh+UXapL/LWJIyI5s0S4fX mj0d3kfvEgX5Ts3EP3qykq2Jed42QJgR8LHUdIpi1rK1iaXOOskmnLea0OKLq37aB//X jd7hMaXbMb6TNspCjwIS3MoZWBqbBaiX9mtaUuYsEq3QpMKStj/9nSxpeMRa6cW/hSzo Ndkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p11g1cwrNZTNPGZ9JOLQCCww3AgSudE2cVlNLnF16zc=; b=ySB9HlpDaBPVn/u6oOJ/lPGLGf6swYhbOy6sgJ49aLcO95lQ143rlL0cFqwzE65xhA fXDT+8YPviFbJfXzyuLlKjo6EX8su+ijYRBv1CNAToDdmAz8L9k6OyD7ydcUaLLuO0lN 4nhC+a1tydviMhZI2fWEPSuFFBVLTXj+QTcPKs9H3tfTXZc+M2HItlhASj3lTh0WjtcY V4asM/PXmgOWDzyuv0Lx3vSuCQ/OZK2pc8KYfTYFiEPKVwcWApBb5FCq1QUXEJ8AS/P1 1js7y0uwaVODhrA3BbJySmjc0Nl9WxEGAWguCWPtpQZDScRIadxZadRplhJ6VdHdQY5x DjPg== X-Gm-Message-State: ANoB5pnLmM3aDZ7xWGUnlt6a3X2AtVycRe5BYpb1WL8Sq3HJTWX9JutA 31adEyWVBiN6En1ryKCaf04= X-Google-Smtp-Source: AA0mqf45G+6k9iUrkTKEigJA7PtUlWdNG+akMhT77GtTrdF0p5ErbSlUKD9wC544JLf8+PzblnM7nQ== X-Received: by 2002:a05:6a20:65a1:b0:aa:7eab:25a5 with SMTP id p33-20020a056a2065a100b000aa7eab25a5mr34541260pzh.34.1671176559146; Thu, 15 Dec 2022 23:42:39 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id c9-20020a170903234900b001885041d7b8sm854453plh.293.2022.12.15.23.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 23:42:38 -0800 (PST) Date: Fri, 16 Dec 2022 16:42:32 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Chen Jun Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xuqiang36@huawei.com Subject: Re: [PATCH] mm, slub: fix uninitialized variable in __slab_free Message-ID: References: <20221216033119.14159-1-chenjun102@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216033119.14159-1-chenjun102@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 73F97A000A X-Stat-Signature: qoqebq5e1grxic7apimq6up4h3q447qm X-Rspam-User: X-HE-Tag: 1671176560-817950 X-HE-Meta: U2FsdGVkX18WIqXd/emzaafQ9Rc1bC0Zuyj/2K/aavToM3nvbOI1br+ZLTMuJJgMzspuiMLQCccxXf0z7sbNmlZ2P5CRnFDv341KJBlf+efmJAL6EpIBorkZ5PyhesdHjBGxV7SG7vakconhXhT0adX3JnrKobcjkiIPZ3pma+utP5yd4W7K8Ex/zF9UQuE853ECH/77m0mIiFkfJlhzxpU9t/SPogT/ixTSWVtVVJgv7665i0XavVvI7awlN/7I5ogaqZNLRw3aF9su3p3g8ONNeVLWb10Pv4aVbTEA0Q4cdV925REfwsr4QBwQKiwz82IViTPJbrfTvj8G3NP+hrIUTSa3VTAr+XyO8pswHFVACe4vOXgpdQavN0hb/1nvQxieVgCCV86JdwneiDL+7f3mY4+LldNXafTCf1Lotb2fM3G8KiyQNaJQl67w5fOnU/OJkGOUnc/rNlVgd/EhUt4B1sVaE0zJa4cJTChwwA7IN4ZINdm+QshMKJO/0nQ6bmgADPUdol27jD8/8qsfxfXzs8ywetsvBW78NDoQ8ew7nChfW6Qyt8UjPTRY/ZgGS+IIIti43zWpM4ckfxmWyLngu1I8N16LIeZO+e9T/8uZAzC2eJd2T9FmU+WPgBzg19JOANvCksO8mIL0tcSGI/zvhBNdj3kPclCet3wmLaK7DreaqoHq+a+ARUNHGSkZSdRXTeaix71ndxlP67FfvbDRxjLZen6+i3w9dR0qDwLbbo1BaPmAst41RxwXoQbHY3oqly616xfgs+toUlDkLsPYqKvyP7ZlJjYi8swmQE03weYeX8FATnZwSAVCFkjdeOhWy8jCpTHzmqFkoF2MjwjwMjXAMcTlWCcqRt68IzpbiMNtprEJa22WN/Jxxz5wfozoz+DdBMPXhvMmzwvjwxg3vjRUPKsk8sMVia8GiqUZeD8kN3hm9KIl5POHG0XMr0ywkIDvf/WFgOaAMgT VB6wV9oL FUS3zcl8uWcIAtI7Z4hyH7tju8wbhykIZQru5yrxts9NDPyaZERUMBqN5k62E/icxHgZ0CT77k9binxoAa7XEN/H/SqkLH7Vh+jomVvngna4wTq91v9dFuyj943XXuo3S44Sp7AdvQNkLHcqzgJu5lKH9BXQ3yUzUZUekq+wuDVegwLc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 03:31:19AM +0000, Chen Jun wrote: > new.frozen is not initialized before it is used. > > Fixes: 2cfb7455d223 ("slub: Rework allocator fastpaths") > Signed-off-by: Chen Jun > --- > mm/slub.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/slub.c b/mm/slub.c > index 13459c69095a..8628c88875b6 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3593,6 +3593,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, > return; > } > > + new.frozen = 0; > do { > if (unlikely(n)) { > spin_unlock_irqrestore(&n->list_lock, flags); > -- > 2.17.1 This is incorrect because new.frozen is initialized when new.counters is initialized. See definition of struct slab in mm/slab.h: struct slab { [...] union { unsigned long counters; struct { unsigned inuse:16; unsigned objects:15; unsigned frozen:1; }; }; } -- Thanks, Hyeonggon