From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>,
Miaohe Lin <linmiaohe@huawei.com>,
David Hildenbrand <david@redhat.com>,
Peter Xu <peterx@redhat.com>,
Naoya Horiguchi <naoya.horiguchi@linux.dev>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
James Houghton <jthoughton@google.com>,
Mina Almasry <almasrymina@google.com>
Subject: Re: [PATCH 1/2] hugetlb: really allocate vma lock for all sharable vmas
Date: Thu, 15 Dec 2022 14:50:34 -0800 [thread overview]
Message-ID: <Y5ukugBX0VGz8lBQ@monkey> (raw)
In-Reply-To: <20221215143700.232f7ef0084167269f7068df@linux-foundation.org>
On 12/15/22 14:37, Andrew Morton wrote:
> On Mon, 12 Dec 2022 15:50:41 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> > Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
> > removed the pmd sharable checks in the vma lock helper routines.
> > However, it left the functional version of helper routines behind #ifdef
> > CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being
> > used for sharable vmas on architectures that do not support pmd sharing.
> > On these architectures, a potential fault/truncation race is exposed
> > that could leave pages in a hugetlb file past i_size until the file is
> > removed.
> >
> > Move the functional vma lock helpers outside the ifdef, and remove the
> > non-functional stubs. Since the vma lock is not just for pmd sharing,
> > rename the routine __vma_shareable_flags_pmd.
> >
> > Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
>
> So I assume we want this backported to 6.1? I added a cc:stable.
>
> The [2/2] patch is, I think, 6.3-rc1 material?
That is correct. Sorry, I forgot the cc:stable.
--
Mike Kravetz
next prev parent reply other threads:[~2022-12-15 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 23:50 Mike Kravetz
2022-12-12 23:50 ` [PATCH 2/2] hugetlb: update vma flag check for hugetlb vma lock Mike Kravetz
2022-12-17 2:01 ` Miaohe Lin
2022-12-15 22:37 ` [PATCH 1/2] hugetlb: really allocate vma lock for all sharable vmas Andrew Morton
2022-12-15 22:50 ` Mike Kravetz [this message]
2022-12-17 1:59 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5ukugBX0VGz8lBQ@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=david@redhat.com \
--cc=jthoughton@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@linux.dev \
--cc=peterx@redhat.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox