From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C5FBC4332F for ; Thu, 15 Dec 2022 18:45:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 756BD8E0003; Thu, 15 Dec 2022 13:45:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DFAE8E0002; Thu, 15 Dec 2022 13:45:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7B08E0003; Thu, 15 Dec 2022 13:45:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 482B18E0002 for ; Thu, 15 Dec 2022 13:45:17 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 115B6C02C8 for ; Thu, 15 Dec 2022 18:45:17 +0000 (UTC) X-FDA: 80245418274.04.181EBF1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 25C341C0017 for ; Thu, 15 Dec 2022 18:45:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qmWy52v5; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671129915; a=rsa-sha256; cv=none; b=pz4CY+IL5XkgDbw5+LZT6S3Mws2oIRU+bzcws68RvnYwT/pqOjKevYMSV0vft55/H4Hvkx RwVAhDsfBBYvYycYz/IdO7ga+/2bEIxLfabZVUgZb0dtPolQxq5F1pOJP3qqKw97BbBK5m jPpHjZ1CZUbwHqDQwJ6cIzyVQEvxNO8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qmWy52v5; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671129914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2f3RFg8lKPZEmxg/33DtgJz7ZsALqBstxpKP4BpvF/I=; b=M7AbYWkVR5hsiWcZ/IgGXvjkkgOTqN8Ab3i2PrOkoDL3TFZTFRpo7tkZmFH9HV/QOheqlN UiG+dCkyvLQM82Xp6LElN/hngVYNBJMiDcnWfWFttVquKjPK0pWpAoeSWssRzN8vLvs0Ra OLCw3DFoYpXrE//Rlkd3lx+9sCv2mpI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2f3RFg8lKPZEmxg/33DtgJz7ZsALqBstxpKP4BpvF/I=; b=qmWy52v5M1Cn1nsPjbLE5vPwki rauwwLIkT3RZ4l8uaifRy3cFnwWg/FJ0qrTlWwiG2l6ZyhDnHfedJCjngdVQqJ/DTGZ5tQRKJrFBv U3hFPfNGg5EWx7AmLYPg+X1dDEgGur5NyuHGFFb29shQ8BLcCmpJf2gYLsdCOj0UphiodCYqlxIqY VVpnqh6CfUAfhKt/G3eW5HqVc1Wn28TFt/Jxms44MKyzI/5ri+A4K5UhxzjL/M4V0MAokjJH+nR0Z 0MphCPLU3nK9wyxTT5aY5yWu/dp/FFC+Y4yevD/QRKd10VebhMJjdMTpnLlmc8p0ybTxbNqUOQI0s mVh/Z0xQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5tED-00EdoE-Pj; Thu, 15 Dec 2022 18:45:09 +0000 Date: Thu, 15 Dec 2022 18:45:09 +0000 From: Matthew Wilcox To: Chao Yu Cc: "Vishal Moola (Oracle)" , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, fengnanchang@gmail.com, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH] f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() Message-ID: References: <0a95ba7b-9335-ce03-0f47-5d9f4cce988f@kernel.org> <20221212191317.9730-1-vishal.moola@gmail.com> <6770f692-490e-34fc-46f8-4f65aa071f58@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6770f692-490e-34fc-46f8-4f65aa071f58@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 25C341C0017 X-Stat-Signature: qfbeezptmtka71wdt8gfwh18d6m7k7hf X-HE-Tag: 1671129912-979743 X-HE-Meta: U2FsdGVkX1+i0v8UFCMJflcYv+a54r7T8+HRzFiTIw5FoPLu26TIr1sZUuRTlMFzGfdQrBCAeb1t5yrwgJ6A3Xrbu0cDHiljiF3xcfR1D/+8SYBCFw2pu4Fw8KnCgcv7y0bAqXDfxr7aJTUjpyVLhTkWuobDjU/a7abBKn2K7iQQu8sCkugpTdyIqVUVWc6vNreke0osYXsKJ5P45zh6TqGMbS+437Gdu+dpYs7eLHB6nzsBhtxLo0Bf+ljC9ehKMOYzoNEFkyJuHnFKq28zq9klNGXefUtZ9YPqit9qMbI/9RE/MwbWGrrAwRF+xX2+eORUuPNlX8AXVogYWEa7/1E75zCeTdtBBanbBweOOKRiDbmYNbSseoffaTsnOOK1Ghda0GiaFoJFlYF1c3WuLdx8hSgmC8fGV0kUfkRwYbx3mNZUJw5MLB8NIkKzIvaV2saWeKizWgdSkB9qMCSC8t//eJmfewv3mXOLhATPWwsAVw9Z/1hU3zHD0t+T9UIHLv/Gk8sHAUGeAEjEzef2LYl/3kKbUuLPuiMUybNH/BuLzq9FozjlTwKjAz7J8tJolZT5sSekbus2HoqykpqlKWWo96zS03WQPKzHY47OrHfIWkW1ptCIQtcPYjxAtu9z65R9lSXXkinuGP5/TWndWFJbcKwBMWlLcMS0+3D4U7b850JZE/2W2LNq43b0XJwFC+bkw2B95ZtDyZI0cCnat7gG6woyZ5BZGiXKlwBDPCgAi2N13yK23sVzxzionKcoObVJ/PHegs83yLKsRc80MqMVpUzRpfg5ND89A3cLIV717Ne5tMy5lMh8zcS60vfhwJt0P202y5NhK4FtcYyP7JxkYbozfDA/O137DhT3p6a8h5bz/GdO9+FrhYqKVuOIOwjDEVK4XatMWDriip75mSiiuLgaGOmYljKqTs6aYT2bvW+n3+ookH+TkNhqsYWRBkIrZkqqcS+i1FCghJE WEv8hvgj 9OmH7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 15, 2022 at 09:48:41AM +0800, Chao Yu wrote: > On 2022/12/13 3:13, Vishal Moola (Oracle) wrote: > > +add_more: > > + pages[nr_pages] = folio_page(folio,idx); > > + folio_ref_inc(folio); > > It looks if CONFIG_LRU_GEN is not set, folio_ref_inc() does nothing. For those > folios recorded in pages array, we need to call folio_get() here to add one more > reference on each of them? static inline void folio_get(struct folio *folio) { VM_BUG_ON_FOLIO(folio_ref_zero_or_close_to_overflow(folio), folio); folio_ref_inc(folio); } That said, folio_ref_inct() is very much MM-internal and filesystems should be using folio_get(), so please make that modification in the next revision, Vishal.