From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0076CC4332F for ; Wed, 14 Dec 2022 22:17:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40B6E8E0003; Wed, 14 Dec 2022 17:17:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AED88E0002; Wed, 14 Dec 2022 17:17:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 200F88E0003; Wed, 14 Dec 2022 17:17:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1039E8E0002 for ; Wed, 14 Dec 2022 17:17:49 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D3FA4120869 for ; Wed, 14 Dec 2022 22:17:48 +0000 (UTC) X-FDA: 80242325016.07.437C90D Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf07.hostedemail.com (Postfix) with ESMTP id D7EFB40002 for ; Wed, 14 Dec 2022 22:17:45 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=IaB8dJNb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xytlLhEZ; spf=pass (imf07.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671056266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jZhjVG6gfMYsAZwJZXu9wyhXcGT+CO8v3hE1QUhVpNU=; b=o0LhGo/f5Am3vsjfcCSmLfKRC0M6hHvaDsYPEabn1nqLXr5jcQHlRQefaONKvYa00vj8E/ OKNHvL3m6xcU9UHVlxWlZdEMlk38DhM6C5Qgrc0dBR6+tLh3mF/CYQOL5Xsp4w1fDjhmTt vJqt8VroT2LdM8PgnCaK5HdWzDC/ntk= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=IaB8dJNb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xytlLhEZ; spf=pass (imf07.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1671056266; a=rsa-sha256; cv=pass; b=tlIeZQdmJvWpclZpfKUzR9ZOdxAAplGlTCSGMJjCkZQ0eD3+K4WQszddYEasaNngYlsOhn 2qKXp3/yIFmQmWpn0nQfRX2t9wjv5Ay9l6b58ppeilERUigkpJggBWwQVMgkfbTOVAC75g o7PjaOUUNiBhhNpT0/pAy+0tYek4L+4= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BELwwcV023822; Wed, 14 Dec 2022 22:17:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=jZhjVG6gfMYsAZwJZXu9wyhXcGT+CO8v3hE1QUhVpNU=; b=IaB8dJNbjn7Eg8SKj5xwZmdTkb7jZUPcqpmxK0Bgu/XaTOGeWNZvv0G2xjn0bVSxPdsn jYd53O7lihKKDSPOu8Lj7vLRmO+NSQtEt13AeTVOOBsSRirhlglHyQtwrgAQjSXA6YKc LJYdQ2BUxBeprvXoIjBpoYBkOULKWMM1Thl/Gcp6CZRSpZJQNNaA82QDMj5utkWLQHWh 190l0w5X3KxlqhWySMFjUvhGwKwX4aGHkmvAQPZm+lDETR4ux49WIvwtj3mDaQox9rwU wJP4J2WTQPPP5dswfFXS35HaTAu5zmP1yaHf+5HtApU6cEwY5AHjCQm7wUjtgcZge6sa Cw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyeruhvw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Dec 2022 22:17:31 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BEKvprE031114; Wed, 14 Dec 2022 22:17:30 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3meyepqmbe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Dec 2022 22:17:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h2JnL286kOFEdi5YOb5Jc45oBlE8TrhNjLteNRFR5VULRxawuFLIZabic8eTB8A1PsiaDsbHHf8mDGoi90Tp5x7YIjJJQ03FW7bqb1yAQCa1Zs8fqs/DhjASg6RPgXhSGkSgi3HkdR1cHYrz3jxJPvw/KjSRg3pvQKaGuI7nL0vvg0RVRTHj+gcAoJdUyO/2CVtEfQRcOgYSAGlTJN9Ag2lgDKirIPuIUwRrKgdSTIkHtWH/CG8oHRLICRL4IPx26w0WXTeTBKENoOnqiNaz/nmsysMf/TZ0D3nz/3z4Xp5trHP2j0ar8Aa9elpBqyJASGMfs9OUPYI8aprKsamKOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jZhjVG6gfMYsAZwJZXu9wyhXcGT+CO8v3hE1QUhVpNU=; b=D6MvfjQxwr7/t5Uoe5prLKL+RbkU7GQFvM+0mLGIuv9Kwn76ZxqDmm0nz3qskLnOHgIMa+QQG4Fzs6mLtqvTQ3OToD0nQSSM8o0isM+Yhr0ZFEgmgnwIkpYE4E8KkRJbaqfh3+AymKAChouxEQtWk3PoToHQedt7vyzEetaXMMo7Q9aEEXBG84uXhR2h7FKUU7ZA+UIEgm2VWMVrsOvKiKwwwbbfC0aXCXWAJW4SC4w/s2awmsff+aXylzIU+Q685S5LAjjBMkEuSWoTVb77GCwP9RtQ79bGcxjrFjX5hG9BJ9ujqcuc8a7q+1SkOYN0MrFH2GHnyK1u2sQpnELWXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jZhjVG6gfMYsAZwJZXu9wyhXcGT+CO8v3hE1QUhVpNU=; b=xytlLhEZYWpFj00XGWiYgY23llrQEOw27pYHC0xQJxD4hZclp+iDB3sEgetZLEvZ+zQ6FssW54UKvxWq/pC5aEG1f/j+cMid9UFBhGL/tAjMDFacd3c46IHZEFL0GSeeQ3NTUGBxhTwy/7GqgCDXYA/AgmMtfkdRTU0EEEF6V5E= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by CY5PR10MB6237.namprd10.prod.outlook.com (2603:10b6:930:43::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 22:17:28 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::8d67:8c42:d124:3721]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::8d67:8c42:d124:3721%5]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 22:17:26 +0000 Date: Wed, 14 Dec 2022 14:17:22 -0800 From: Mike Kravetz To: James Houghton Cc: Muchun Song , Peter Xu , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 14/47] hugetlb: make default arch_make_huge_pte understand small mappings Message-ID: References: <20221021163703.3218176-1-jthoughton@google.com> <20221021163703.3218176-15-jthoughton@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021163703.3218176-15-jthoughton@google.com> X-ClientProxiedBy: MW4PR04CA0217.namprd04.prod.outlook.com (2603:10b6:303:87::12) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|CY5PR10MB6237:EE_ X-MS-Office365-Filtering-Correlation-Id: e3338295-c2a6-44bf-5510-08dade20fb49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9ubYYBX6zBeKUxeR6fx11JMXBfei0WXHHchFm36GNb8HmKku2Y7/F0F7EBetbAu1Wxh1kJHkqwg6LNme0mkg8+GzZ10ecVyqnBuZtfD04MisPhhJKI03HnN1TgNzTqUExFxsHPK5BmKsaj+jr1OOdbwI2vN99PZn3IjUI9VheZx321w1BNHGa8ClbuldtY8Kg8ll0+goCF4B5I1Q0lbbtP7Cql7L72MDCamRqvRidq8VwUTdY2aNDXW51SZ9q9cY7jnk15rdMtG48svXdWoEYlZ4RP61qe1r30FOgXSRHySKoLJF53B7eYQH5B77uaY8khjOBOi584Ua40yy3f2OcZxkDurcjOeHE2NPK7Ojtf5RviQGl/+BrPPDsnd5KTOvM4/WRibvPy/bIJOk4lPpH8LqwMu7oDpRtD4IHbHWy1YF25rgSl+26DBqvt/fAtkGalLrE7QdxXxieRf174PYA2aaFt+aEWeK8287oVvJ0Gh8aq6LH2ohsbUMSmIBMg1Yk4GgMgIUI0NM+MuzkTI/JW7Ahh0mOiKKSwtTw94J7fVsk00+Ubk8sz+1Kaol4SWVyX/+3NiRq9szkPFMrgvXqvfIf+PsepK3bHiDekpHmzTbFx5RA2qqv/llyG4AOUuSsMdAMV1KevYoGSH+LaEO9MgnSEViZ7My2cegL9iF7P4CJ2ECSg7vu/WJ36kBhHYd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(136003)(366004)(376002)(39860400002)(396003)(346002)(451199015)(478600001)(6486002)(6666004)(86362001)(41300700001)(2906002)(38100700002)(5660300002)(44832011)(7416002)(6506007)(186003)(53546011)(316002)(83380400001)(66476007)(66556008)(66946007)(6916009)(4326008)(54906003)(6512007)(26005)(9686003)(8936002)(8676002)(33716001)(14583001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?87e55OvQOC7M5Wn4YPQiH1agroi8bdXaaVTqXF+fdO+LCQ8IJZE0ny8FFxkd?= =?us-ascii?Q?TyhMBfOVWeFXYw5bRCWd1Nckj530/gT3ZnehVt/NwlybAMbRuiVElF/acK77?= =?us-ascii?Q?UuIqH/QuubcOWd1W1s6hEfWXVMZdWesYVFa/93LEJJEYW3icY5LSVZy//Q5c?= =?us-ascii?Q?g9dqfiJwgTLapuMpaiP9apd0aBsfIh8ssptJ2XQT5EkL1DG4s9vd7erTpTP+?= =?us-ascii?Q?+oXU1H+4UVmjDTkOq7BQUWfrwukdXpWkvOKL7ErBpvsT6c/kXng7Gc61WZID?= =?us-ascii?Q?phfPGuP0iZ8Zn6co+HWvulVmR55c1cPI1GfqvB+1DwF/6paYNeUTHC+eYo4/?= =?us-ascii?Q?spXsMvhR/Pxr/P9ZbrZmJTq1oSu2fJstQWmKXFDUAvmU9fvdiqDTLkxYQ3yu?= =?us-ascii?Q?yBUsqkKdwLMVdFy0rS/sx9MBFHQ0onX/091f63Xf8AAgUWyTrVQiys4GZVXr?= =?us-ascii?Q?GLWII15ud4gX+EPBPEKaoKTImpLpE/nQiMcvepbS5dIBs6c6CHAxcv9AZY/l?= =?us-ascii?Q?PWYIV0D/FyvTYTLvr9wVExQzhjyNLYzHmzGYJzer9cORh1SI9rq2yNBrov3m?= =?us-ascii?Q?rookle5ZFeJBesOt6vlGsLSb6FtWmpNavrIUZF+QFaNDivqfcM8lhpVFs4rb?= =?us-ascii?Q?XoqJt80IdDhq5wYsV8Q+3qJ3uMcuLNeP1cG8sh1US8ej6lXASkES7wWjOoiF?= =?us-ascii?Q?PQx12hyCIVUKgW+bjTdlvBVkKhzvudtutBZ5wJMDVVIPCZxIWs/w0p322ykf?= =?us-ascii?Q?CyxrbCIp+OlAFUSrwyXQmeGfEvT6dewjEHNaODcLoCGwtw1NGIrkpUNWj/d7?= =?us-ascii?Q?lVVVY1/hn2fyjTQ+C4vOOcR4o37/VA11PzUAvTgyZBHsJAKqbbJLJuHN4MeV?= =?us-ascii?Q?YP06TU2nWscFNcFVCxUcBFwVsypXsCHawdNrDk8O+ndJGNha6Jnx/9kLNnUF?= =?us-ascii?Q?GcUiXA2ZGgQVaVOYTO+immz509mkDcTgMuIeHfaUYfDJtJ6DcNW0juSEhqk+?= =?us-ascii?Q?BrSODzexbnz1eS68FlPT/SrCJO48FfvnCxIKwkD2GW+mQJSSaeU79URvO5DS?= =?us-ascii?Q?+OnKDvdqI2oq8Zwpndad8WTwQh3L68ZM+vHoG7+xbIe0PJ7N49TcDPvIMwDH?= =?us-ascii?Q?vvgb01wPmHwioTq/N0cbyg01LZ/vfCkPd3Sl0TPOPhLfvNy8sEgzbaY1bFMU?= =?us-ascii?Q?adeBJWEuEhwgWw3wcDNXPd0YV/QEvU5GYebtyZp8grtNRaJZv8hICfe7pMxS?= =?us-ascii?Q?o8U7cVinLTgwJEHD2+p2cL3IhVApoYSjBzik+E12j417EuZr4+wKJdWjKjn4?= =?us-ascii?Q?95A2lbgLBsfWUddyYm6R/tm4U8VeSYEiNm6hbcX68mXpnCkQxf/0AQXKm7Lo?= =?us-ascii?Q?5VRsTpctYlHOd6lNT8H0B43vilrSGmegjeRbvvJy7WUzRRI3W7YdJ0K6XeAO?= =?us-ascii?Q?MOAF5m/p20eUONYqYQS9CKUupSqgK8jF/MtXKMOlAwjrnJT2S/3ExqC9lMKl?= =?us-ascii?Q?PlRvLV4xxybjNbN0+d3Zua1gbGCPrZO6YRNOMvTUnR2SL9QwaBt7P2a3H5uw?= =?us-ascii?Q?fDSHFNwoD/Ad8+si3bV0PSFXVlY0NvPxX7My/iZxRn29me9F4ZDzOdH/JJv0?= =?us-ascii?Q?QA=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3338295-c2a6-44bf-5510-08dade20fb49 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 22:17:26.5209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vL9uqebJT0m6XJTrkraqmd1lTLz23VcQuzFYKxosR0bdraX8JbXjF9Zw2O+Q2wzdlfnkzw7mvpCyunRmMhwqhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6237 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-14_11,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 mlxlogscore=783 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212140182 X-Proofpoint-ORIG-GUID: Kd97RpbF0XmSwCxDYN_JV-MbalQpFn6D X-Proofpoint-GUID: Kd97RpbF0XmSwCxDYN_JV-MbalQpFn6D X-Rspamd-Queue-Id: D7EFB40002 X-Stat-Signature: yg9o1w4goizjbkzj6edoq7hjgmupo9ha X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671056265-368659 X-HE-Meta: U2FsdGVkX1963WCXXCp2+3xGcUCml9jR/mwpPFc1E1v7NFWESq6PPMIfw/X+F6VVz/B2uYWoLfowwqmFG5OC07vo149A4XzO40zIpZE14c/IQ+/fkJHNl0FAFUjzYoMmZQRCOfg4ZYRFIKUIM5Qi02igVLHOED8mqbGuIgHieww52e0AcrsVcU5nLp0zEcVP0xpNQPoIZyeVqOw00l31MnquxZ9wSO6Obw96fTgQ35+YkZgVg5wa0xa9JKw0amRrV4LF3IqXuwgbVrWM2YTp8RkaY+xnjp8BmVYCpOrmacXPceR/evVXQluUInsgTptPzc293FI6iwtU6+LyFI59cRNYeaJFe0J3AVrRJebD9r7wOEKua1ifRg9nbBpPkORJ3jKcKfOzScLp+1oNFTwPwBf6LSkJJtk2Ld1jRxPEfIYZREWYC86iWYRxh3mO51FVa0a0LPShiPXtSrqnLLMA71EY80Vxa5RwV1if53rKSvDdhSxT2RhWHLoB7N0laD41GiiBLBKREZqQVCOZa4h76bTDcgKjpM8AgPqen3EH7HkmfMTN1hbQJoKEdK1UTIQdkgVnbZAZdR5BKd/B9x+GNILp6pboCdZQxbZez+jRktf3pfk1kaqooYGSb86DpjSYs7c8i9tOgSc+HzTB1Wildr2VHyGX7OItW/LWd9GU7JxsQNddWmcaXs7A2ZVQ4QCyWIql1rwgJcVcpoJkoZxnsTm2OV2rmWdQfaivbMelcyD6GKlgZwbSsjUHN4M2Qm2yIL1WABmg2pxEwNSSK10N6tte/EkHahF9WCHieKAH8h8b+3kedQY08Nbbp8xNKKAbcDIUVVzGYtKdKH7n1YVzgFpOHXUUQhJF6Tcz5DwHSvwNkgneurJ7yyWXCFhbeGaXLx1geHB7fUSBxox+Bwh6kpNUuJ9iaoswjnatP14NqCkRyrbB/azd1r1wHQvt7wCMn8tlKcrFStujKO4fEOR qdb0MpgM YRKSjRmN5cGoWehf1w3xc3pR0YE9yCiqz4Kng3XL0GDN1HzeEeAJm2cX3zYIz9/gRhB++wEoRObdMIU3e1pC6dyfX8IBX7Nflo0WXfGSkAVX/EWM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/21/22 16:36, James Houghton wrote: > This is a simple change: don't create a "huge" PTE if we are making a > regular, PAGE_SIZE PTE. All architectures that want to implement HGM > likely need to be changed in a similar way if they implement their own > version of arch_make_huge_pte. Nothing wrong with this patch. However, I wish there was some way we could flag this requirement in arch specific code. Just seems like something that would be easy to overlook. -- Mike Kravetz > Signed-off-by: James Houghton > --- > include/linux/hugetlb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 4b1548adecde..d305742e9d44 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -907,7 +907,7 @@ static inline void arch_clear_hugepage_flags(struct page *page) { } > static inline pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, > vm_flags_t flags) > { > - return pte_mkhuge(entry); > + return shift > PAGE_SHIFT ? pte_mkhuge(entry) : entry; > } > #endif > > -- > 2.38.0.135.g90850a2211-goog >