From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81664C4332F for ; Wed, 14 Dec 2022 15:57:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C96218E0003; Wed, 14 Dec 2022 10:57:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C469A8E0002; Wed, 14 Dec 2022 10:57:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0E408E0003; Wed, 14 Dec 2022 10:57:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A19E18E0002 for ; Wed, 14 Dec 2022 10:57:18 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 41B54C0EE1 for ; Wed, 14 Dec 2022 15:57:18 +0000 (UTC) X-FDA: 80241366156.27.ECB7EAC Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf14.hostedemail.com (Postfix) with ESMTP id 43E1A100004 for ; Wed, 14 Dec 2022 15:57:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IQPDVRbS; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf14.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671033436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zAgilxbGazSp71eLdPPUus+wlB1QY6q690i4gblM8jk=; b=q3S8gA9tJ72TuTtul0wlvY9pWSUEkLdIQk4CywoGBH0xd5U18HcJEGo3Zv1THf/hB2jMbU Hwmonn+uH2SZtsxr1isRfaxhFIi/2x/Z9I1PgxKGK/CFQFNRVrACyNW13tBOA8adksiN8K /pcK6HVzq4D/XQyPT3v0zEmoTr1cRwY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IQPDVRbS; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf14.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671033436; a=rsa-sha256; cv=none; b=pjc5/Pi4QbNWftgD6qREisZRKAZXjOd1MkhZjCKY6LtDBc3akHnQiHzDouFlx6RR4BGZg2 QUEoFoUeBl/FPn9IMQH3+RDj3uUTHx8Ff2L5jglYGipDmqD9dtB+8GxlEp4AJhgQgHIDgk SJSvpcWth5cRGy00+klAZpaSMNhymIE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671033436; x=1702569436; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5LFXBukgQPsSVobJ4TQvaAaS4znUymOqfbKoEQKnuF8=; b=IQPDVRbS//vwnNKmi0LsWYjuHNX5mQCyKCEME9uHl+kK0S2bzi1SW8nb ffec8w+87+hqyPTyQl6IEVbKnXXUDR4n9iSHPGqHLeeioNuIHeFy8Hc5D /ZM6hl7Q7PVMI7lVSqmxSAsicqKv2Z0h7j3h4hO5N4YIuoRJbVQcGwrFQ B1IWXz5LJfgso2xq+uUZpUfm2se3+UHiPr3uusnHpfWyTcCACwjaLF5uy 8hM30KNhADOWy48+5Jj+ZOVexAucBUulAUWc4qtey3DOrorjDwSSaULv0 KggTx058fHHaOWVBnFTvenp1okg/z5v0WGRt+98DI1BYGxQTgqq0Ttcog g==; X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="380640650" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="380640650" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 07:57:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="737738842" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="737738842" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 14 Dec 2022 07:57:11 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p5U86-009t4i-01; Wed, 14 Dec 2022 17:57:10 +0200 Date: Wed, 14 Dec 2022 17:57:09 +0200 From: Andy Shevchenko To: Eric Dumazet Cc: Stanislaw Gruszka , david.keisarschm@mail.huji.ac.il, dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state Message-ID: References: <20221214123358.GA1062210@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 43E1A100004 X-Stat-Signature: ou8q7tkx8onupysa1gtsgat1yc5zfmhh X-HE-Tag: 1671033436-909454 X-HE-Meta: U2FsdGVkX18sxi4MuHEJh00bfvQGnkeBMCelrM9ScPWZXkwBD4kbvFjJWh1x/ENxbSxNxH/VNJWO8Cdeik3tCK+wO7UJj0JJL0qKbbEf5DskMy0LKoLY/Lk5ykoLMI6iwUptGzH6JqSe0DaJp3vqDbnuBW0HGkclLOHX/BbF2pn9VnPdoUpwbcOkQtP2cu0vq789jZ9LERkSC/v4ueq+QoQlaN7V0nQTMllEEX/HZqoWphn6l0whUTONqFwBwq+1GyCd3ajqyTbu02LYl7+KLE5FH8LEjfZ62Tz/oFpVnNzgNivz7V8Qliq5DeQfUo/silFDW4jsQ/SCu343JWQVLdkmiQiZ3Nz7R2V3IKmSsvuP3FlDWmZFMPy1ZISJDeRBLjjEbSu+I6cutmMetbRYzN0RdoPiGF88pNXb5nfqpTxu846nYOCjCb8ujHBxXY8Vr/xE1e0bvQJ6fgqqsVtqNoMkggkzMPQPwfTmbpNLnCRZroTIGcCT4+o+z0FLk0gZghs49aL90huKx+LNcSGu+jqswvcXcS6QL2OCwH4kjrNz7aFTpV9eEnc+2fArejgjWlq/sFXpOwZ4niuol+JwXuS2BpBBhagyY/0/Z+jBgQ7vrE9yd9hklJYUs8tY9bpygUnKfDwiC5+a8XWoLbR50x8/ANv4wthZfqiAl86XN0HjItu15gfAmKEx0HW40z8G6ONiYL0nbwfUN1mKW+Ou7mknsf5+Wm10e+rSyUtCpQT2QqQ80rX+0QVSMAqm+GleDXlovJQLUxJL+A2axF0Dl7Ea9xvb3kzA5k+J9CY88cuSvugPy+ylGNiJhB3cYUJsfmde8cSLJF28BDnsFBslEn+WhT6VKZix2HS/zMtEORSw5CZe/RFD9+pKjl9Y4jRT7GPk2yw96Yoz5wvh+k9QR741mBka+rn90VhjDdorxVg38VLWSxsICQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 05:53:52PM +0200, Andy Shevchenko wrote: > On Wed, Dec 14, 2022 at 04:15:49PM +0100, Eric Dumazet wrote: > > On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka > > wrote: > > > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > > > > Please CC me on future revisions. > > > > > > > > As of 6.2, the prandom namespace is *only* for predictable randomness. > > > > There's no need to rename anything. So nack on this patch 1/5. > > > > > > It is not obvious (for casual developers like me) that p in prandom > > > stands for predictable. Some renaming would be useful IMHO. > > > > Renaming makes backports more complicated, because stable teams will > > have to 'undo' name changes. > > Stable teams are already overwhelmed by the amount of backports, and > > silly merge conflicts. > > > > Take another example : > > > > u64 timecounter_read(struct timecounter *tc) > > > > You would think this function would read the timecounter, right ? > > > > Well, it _updates_ many fields from @tc, so a 'better name' would also > > be useful. > > Right, at some point we become into the world of > > #define true 0 > > because... (read below) > > > linux kernel is not for casual readers. > > P.S. I believe you applied a common sense and in some cases > the renames are necessary. And before you become to a wrong conclusion by reading between the lines, no, I'm not taking either side (to rename or not to rename) in this case. -- With Best Regards, Andy Shevchenko