From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D3BCC001B2 for ; Wed, 14 Dec 2022 15:54:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 018A88E0003; Wed, 14 Dec 2022 10:54:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F07E38E0002; Wed, 14 Dec 2022 10:54:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCFA48E0003; Wed, 14 Dec 2022 10:54:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CC87D8E0002 for ; Wed, 14 Dec 2022 10:54:04 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 93FE51A0ED7 for ; Wed, 14 Dec 2022 15:54:04 +0000 (UTC) X-FDA: 80241358008.25.6CAA8F7 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf13.hostedemail.com (Postfix) with ESMTP id 6B30720015 for ; Wed, 14 Dec 2022 15:54:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GFc25Kz+; spf=none (imf13.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671033242; a=rsa-sha256; cv=none; b=qV9x9Fu+TbF9OPvx0Y0wZDGqAdSRMUU2RYJt/6/qN8lgj3equJL6cKpEkncsjwgdfR9sdt vUPXeLWWjixljr5TlzHigHbmb58h+iK2FdnUkcIKU8+l1OGC/ftCarUsx3n2yRiQyWASgM 3eAHbaKaPkdfUpY8afvM4bRWbVv26tc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GFc25Kz+; spf=none (imf13.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671033242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SNwsoTEw6w5KNGO9hLlhSm+YSawuliIutMAa+xnFn8k=; b=xQK0+kJ0CGfzlqRgqU31YCLvQ2BFKXhVJ+3LiCxI1r2qc5aEXnXw6PdWbUukE1OImC3QBR zn3FU8py7hS2uownTlvImap6hnSuWaHEuZObl0LKr5Yx831bc+GhGUpradYj4Cl4iQeTfX 76iIQArHhSobMR4UChIGxPcKtg8fF9M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671033241; x=1702569241; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=12BnbcHagZMkwl9OeOA4D0nsPFyieVD2ck3mCiVJ72w=; b=GFc25Kz++bxigRSeBBArCytuPHPtcWxiROqN704ehUbdx9OI9Wych82g bCHnDWXdyK6fZGtT3HxLu4qdEe99hIfcyBAnjY9xRl/pr1EoOpS/Sc3CF YItKIoPJ5Ca2KX4waxdKhO2e4vHOnRmmEPsGtWMgTs7412rcdzmsaepZX 81ceFiN+C93sRDchM3uAW2KVz3lKVoyov9tGR0JWvOlo9aeDuK9wcfUPt t4T7oxzaBjrZVpGUq9s1Oc6KJgdU+Yjbkxv/Bjbu6j03xJgfvI0y9i9e+ OJ/biekhXsIW3I0N5ZJ+GwEuFW13ZW/WFHCA05JTOFF3hnVilPAO2Kc/a g==; X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="382739968" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="382739968" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 07:53:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="642545781" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="642545781" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 14 Dec 2022 07:53:54 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p5U4u-009sxL-0B; Wed, 14 Dec 2022 17:53:52 +0200 Date: Wed, 14 Dec 2022 17:53:51 +0200 From: Andy Shevchenko To: Eric Dumazet Cc: Stanislaw Gruszka , david.keisarschm@mail.huji.ac.il, dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state Message-ID: References: <20221214123358.GA1062210@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6B30720015 X-Stat-Signature: naxswz4mg6jbd43sotoq3gi8ridrhxid X-HE-Tag: 1671033241-465230 X-HE-Meta: U2FsdGVkX19bZtjDqHO4ur+yRYLSTxopcvXchZcmvj0BEH62/Y0GLozTKUzLXntKO7sM0EcPKjY+EvzFPKNy19KKAT81bcxhLq+oqvMJg6ufh8mMq+yuIqcIqYhDnWTa8gSlRcirCN7KKcfDcEUxC/wTAsjAFOPfYLcHjImsVwbhtbGhW4iZLAh88Y1o+Q3Gb9Gt1sFlJU6cgaiIowjN9+4UhxXAW04LdaDspfpai4cKU95QAf9NaXuwVpt+JplAUH0qu94sjosFpCBsEsJEFScnOdGxOdsJsfzba27QHPBhzz17iVeSE554MAqxlEMpo6wtMclvmTFIPN6TgtmeiZNYvyZ05DdwVc92788OKhcb7x0B59+3uG758yNSUgH6BDdEZjzg+JZamO21860krHcqge1NyQdjAX/qCwlfsu1J19BIhOccasZoi7lqPo+DYhZfjCkvIXuqZJ1XgZSrDGn1YxHKySXf7koe0hOjdJ+BEo19CPH7nhLyYvZDoGhsm1+gakTpaRhWpMDWsQJEOCZF7BDq1pEcIyGGe1d+rE0X8RUrnis7y7Hcfru82pOc6OiElvDvIpa/addix7UoSPTKB2sXYu1feIEY+eUa3rqcJ7FGSlziaWnkkp5xenNfPGguqfkneO/TR0iD9qaIHFX5lZlMBR8dpy44TMBzn6AZAm4kYeX+mGYwbLykBDQrjyGAPYR1v5LSEbq2netvJyG4jsYUIPTCfDlBQcsxbBVtTtYsyH1/u4Q1oAA0n+/7flSNFtooynPK/0z+g2NzlUo2e81sErfpUc8URB4AeW9CyvtaVOYxGgrzMZbs4rpEys7SO233mDVqV+WFo8VNfNDDbssIAVTTfHkyF4Wg3lRa8e75Jx2vc94MzwVui7y5i4k1iH0wLmYWJZ/lByX1RDLWMJt+fNl1uBAMuMdj24dAVdcyiJm91A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 04:15:49PM +0100, Eric Dumazet wrote: > On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka > wrote: > > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > > > Please CC me on future revisions. > > > > > > As of 6.2, the prandom namespace is *only* for predictable randomness. > > > There's no need to rename anything. So nack on this patch 1/5. > > > > It is not obvious (for casual developers like me) that p in prandom > > stands for predictable. Some renaming would be useful IMHO. > > Renaming makes backports more complicated, because stable teams will > have to 'undo' name changes. > Stable teams are already overwhelmed by the amount of backports, and > silly merge conflicts. > > Take another example : > > u64 timecounter_read(struct timecounter *tc) > > You would think this function would read the timecounter, right ? > > Well, it _updates_ many fields from @tc, so a 'better name' would also > be useful. Right, at some point we become into the world of #define true 0 because... (read below) > linux kernel is not for casual readers. P.S. I believe you applied a common sense and in some cases the renames are necessary. -- With Best Regards, Andy Shevchenko