From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55522C4332F for ; Wed, 14 Dec 2022 15:20:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B056A8E0005; Wed, 14 Dec 2022 10:20:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB4C68E0002; Wed, 14 Dec 2022 10:20:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 955CD8E0005; Wed, 14 Dec 2022 10:20:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 85A118E0002 for ; Wed, 14 Dec 2022 10:20:02 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5221080C59 for ; Wed, 14 Dec 2022 15:20:02 +0000 (UTC) X-FDA: 80241272244.25.7193138 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id E2A57C001B for ; Wed, 14 Dec 2022 15:19:58 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a9Jlfc5O; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671031199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XDlWGgFZ4ZJyCtk12LGJK7/45dwv0NSxLqyhRKbdjcM=; b=Oa1C4SKwJeGOYucXKdo+EhNtfU3zrXFDD+ZGqRJwcRlDQY9+oHR+/WLqdZA9f2+8csh8iZ XEKjm/W5Uvhwonab6VGMhksWbjQ3KWbu0xWC5VQvpl/2E+v0OocQlFnt6qMr9BM+jXQEn4 Ztq4nxKW41jh/b2QOPbOZGVGT2SlLug= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a9Jlfc5O; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671031199; a=rsa-sha256; cv=none; b=tqbMSIJrMuvoor7JBRcpd7L7kP5wb+2INRGB4ikOQdNZRKu1mi97Q8uqxBkmNh3SuCOKFZ k8kyZf0iI0A5QwI51ZcR0NeKYf0VMMMCDFOtk6x4a5xHzIljPUqyocMFekxP3nMA3Dm1oe i9FqatsAY8ndjoRrlr3/Ca22fUKjO3Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671031198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XDlWGgFZ4ZJyCtk12LGJK7/45dwv0NSxLqyhRKbdjcM=; b=a9Jlfc5O9/vWjKMAup/0dAT43px9pwoY4m0eFfDY9K5XEho3LgagDzAItXPoqH0fYx+wp9 2H6JieSFQl+fke8VWipKmbW98QB0C3qcEsB4Akx/P+12FaVhBKmcNfuTcMczK+rVtfNPYt Vz23r1GuhrLUecEnkiUL2TaEvnVCcpk= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-468-1FNag4CXOU-3HNcfk5Y00g-1; Wed, 14 Dec 2022 10:19:57 -0500 X-MC-Unique: 1FNag4CXOU-3HNcfk5Y00g-1 Received: by mail-qk1-f197.google.com with SMTP id h8-20020a05620a284800b006b5c98f09fbso3304192qkp.21 for ; Wed, 14 Dec 2022 07:19:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XDlWGgFZ4ZJyCtk12LGJK7/45dwv0NSxLqyhRKbdjcM=; b=dvy+P7fPMFerrLusk2Hz0+MWP4kb6bpay91K5Mz9Nrpea8DX8J73HVCnbbwjwj6Onr ed9UaGHnCQNL1pd63XM/bVHaCAAf8kitpOsAVJr38z+O5PrQaiCV+5k8cDC7/IHeDob0 kpU3gVEKuq+Ur31BmNIOMs9LXmAHvursoYMLEMwm8KtDwEfUvrT2ULCnv1RfymkmS2s/ k3LWHrzrb5iKZlrusr9+T6LSoT23fH2Wao8xm+JVwbI3xHN8yR0+/PPlC94R87g1hj1b yWrYMFslrTSregRtBqoxg1dAyQauCaLUJvPypyruB0Q+827/nZwqqdejTLLVQLp4Wacd WlyA== X-Gm-Message-State: ANoB5pmFb/su186sfh8T5sTCJPs+UTq/UMlrjC5U9oUKtIpUsk2EmP3G soLPYMwOl0rAoyeE88goRU5UXWK1CrgEqIxbm5kuRZyC5UbnOYjG9ca95Kq3mTG9k9JUMBeqVoB DUWjqZ/fLXuU= X-Received: by 2002:ac8:4251:0:b0:3a8:1ef2:7c6b with SMTP id r17-20020ac84251000000b003a81ef27c6bmr11524694qtm.13.1671031195892; Wed, 14 Dec 2022 07:19:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf6KQlmzlt2L7c7Sh/fOd/bml9WovQwKi5o2TgK38jbPxa7vNBiJmb67d6SoLzFqmlTCQhEF5Q== X-Received: by 2002:ac8:4251:0:b0:3a8:1ef2:7c6b with SMTP id r17-20020ac84251000000b003a81ef27c6bmr11524678qtm.13.1671031195634; Wed, 14 Dec 2022 07:19:55 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-45-70-31-26-132.dsl.bell.ca. [70.31.26.132]) by smtp.gmail.com with ESMTPSA id p20-20020ac84614000000b003a611cb2a95sm1838265qtn.9.2022.12.14.07.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 07:19:54 -0800 (PST) Date: Wed, 14 Dec 2022 10:19:53 -0500 From: Peter Xu To: Pengfei Xu Cc: linux-kernel@vger.kernel.org, heng.su@intel.com, linux-mm@kvack.org Subject: Re: [Syzkaller & bisect] There is "copy_page_range WARNING" in v6.1-rc8 and v6.1 Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: E2A57C001B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: yf8ei5xgrdmhcihichqirdnhcx76dyhh X-HE-Tag: 1671031198-116436 X-HE-Meta: U2FsdGVkX19Z/3jjUNvCYDwJCsNgauDq6YpsHaEs6nQmz7D20TDvdXeYZwA/OAZ+aBQidCAHlBNefSTCTrVOablo9hWxZ1MyqRqJv+W4rulGmtsluqR+bVapZL7wdnqrRN4oNaRfyzUdVYWDflUAq3m/FFftvpEesFx9voUSjDPZWLa0Zu+zc01cx8i2CxEMkFOdhv0Pe1RWK903m8BABEcFCzsdbbOnCTbIGpg0hD2IJTF+Jq644A3G6mzbb7L0Os+9yBNegvtXU9re0pv/qY6EUXMqPXO0/DnL/3Ovaw2MkmPAo2BKENo3V4tozfDJy6wmy1WcLTwgk/ggzsM1X7tMNFbPir5wa28u7/RhFt6aCudUEbASZaMkEUynBd4KGLLbge74Zqcz4CP27xfpGr8NAWI/gW6z5VvP4YMKbh21P+aFLe6BUJRFEUsNl6+GQHhLZrWpz+7OcAe6durb+nHXxgfczXL0cxX5l5pzGQXtBPZsCcfK1jjuqez0edjduW5wYUC+VgJZ9e7n/myrDgrYKzXEWHf5p3DY6qR4kDXiVRHyWFhtUwIzrvyGBqOs26wIrD/2c4eTMJXtgAYeq+v30sZ2aF7xyZJivTIgxr6lNoTLxFpkvn7AuAYiQ8WeTfGPGYUWyjMwiUgkCG8MdybnR0FOejjDeW3lfZTIZD+WKyq6NzxFAD7Wb1+s7zcY+WU0OIX7ULnbNv4ItNfyIJax0uTlS0TEQkq9Wo8fjMdsrYqWgowZFaGJcKqX44JLzMARB/mUnlLZcjXB+xGr/k30hsdYFo1qrAmdx/j8PKsF2L4WbUoZdU8kB1crlP2a9zgzJzNWrG6zcaA0sEKImk0mjy0w0fzV+KlJsX3Y1Bf99gwDAedTKABd1/652ag3a+2rYIv8HeMx3nM92jVF0WJlR+T9/FlPqM3vfhAaEJejMtNB+19PDdHZdWaYWDww2DwS1zhxGFzbNloWLgY WpoeABe0 bqXXHw37LgZFKmj5Ucfe3sodEJj2cTz8SGoHDjzj0v5mBn7QD8naz8eedMqM385uQJ7qvMyZzmhvJJKNuUMZYDDOVMDtYXwg80K+3OmI7Vzv7HGINJqSIep//RGqoACACOsohdBn3KBikDoQWerIxUM5vxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 03:36:15PM +0800, Pengfei Xu wrote: > Hi Peter and memory expert, Pengfei, > > It's a soft remind. > There is "copy_page_range WARNING" in v6.1-rc8 and v6.1. > [ 28.138268] ------------[ cut here ]------------ > [ 28.138277] WARNING: CPU: 1 PID: 568 at mm/memory.c:874 copy_page_range+0x1858/0x2960 > [ 28.139002] Modules linked in: > [ 28.139219] CPU: 1 PID: 568 Comm: repro Not tainted 5.19.0-rc1-6ff40f00e5a4+ #1 > [ 28.139706] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 > [ 28.140306] RIP: 0010:copy_page_range+0x1858/0x2960 > [ 28.140584] Code: 5b e2 ff 41 83 fc 1e 0f 85 b1 fe ff ff e8 00 5a e2 ff 31 ff 4c 89 ee e8 26 5b e2 ff 4d 85 ed 0f 85 b6 fe ff ff e8 e8 59 e2 ff <0f> 0b e9 aa 5 > [ 28.141550] RSP: 0018:ffffc90000c9baf0 EFLAGS: 00010246 > [ 28.141838] RAX: 0000000000000000 RBX: f7fffffffffffc00 RCX: ffffffff81415aba > [ 28.142229] RDX: 0000000000000000 RSI: ffff888007e28000 RDI: 0000000000000002 > [ 28.142612] RBP: ffffc90000c9bc98 R08: 0000000000000040 R09: 0000000000000000 > [ 28.142996] R10: 0000000000000001 R11: ffffea00002ab580 R12: 000000000000001e > [ 28.143405] R13: 0000000000000000 R14: 0000000000000004 R15: 0000000000000000 > [ 28.143905] FS: 00007f5b23733740(0000) GS:ffff88807dd00000(0000) knlGS:0000000000000000 > [ 28.144335] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 28.144648] CR2: 00000000200000c0 CR3: 0000000007d5c005 CR4: 0000000000770ee0 > [ 28.145032] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 28.145413] DR3: 0000000000000000 DR6: 00000000ffff07f0 DR7: 0000000000000400 > [ 28.145791] PKRU: 55555554 > [ 28.145946] Call Trace: > [ 28.146097] > [ 28.146242] dup_mm+0x689/0x900 > [ 28.146436] copy_process+0x1ade/0x23e0 > [ 28.146656] ? __sanitizer_cov_trace_pc+0x25/0x50 > [ 28.146928] kernel_clone+0x90/0x670 > [ 28.147152] ? userfaultfd_ioctl+0xd2/0x23c0 > [ 28.147491] __do_sys_clone+0xa2/0xd0 > [ 28.147779] __x64_sys_clone+0x2f/0x40 > [ 28.148023] do_syscall_64+0x3b/0x90 > [ 28.148243] entry_SYSCALL_64_after_hwframe+0x46/0xb0 > [ 28.148538] RIP: 0033:0x7f5b2385859d > [ 28.148749] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 8 > [ 28.149722] RSP: 002b:00007ffc5a2e6b58 EFLAGS: 00000202 ORIG_RAX: 0000000000000038 > [ 28.150133] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f5b2385859d > [ 28.150555] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000001000 > [ 28.150938] RBP: 00007ffc5a2e6ba0 R08: 0000000000000000 R09: 0000000000000000 > [ 28.151340] R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000401060 > [ 28.151846] R13: 00007ffc5a2e6ca0 R14: 0000000000000000 R15: 0000000000000000 > [ 28.152230] > [ 28.152363] ---[ end trace 0000000000000000 ]--- > > This issue could be reproduced in v6.1 kernel in guest also. > > Bisected and found that bad commit was: > " > 81e0f15f2ef6dad7ccb9c03d8e61ef7ded836b38 > mm: enable PTE markers by default > " > > After reverted above commit on top of v6.1-rc8 kernel, this issue was gone. > > All detailed bisect info, reproduced code and kconfig are in link: > https://github.com/xupengfe/syzkaller_logs/tree/main/221208_115556_copy_page_range > > > If the info was helpful and it's fixed, please added the Reported tag from me. I think the warning was improper indeed as when without UFFD_EVENT_FORK registered dst_vma will not inherit VM_UFFD_WP. This also reminded me that this can also trigger after the swapin error replacement using pte markers when there's the swapin error markers and if we fork() we may hit the same thing. I'll post a fix soon. Thanks for the report. -- Peter Xu