From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E82C4332F for ; Wed, 14 Dec 2022 14:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D690E8E0003; Wed, 14 Dec 2022 09:45:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D194B8E0002; Wed, 14 Dec 2022 09:45:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B93608E0003; Wed, 14 Dec 2022 09:45:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AA2DC8E0002 for ; Wed, 14 Dec 2022 09:45:18 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 693F8C05B9 for ; Wed, 14 Dec 2022 14:45:18 +0000 (UTC) X-FDA: 80241184716.26.A942EB9 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2078.outbound.protection.outlook.com [40.107.94.78]) by imf22.hostedemail.com (Postfix) with ESMTP id A156AC0014 for ; Wed, 14 Dec 2022 14:45:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=Kfe1X9lC; spf=pass (imf22.hostedemail.com: domain of Yazen.Ghannam@amd.com designates 40.107.94.78 as permitted sender) smtp.mailfrom=Yazen.Ghannam@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671029115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fmZMBEdTufJ5OyXsaZ287FxWIFGNr4NYotLYf//ObU8=; b=IK8cCELbme0vj0vR10WTzOpBYqstNYTbfng29UbaT0Uw8VLQP68K5yhguxS7bLNeeDKCV1 vrIEA5mJNrHglZnMHeFqa2FfrxRDclqFRi0lGzWhWjCNV9hl1XHbMPUx6aboBfEP6sanmb 6Z6thgTRxMYsnsBR3KW79+GSmmYCYQI= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=Kfe1X9lC; spf=pass (imf22.hostedemail.com: domain of Yazen.Ghannam@amd.com designates 40.107.94.78 as permitted sender) smtp.mailfrom=Yazen.Ghannam@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1671029115; a=rsa-sha256; cv=pass; b=TMTuHbiG9Fhn4cAjOujevPDXdeXWWbC9XSpSFiGs2fvTuC2zo8P5BYWFpFuaffCAv0BX46 nWQEYSW2fMS+M6WJ7K7C5nKWX3+vvnS2daFpUZCjKCnA8kzF7Jt6FIC5yTATLoxVdPWYOu pOgtOIgn7GYNZm+woR6zO9Aw7SLejHc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JD+KjHXl4uLc7MatuuDRGgiLNBu0XqTR+ykXUsCCh6WkpO8W44tBOBOYHi5YJfiblbmLWqW0XAuLVeuGqa2Xr50Mb1KYNz8shak7s1FDaoSxHOrwgZ1MnhIOARdGiBAjDhPBT8G08TloYJGr2e+FjCk68nb24BU/5TIH5ZHiA3VhGp2Yl8gWDRYApRi6WPvszvB2NlPa5GtSgIPlJvAwgNq30SNeABWRCni/B21ySdMStEWw2FSJ863kjklL5wlHHk5Xrn6S9t2dtvvuarnw/0VRlJNnumOfxjxYfjPZVxu4t9fAVKUSujy6+ANIGQCkE9etC32O9e8d9vwIm6tJeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fmZMBEdTufJ5OyXsaZ287FxWIFGNr4NYotLYf//ObU8=; b=Zt1vjhRNKX3GdO8CRN/odmR2TLACGjpjL0WwMsp3iegYRI6f8OurzQ2C2lL9nTgTZEgm0xnIxzghGaaiwPjDB2mAJKu/MLNDhMzN1RWjfu8sX0Ip3B+KHWvO5B2ItSuWCHZG8TCHvH4Gwzj0FboSJ020Q+azudhr8r0mKhg0I4pdjSHcM4J3dOSzQDh+QP6DLZ5rSlkXbN6vnFwnJH6hMZPNh9DG99noYJbBo35QJ3TBG9Js3DJrVdYIa9xpvwb+2M46A9xEd99VY8gvSpnuxooWYgjdinXPEMTeknHp2DxyV3I4kEkN+HEFPYMmM5QwQ/YLcpJ43vUM83RArQHpLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fmZMBEdTufJ5OyXsaZ287FxWIFGNr4NYotLYf//ObU8=; b=Kfe1X9lCP/XHrilYAevHPI/tXMrS8T1OzqMQKTfvWp67NBuywO56q5X0W2ylArXoRMrQ+errJ8UlJpmpYJ5o+Hv100iF1E0y86T+Uy0mhjaWZ8/wuJeQ8hcPcWiAa/l/58PYRCydvxkjWgRwmmBaLkGl+30e5oHoELSsOCKo8hg= Received: from BN8PR12MB3108.namprd12.prod.outlook.com (2603:10b6:408:40::20) by BL1PR12MB5921.namprd12.prod.outlook.com (2603:10b6:208:398::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 14:45:12 +0000 Received: from BN8PR12MB3108.namprd12.prod.outlook.com ([fe80::41:6bae:382:4b1a]) by BN8PR12MB3108.namprd12.prod.outlook.com ([fe80::41:6bae:382:4b1a%7]) with mapi id 15.20.5924.011; Wed, 14 Dec 2022 14:45:12 +0000 Date: Wed, 14 Dec 2022 14:45:03 +0000 From: Yazen Ghannam To: Jiaqi Yan Cc: "Luck, Tony" , HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+jIOebtOS5nyk=?= , "Vilas.Sridharan@amd.com" , David Rientjes , "dave.hansen@linux.intel.com" , "david@redhat.com" , "Aktas, Erdem" , "pgonda@google.com" , "Hsiao, Duen-wen" , "Malvestuto, Mike" , "gthelen@google.com" , "linux-mm@kvack.org" , "jthoughton@google.com" Subject: Re: [RFC] Kernel Support of Memory Error Detection. Message-ID: References: <20221103155029.2451105-1-jiaqiyan@google.com> <6bb93638-5702-076c-b72a-f33b39f35842@google.com> <20221213092743.GA1977915@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MN2PR20CA0056.namprd20.prod.outlook.com (2603:10b6:208:235::25) To BN8PR12MB3108.namprd12.prod.outlook.com (2603:10b6:408:40::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8PR12MB3108:EE_|BL1PR12MB5921:EE_ X-MS-Office365-Filtering-Correlation-Id: b35d8b5c-974a-41d3-001d-08dadde1cde0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D/kApi++A/34T6+s0ZNO22q9kD7t3fEuCvwgRqES9/g/cuOp6wONJiCrYfzbgKrmK+fU8HQ9sp3ThDdQgwCxHLxEmjI91qoSy/oeIkOfILp0ucPrig0oZKvTZckUB/AMpDuDLlaEpAE2tU2RDsiFQF6zMcefPDS+pKmlO2Do0OYSlKmcvYlMXaIjbBTJeoA2ZYOuCLJGB57ADHkxe8St2DKN9MIJKEELnlXeilDCUt0BErlf0ufQF9PMOICKqV+FnTtXp9y7moa+xkVMrQgqFDJj9+XhlmmpwmjKbEWGUKXm3AG4P9m6irGIHsRN9fB6bAGsN4Fpa+S95qvn+9N1TYMRCKd7tapLqXoSkXyu3eAnAZi00Y5vTv8W+6fQLzbgUQH3p0TueRAUTTkoG5q+u9gEAoXToyTDh5QVfLIwhlMmsV7SmWY9WC5FOl8kcJ8lq/75dW6S+AJGe5AIZvYBv06hOxmfJKmNFHNZtViZiB0WUzIZ9jvAcDMGuAaYlwpdKEBuelJlsH89+kg2cQKJgr91vbH5lXQJuXTqdKGftxsodPXedqLaeB4tBfOC8D4hA9p1OrNZ0QdRaurSn0moBhREYWxIQWYt+IhIrXb1KBW/+VWJH5FzdjPrQl+urNnEIo6Lx25yvhNfvU3uYDsfRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3108.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199015)(478600001)(41300700001)(5660300002)(8676002)(4326008)(6666004)(6486002)(6916009)(316002)(54906003)(2906002)(66476007)(7416002)(8936002)(66556008)(66946007)(44832011)(86362001)(6512007)(38100700002)(6506007)(53546011)(9686003)(26005)(33716001)(83380400001)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUpDT3lTZUN3K2FjMWJkVjE4dG1QWG13dStiSG1zVFh4b01NMnc1MXVzSTlO?= =?utf-8?B?Rm5DRGs3RmZiTmw2d0tkOWdTbDVNTHkxenBaTnM3amhqeExkL3Zac050bDdV?= =?utf-8?B?MllyeXVlcXJlZWhESlpadkVIUzZhTXptcDZBRHhWWXJGbnd2djhDY2ExZW00?= =?utf-8?B?UWd1ZzRpNWV6Q1FUU3dhKy9maG0zM0xHczQvdUNxc2EwT2pZVWp0TVNhamw2?= =?utf-8?B?QTFabDArQ3Y3eU1qNWYxWnF1Qm5xb0hLaHpKSGR4bnpsNkZDdkFML09PQnFW?= =?utf-8?B?MkZGT2hMK1dzcEZkQ09ZVHdDYXFiZXpGYmRmSFV4TDhzK3h4T0ppOUxtM24r?= =?utf-8?B?UGpPSFIxd1ZEOHE4TWYxd1g0bTlGZnMwUHhMV29QWTdjM3lCNkV3YmNTaUFB?= =?utf-8?B?YmdUaVc3bmkvN3ZHNjJVRU0wc0oyMFpudmc4NVNUaFRvblVHUXFSSzNYclB3?= =?utf-8?B?SUpwa3hRMlVKYmRtRm9rbDBVeXZSaE94cytQY29RQjh6aGNwSVNDckdzaG5T?= =?utf-8?B?WkRPUFZBYktnNE4rK09mSUFjMnc1VTVvdGpaTkFVR0YxbHR5MUE2bFFFMU5R?= =?utf-8?B?RUF5cDBoNDdjcUo3N014Z2oyZWtSTXcyYm16WTZOaEUxV3MveHlod1ArWW9M?= =?utf-8?B?SmJDNzdNMy94eXZQMHJYV05MNm5JSDUydGdEKzZqVEdydTBJWkJBdHRVMXJj?= =?utf-8?B?WTVpRW5jU2NaTDhhRE1tWHZSUndiZ1RVTmxxUmR6alNEYVJzSHNwUTlWaytw?= =?utf-8?B?ZnhmaWVsdDVxWkEzeVovMUpiWlNISENEQkxxTHR3MVpJNlFHcVNVai94dEpp?= =?utf-8?B?bUcySlQ3R3ZQSjliTGt4V0FGMXhDTjdoRGthZFFlWDBGV2pwOTVsRlBXcDJI?= =?utf-8?B?elpoU0poZGxmVUF0RWtBeHVFNzFNT0I2M3M2cUltU3FoRXMzdnE3bG5JRmVL?= =?utf-8?B?Q3UxdytBM3VadTlaQSs4cHFwdXdOZTBOVkU3SlNWNDQwbFNYcHUvSEJBRzcy?= =?utf-8?B?S1Vaak5jaFA1OUVBUWh5R0JpaUVNYzIyTXZHcDV5NnlRVmNNbzhvSFpzd2lQ?= =?utf-8?B?V3daeGNFN2RRdGcxY1FUdEFHRTdETXNpZERoczlMN09KQWRabDhpR0RVeDNo?= =?utf-8?B?b05mY0xRY3puekVqMGszaXlBZXhnT05KdFFDNVcyVlE5VHBIY0x4L2pZVmNa?= =?utf-8?B?T2g4WGEzdTZrQTJsVy9wVjBjYmFxVmdWUHdpeU92d2hnaGVCVnFKdWx4VlV4?= =?utf-8?B?U2R0WDZTS2NCVklpa0tvTUtaU3JzZmVTcDZoYXl3YUtBdEovZVRCaW04YkFN?= =?utf-8?B?aXZlYlRhdStWd0o4Zkk4eFdNL3JNa0xvUFhPc0NZeUpDUUV3NEp6ZGNVZ0VR?= =?utf-8?B?TEtzcGprcTlVVWtDQ3M3S2NnWmN1aHN1OHhLZWVuWWhJWTkzSFBvZ0d3RVpV?= =?utf-8?B?NVM3Z3AzR1lGZkloNTZqWGh6OUplUFg1clpXdWVZUmlsa25Dc295Mkgzd0RQ?= =?utf-8?B?SWd4WDNMR0t4TEV3SllySU83MVZiZERCTXg4N0NQczBiMFFOSHhTZDZVd1Qy?= =?utf-8?B?QTVNc1FsRTJYQW5xanIxZzZFMFFPaEFnc0RibWg4Si9ISlpDRnd0SXNnR2Ji?= =?utf-8?B?MmhWVTdyVXQzdXRKTGFFU1U2Ynd5bmZrL3UybnVmYUphMEZGclJqRklPOThP?= =?utf-8?B?KzVaMk9LNys2ajc4Z3kvb3NiWm40ZzhmU2dVdytwb09DZEJEMzNObTNad3ho?= =?utf-8?B?Sm1EdlBsbUhkTitwY2k5SHU2eDNuaG1kNXoyTjM0TXUwczVJVzgwVkpCd0RF?= =?utf-8?B?VTFwRmFvWkpHaTVTZm1rdlRsUkhZaE5vMVBhcDdqTmxjdEx0WWlrcmtOdVZW?= =?utf-8?B?VW5EejAzYnVidksrN3ZWeWd5aWpDQ1RtdHI2WnBtNUxqdHNOZWpzZXBnWVVu?= =?utf-8?B?UFVGb3VCWEs4VkFVcWhsdVJBaDhHeWsyWWVmalNBWkJyMFdNbXl0U3ROak1z?= =?utf-8?B?bTZ6NythbDU4TU9ES0ZlN2Zod1hOZ3lHMVpxYm0rTGQ3OUZIK0gvUGRZUndl?= =?utf-8?B?U1ZEdzZOOEs4YW83bHNXZHNnc2lITzBSc3NkSVl4Wm54bXNuOU52Ly9UUkFo?= =?utf-8?Q?FqLnc0hfzH3qUDyJydjQrTkVb?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b35d8b5c-974a-41d3-001d-08dadde1cde0 X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 14:45:12.0858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5j+ITgEmnr9ofdjQ8hkPN7qK/vSJvwTpX1ejX0gXQ3/9tQZbcsE9DSym4YpCjYll2wlYrtLSOEg7viHusJ3AZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5921 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A156AC0014 X-Stat-Signature: mcdni7yrs8f5duz33hhkuqdpxnnc8zdy X-HE-Tag: 1671029115-637658 X-HE-Meta: U2FsdGVkX1/nVKzwE9omt9TmmoqYZAHbSc4PnEvRi0axbjP+8z6ZPvM9ERb51/fZX3+5KGPQ/EG9kupMbeoa1JdpUOA9BBBC0RrSNDbnq2i0Lg3XCVIHLrJVqMfAEEHlcFAmHpldTLN/Ve+1hq37QYk0/cgdM5Jnd448+j9dQ8y6gCMRweUFeKYIMN+JeonPt0EjBwoLFzc0XXntKzCb0e8tI9Xf1DrzG9v3Plab36xbhrW7dRkPzTj7FZPAymG7C6SmoVTc13zr2a1BStGdfQy0l3vjh4Ydximlu3G1Ab1YWPjHPkqhDPRRc3FeqlXPy7DQxQT0eVR9HKisfhaXincHG9409XomeBmkjm4Z+ALM/bk4dcduDlIoh9NctO3w2ESJJVU8RB/vGQFEzYMAFeOYxwVVd8bCV58q2CaCYUq1MZhmkG0TNWS8/EorO2QNezb70W5jzVJ/gjcfh9XclfaEo/c05jmPnKzy6l6GTu4ZMK5dNwhEyTZi13mwc7bn1xyIdc80XC2ceLC8WgsA9q8RxvccJHdgfeAx6sn+A9cIzKmonpZrt1qZ6hsC/Wq5wLaN1X3Owk9hZE4JnWrxnddac7lXv/ADmIqzWwWUvVMTeMV4nxO8PLbc/qrEwpdAQg4XSR/c09JZ4wDEfsjTX5q5M+KOaLRuzUVS5vSLCYW2Y3kk+cSW3teUzJcHJRgJCE08z3EFHVcS6o3nMPLkD6WONjUsfgnHsJNMt9J6X8SKVcczX5vAI9sn9PqesJyKliwEf0VcYzS7Os+38ela5BkssKGfidD1XlHkRLvHNuL+8vFgpwONuMeIc85ZDit+3LuMsfudublA+wn4ZpC0CoG5odzpO5764GNm6ZY/Xv9omE01ikS1MQP7TiIKWy7wMSwxwc4WB4ie15LJ7/aIK5COQehO6gL+E/7WSffUdhZPPCvwt/P97aE2/Fi/OkDMelEY4qIQGZU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 13, 2022 at 11:03:52AM -0800, Jiaqi Yan wrote: > On Tue, Dec 13, 2022 at 10:10 AM Luck, Tony wrote: > > > > > I think that one point not mentioned yet is how the in-kernel scanner finds > > > a broken page before the page is marked by PG_hwpoison. Some mechanism > > > similar to mcsafe-memcpy could be used, but maybe memcpy is not necessary > > > because we just want to check the healthiness of pages. So a core routine > > > like mcsafe-read would be introduced in the first patchset (or we already > > > have it)? > > > > I don’t think that there is an existing routine to do the mcsafe-read. But it should > > be easy enough to write one. If an architecture supports a way to do this without > > evicting other data from caches, that would be a bonus. X86 has a non-temporal > > read that could be interesting ... but I'm not sure that it would detect poison > > synchronously. I could be wrong, but I expect that you won’t see a machine check, > > but you should see the memory controller log a UCNA error reported by a CMCI. > > > > -Tony > > To Naoya: yes, we will introduce a new scanning routine. It "touches" > cacheline by cacheline of a page to detect memory error. This "touch" > is essentially an ANDQ operation of loaded cacheline with 0, to avoid > leaking user data in the register. > > To Tony: thanks. I think you are referring to PREFETCHNTA before ANDQ? > (which we are using in our scanning routine to minimize cache > pollution.) We tested the attached scanning draft on Intel Skylake + > Cascadelake + Icelake CPUs, and the ANDQ instruction does raise a MC > synchronously when an injected memory error is encountered. > > To Yazen and Vilas: We haven't tested on any AMD hardware. Do you have > any thoughts on PREFETCHNTA + MC? > Hi Jiaqi, I'm not sure of the behavior. I think it'll require some experimentation. The AMD APM has the following statement in the "PREFETCHlevel" description: "The operation of this instruction is implementation-dependent." So it may be the case that the behavior changes between products. Maybe this procedure should be opt-in and only apply to products that are verified to work? Thanks, Yazen