From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A3EDC4167B for ; Wed, 14 Dec 2022 10:43:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F2908E0006; Wed, 14 Dec 2022 05:43:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67BF58E0002; Wed, 14 Dec 2022 05:43:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56A3E8E0006; Wed, 14 Dec 2022 05:43:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 48D038E0002 for ; Wed, 14 Dec 2022 05:43:25 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 16817A0E97 for ; Wed, 14 Dec 2022 10:43:25 +0000 (UTC) X-FDA: 80240575170.29.C3BFEF3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id AD3841C0018 for ; Wed, 14 Dec 2022 10:43:22 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671014602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e7S7ABXT2GAX4exGSAi3WiuJVAzsygq7OnW8mGY3TRM=; b=4FkRhzDp5v//sif3vL5dJLcPQy7smxQc8jqvcB8mJW2HMU9pbKGdmIkdZtaj7kSW0bwHM7 0T0xUdCFN9yJlu/Kio6KJCfetKrRqILpNq3jqgQyXNuRs997H1GQ2EUYvhM8aB3zgdey/P 7rWNk0eTfgjVV/dCwioUl7BhXO7NDFI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671014602; a=rsa-sha256; cv=none; b=kq5rlukhgR1EHbEQivWLsquA4mOyXH+HGfnh6Aje3y6SJjjP9m0+VvF+BRTY9IvuyYn9/y OXTdaKRODzB/24VV05dv6W6ycpL+wB+YP+znWSc9mbtxl6LacYDG3H4Tb0OIfiH9tzsSv6 HbCIjGr82hN3hTbjPaiiZQ0LPXtA/Iw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95EA5619AC; Wed, 14 Dec 2022 10:43:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74081C433D2; Wed, 14 Dec 2022 10:43:19 +0000 (UTC) Date: Wed, 14 Dec 2022 10:43:16 +0000 From: Catalin Marinas To: Waiman Long Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH 1/2] mm/kmemleak: Simplify kmemleak_cond_resched() usage Message-ID: References: <20221210230048.2841047-1-longman@redhat.com> <20221210230048.2841047-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221210230048.2841047-2-longman@redhat.com> X-Stat-Signature: zhgd8mjfjuc76iau8d5ryrn74uiozmpi X-Rspam-User: X-Rspamd-Queue-Id: AD3841C0018 X-Rspamd-Server: rspam06 X-HE-Tag: 1671014602-875154 X-HE-Meta: U2FsdGVkX18HC0fTztV8Gr/+f2f9Fxq2fYAE9TAIYHQeyRI5vnDMTBOLdqrc5ANIwqQljeY39wvXHI3cRfv60J60hDOZNpHuk+5evtFwRMWtRIc2gTBFlIN83xWaQFYUUyKKeHZTFJX4gRa93PlzbpgbTv3jQWLxAtHMrzlsTQpxQ/IbF/jaIsxAkALSAsyFUt4FHe7743xyK2BvtZOPcLJzYZ36WF5oWHUG1Q7pHDR3/V+7rVLmWmTD8hKZCX2z3qnCcHo+UZO/aHGefU/mNPnGEz/C16rpY361035USm9C1uwhCAVjCzcdZeDU/AB+upYfC5DnbezgIoK62qj8fU27D4BD5Ny8AgLot1PXoc6tO3bSW/2SDGmO87PtC2Eii4cOw6DAF22NscewmYlrc6kZ8ikw9oSyn17gIlJqIB/AzvhBJGQwF+o4b5wL2djFK2/Jf+orSShK3GdnJz+CKUvr2w5ulJ6poKDpecWJ6Qb7bDzzdpPP/ByN2Zp+l45txqq0y8REx3glwIoAqDtgueTR1e7TsffMQjfA2JYlf9T+7LdbYogLRzltPIEjFzpBPxX5EODUUE+AEiGRZOP2sKlhsI0wy2z3y2eVrKcqoZZbXLjijBu1KgyVzP9qBZtiAcaFYELSc9lAIdX6ZJH//T2Aa7IL3O2owd3hPjitbw14nlBKvRwIErzjK4Uf9XC2gexiTYVgmQH7BXYhI/1x0srgKd8SwW1DpdYIFSv6UevVE3jhO/e3XQDk3jnHzu7IcfnAZBF/+5Lcu7TTJA2qsvfRwYEWl5gn8RhDNMHRD4mfWELasNAi/1ayIrg5/PEioUK38lP2zd+FbQyG31Ds9pOGfjLrkpqgt8xaTPBcNQidktn7ZAZ7bzNHap+I8BqEimQ9bombVCrN/IyW6zooAohuqlWZWaj2MONFrNfZnLosO2L15JAQkPPRdICv/KI3HwRq57ouf8uQYJNt1z1 StqAVrcz bgHP2+Iqu83BNBfKoNRN5+aAxk/bIuSjLWk2ms4uOrv/YWGBNG9BiZEdngxvSre3nZpcsiRvuhI3gTqdSMN+rM3StOFm03QHquNyzYNdWvyfsDy+pVH7jdSXoDxhQ7OnP3ICJ4vMggkVkdeArQsEXQWJSfwastVqCzXKftjXNi76prgLW8li6/lB1cMAbRBzzzIt6Ww65IRnJFro= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 10, 2022 at 06:00:47PM -0500, Waiman Long wrote: > The presence of a pinned argument and the 64k loop count make > kmemleak_cond_resched() a bit more complex to read. The pinned argument > is used only by first kmemleak_scan() loop. > > Simplify the usage of kmemleak_cond_resched() by removing the pinned > argument and always do a get_object()/put_object() sequence. In > addition, the 64k loop is removed by using need_resched() to decide if > kmemleak_cond_resched() should be called. Not sure why we ended up with the 'pinned' argument, get/put_object() can be nested. Reviewed-by: Catalin Marinas