From: Michal Hocko <mhocko@suse.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Yang Shi <shy828301@gmail.com>, Wei Xu <weixugc@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: memcg reclaim demotion wrt. isolation
Date: Wed, 14 Dec 2022 10:45:01 +0100 [thread overview]
Message-ID: <Y5mbHQSKuXY1Qojk@dhcp22.suse.cz> (raw)
In-Reply-To: <d2b75d22-0e13-95d3-4fb9-827f8cc15c89@intel.com>
On Tue 13-12-22 14:26:42, Dave Hansen wrote:
> On 12/13/22 07:41, Michal Hocko wrote:
> > This makes sense but I suspect that this wasn't intended also for
> > memcg triggered reclaim. This would mean that a memory pressure in one
> > hierarchy could trigger paging out pages of a different hierarchy if the
> > demotion target is close to full.
> >
> > I haven't really checked at the current kswapd wake up checks but I
> > suspect that kswapd would back off in most cases so this shouldn't
> > really cause any big problems. But I guess it would be better to simply
> > not wake kswapd up for the memcg reclaim. What do you think?
>
> You're right that this wasn't really considering memcg-based reclaim.
> The entire original idea was that demotion allocations should fail fast,
> but it would be nice if they could kick kswapd so they would
> *eventually* succeed and just just fail fast forever.
>
> Before we go trying to patch anything, I'd be really interested what it
> does in practice. How much does it actually wake up kswapd? Does
> kswapd cause any collateral damage?
I haven't seen any real problem so far. I was just trying to wrap my
head around consenquences of discussed memory.demote memcg interface
[1]. See my reply to Johannes about specific concerns.
[1] http://lkml.kernel.org/r/87k02volwe.fsf@yhuang6-desk2.ccr.corp.intel.com
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-12-14 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 15:41 Michal Hocko
2022-12-13 16:14 ` Johannes Weiner
2022-12-14 9:42 ` Michal Hocko
2022-12-14 12:40 ` Johannes Weiner
2022-12-14 15:29 ` Michal Hocko
2022-12-14 17:40 ` Johannes Weiner
2022-12-15 6:17 ` Huang, Ying
2022-12-15 8:22 ` Johannes Weiner
2022-12-16 3:16 ` Huang, Ying
2022-12-13 22:26 ` Dave Hansen
2022-12-14 9:45 ` Michal Hocko [this message]
2022-12-14 2:57 ` Huang, Ying
2022-12-14 9:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5mbHQSKuXY1Qojk@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=weixugc@google.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox