From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4869BC4332F for ; Wed, 14 Dec 2022 11:39:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 987388E0003; Wed, 14 Dec 2022 06:39:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9380F8E0002; Wed, 14 Dec 2022 06:39:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 826F98E0003; Wed, 14 Dec 2022 06:39:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6F14F8E0002 for ; Wed, 14 Dec 2022 06:39:18 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 39C8A1C5F1B for ; Wed, 14 Dec 2022 11:39:18 +0000 (UTC) X-FDA: 80240715996.28.7F27A2B Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf26.hostedemail.com (Postfix) with ESMTP id D2EB014000F for ; Wed, 14 Dec 2022 11:39:14 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NcRCvCiH; spf=none (imf26.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671017955; a=rsa-sha256; cv=none; b=M4o+j5v/L/Q4jRp78UQT2RH4mcCDVdMmFwcZ480jhbQQue00VgYM/TXyH6C079Gx4K5BJ5 JKZhjDPaBWnQ5uB5hsGZdsfNI9H0CdrmzqE9qQryBDxPQtfE1D108Da8+Q0Jt25wCDiPPB IqnSk5hoZaNqgC1mxcjvao3KPJ3T01k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NcRCvCiH; spf=none (imf26.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671017955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x192pd4pmrTTRUxSN+Y5+AYI5a6zqCsI5SaP6GE0Sa4=; b=NqVHJmPKLiVgqJFcaR5077gYTiVDIhLGkghVEM0MUK82tYuuhQKFfruxSx/SASotXXRThj paeOtwXMgg57p2SYyKFH1GkijB1rZ1QGZiICqLMNAVTc9VDzg2AB1KLopN0fWuRANqexwh cjYKlxFKranEllSRH4SijIwqrHEPHe4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671017954; x=1702553954; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HIQ2CVubamspPVoCrqEnnVpkpn4eO9oQvSkp8p5F0Hs=; b=NcRCvCiH9d09OJcc1wTAMXMH0JIhNKRsJ5mGF3uNNowzg6SZ9OGBJocC 2Jn6wBLI9FVMpDx6jsyJY8y030Zoo1gRaysJNfB8uEiOxT/OJkw7Qwhti oqPuLi1Z1uJb/eHSgi9DWzvvzW/uBONooqKwmrLlyg593zn6Rg3Z7nmHd WPkncxDKnwG9lZyD8srzrrUVnyHczAuhKxG7aUbAvVuXurKbfnIr5vIMO pL6KCOBABGL5cBR1XmyP5TzfXgLy3zZTI+YXixdscp+ct7iYa0ErVcAMT LWq1LJygJgMdk1b6eOo/N7g+KdpL+Mz3/Hg57HjTdhz3ETCzkaHkzSoag w==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="380584192" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="380584192" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 03:39:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="791276457" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="791276457" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 14 Dec 2022 03:39:05 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p5Q6K-009mSh-01; Wed, 14 Dec 2022 13:39:04 +0200 Date: Wed, 14 Dec 2022 13:39:03 +0200 From: Andy Shevchenko To: David Hildenbrand Cc: Hans de Goede , "linux-mm@kvack.org" , Mauro Carvalho Chehab , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sakari Ailus Subject: Re: Dubious usage of VM_SHARED in atomisp_fops.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D2EB014000F X-Stat-Signature: xydne8s6mwrss8qtfdkfzdwgq9zg685z X-HE-Tag: 1671017954-797995 X-HE-Meta: U2FsdGVkX192XTO4IryyY9STDvOwyu3Q96HIjHKFG34lRB4VtBuOImPqqHVO4P6lSXk8YiE5ZijjGvhVu5Q0gFQ4p3fX8SIWpgKnVqjHPwVAXPL7AhB550MbjvQ8KfpX1DkrPmmKs7Img3LSuLq3ZvQyM1isp7AFVAN9E/1Hn8XvkCF7zmg53JlsTjCqU9TPpQ9BxJcEWtfZgc4N4vbwWF3F3kY66r2rtTkeztXTymUoyHsNGmosDNc4mVttmssQEHX3WmEN/t5n+K4uI/jDV1H4ljWREkeCwUMR1MkSizjfFvVdj1gRHNBl52C1cxmxNoL8XSBbryNao693Kgp85ImcD1UzMkRBEZ6NgmQufsEYDA73Fdlv5st+xCwJChZLnf41BQOH3blgSdpsHJZ1rvGApyzNxl0U8rr9ckjNZg6uGQOGoQTOSaGm7eSwgGU2KKDHJm+Xf/DqtpltXGy6/8EINcH51BvMu6uZIjtnXkX5LUlEujYCjx7976uCxDbBugt3UVH4BVRkL9GfNS7o8hrUzaI7pIvWbLN6thAg2Lc6VxkWuqZ7VjMsjx/Kc187f3yy/yet1UT48T/5k9nL2pH5rZrWh94X+nqmostjllxeqKHwbmfdokktUNOxvvKlJzrF0G90VvJkv70wR61/fj0Bn9Lyh1wMfc2+dwMCpTIRzlT0QVSMTpz1JIjv/JtCo1KTEJOaFPMik7cXWYSClLECUN0OmUWHEtL+qtQpIzhv1j0Zxq3pokkio97yXybGevHDUvpPYwmkOZEnQ/sLlKEF8AbpbGScN98YnxAYlYx2h5I2OZHPKKoD5ft8l35rbOeMN/d5Ak1udpYAv6D9W7QZ6KRos8OQ25tsN/KulLhKkO5I1zOrM8vk34ws9nFl0Ra7ovbihcNQhOp3mHnenSf1VnFUepOFtD1UvRZyS2I3afRJFW5Gi2uy999hqtIHVjirUvv2x/4w7UMqNBg 6vUnygNL 8Wwxj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 11:22:39AM +0100, David Hildenbrand wrote: ... > the other one would be to remove this driver. Judging > that the driver already was marked broken in 2020 (ad85094b293e ("Revert > "media: staging: atomisp: Remove driver"")), maybe it's time for the driver > to go. Not an option at all. As Hans explained. -- With Best Regards, Andy Shevchenko