From: Mike Kravetz <mike.kravetz@oracle.com>
To: Nico Pache <npache@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
muchun.song@linux.dev, akpm@linux-foundation.org,
willy@infradead.org, gerald.schaefer@linux.ibm.com,
sidhartha.kumar@oracle.com
Subject: Re: [RFC V2] mm: add the zero case to page[1].compound_nr in set_compound_order
Date: Tue, 13 Dec 2022 17:02:25 -0800 [thread overview]
Message-ID: <Y5kgoTVteXm0QFgT@monkey> (raw)
In-Reply-To: <CAA1CXcDK=bpAbmkwyssja9d7eA3iEtNQ2aNaQo4DkdjV3YvOVA@mail.gmail.com>
On 12/13/22 17:27, Nico Pache wrote:
> According to the document linked the following approach is even faster
> than the one I used due to CPU parallelization:
I do not think we are very concerned with speed here. This routine is being
called in the creation of compound pages, and in the case of hugetlb the
tear down of gigantic pages. In general, creation and tear down of gigantic
pages happens infrequently. Usually only at system/application startup and
system/application shutdown.
I think the only case where we 'might' be concerned with speed is in the
creation of compound pages for THP. Do note that this code path is
still using set_compound_order as it has not been converted to folios.
--
Mike Kravetz
next prev parent reply other threads:[~2022-12-14 1:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 23:45 Nico Pache
2022-12-13 23:47 ` Mike Kravetz
2022-12-13 23:53 ` Nico Pache
2022-12-14 0:27 ` Nico Pache
2022-12-14 1:02 ` Mike Kravetz [this message]
2022-12-14 6:38 ` Sidhartha Kumar
2022-12-15 1:05 ` Nico Pache
2022-12-14 17:04 ` Matthew Wilcox
2022-12-15 2:48 ` Nico Pache
2022-12-15 21:38 ` Nico Pache
2022-12-15 21:47 ` Matthew Wilcox
2022-12-15 22:02 ` Nico Pache
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5kgoTVteXm0QFgT@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=npache@redhat.com \
--cc=sidhartha.kumar@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox