From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Josef Bacik" <josef@toxicpanda.com>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Michal Koutný" <mkoutny@suse.com>,
"Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
Subject: Re: [PATCH-block v3 2/2] blk-cgroup: Flush stats at blkgs destruction path
Date: Tue, 13 Dec 2022 09:30:59 -1000 [thread overview]
Message-ID: <Y5jS825K7ej0jEV+@slm.duckdns.org> (raw)
In-Reply-To: <20221213184446.50181-3-longman@redhat.com>
On Tue, Dec 13, 2022 at 01:44:46PM -0500, Waiman Long wrote:
> + /*
> + * Flush all the non-empty percpu lockless lists so as to release
> + * the blkg references held by those lists which, in turn, may
> + * allow the blkgs to be freed and release their references to
> + * blkcg speeding up its freeing.
> + */
Can you mention the possible deadlock explicitly? This sounds more like an
optimization.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-12-13 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 18:44 [PATCH-block v3 0/2] blk-cgroup: Fix potential UAF & flush rstat " Waiman Long
2022-12-13 18:44 ` [PATCH-block v3 1/2] bdi, blk-cgroup: Fix potential UAF of blkcg Waiman Long
2022-12-13 19:29 ` Tejun Heo
2022-12-13 19:53 ` Waiman Long
2022-12-14 16:54 ` Jens Axboe
2022-12-14 16:55 ` Waiman Long
2022-12-13 18:44 ` [PATCH-block v3 2/2] blk-cgroup: Flush stats at blkgs destruction path Waiman Long
2022-12-13 19:30 ` Tejun Heo [this message]
2022-12-14 1:58 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5jS825K7ej0jEV+@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dennisszhou@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox