From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41FFDC4332F for ; Tue, 13 Dec 2022 15:03:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81F868E0003; Tue, 13 Dec 2022 10:03:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CDC38E0002; Tue, 13 Dec 2022 10:03:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BC968E0003; Tue, 13 Dec 2022 10:03:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5B91B8E0002 for ; Tue, 13 Dec 2022 10:03:07 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 25E6C120D31 for ; Tue, 13 Dec 2022 15:03:07 +0000 (UTC) X-FDA: 80237600814.04.48C0C3A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id E42044007D for ; Tue, 13 Dec 2022 15:03:02 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=C3GI8dbc; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670943783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZBUCX1fq7rVjzw9IZv3GvuEkxpJ3r5A2psEG7gmR1jM=; b=fVQ9PTrwW5BWdsugBnJqAt2zWRHsyd2J3khV98bIKCkXQzZW6DZb3zWBSUXEwRn8P7IjSV BZiF9ymK310k7G2Ixr1gDxZF7bhHhd834fkbotaZRVVXeXj53kgk6r3NyZv5aqxmnXvsTv //jiRMlNMLmKISAkQVd22QbGVnx0sX0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=C3GI8dbc; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670943783; a=rsa-sha256; cv=none; b=kSWivSWsO+cGLS2/brqHQZhMojLdL4awMPdJq2SrNFlLh8L/U2pso8eDISHydl7RSbpefE SsUwyQ+pkXHVb+dYCItA2RqUPPMQyor3XQNj6VvNRjdpL2hvnlO3qCVSD0EnlWTFY94XVV s52gz2wyZWjsRHcIetjIKN77NhHZsRs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZBUCX1fq7rVjzw9IZv3GvuEkxpJ3r5A2psEG7gmR1jM=; b=C3GI8dbcs5PgQhUrJSWQ3P8D9r xjJqW2cdFvQxkqcbNgFjO7XoEXv8hc3HA6GBKHTyj1MbbsSGZQex8iIKZuRszrgDelPE4/MXx9A/D fYF9IvDamMrhqr8tzut2aohnojop3yJ57OSce4dEhI0kk7GbGIHVLc6sdQ4FHbDBwtMEIFcX1AMaw UsS9uE5CTYn9C/6cjPIzTnli6DlvkktENgk2XEYwjm8TNijRgb5yWOroUTe0M08un5lHmSc1drTei JpvelxBSs+Dei4OoL+8jE7Qoewfr78TfQgV9KwpxG/UW6np+pMS8Uxcinbj11r8ByQzaz101XIdf+ JT8eCoKQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p56o0-00CKAA-5L; Tue, 13 Dec 2022 15:02:52 +0000 Date: Tue, 13 Dec 2022 15:02:52 +0000 From: Matthew Wilcox To: david.keisarschm@mail.huji.ac.il Cc: linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, aksecurity@gmail.com, ilay.bahat1@gmail.com, linux-mm@kvack.org Subject: Re: [PATCH v2 1/3] Replace invocation of weak PRNG in mm/slab.c Message-ID: References: <4925f0fe15e9cda5f9d90d75c6e15acdc413ef9e.1670890407.git.david.keisarschm@mail.huji.ac.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4925f0fe15e9cda5f9d90d75c6e15acdc413ef9e.1670890407.git.david.keisarschm@mail.huji.ac.il> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E42044007D X-Rspam-User: X-Stat-Signature: f5w7uy4kgay9bax9i5ou4jeqyxebai55 X-HE-Tag: 1670943782-332964 X-HE-Meta: U2FsdGVkX18D2HWW4tz5ud9DNjq7fStpTGDHeJ8/OV64jgTTdNOturhIzgCKAAnhifkhw7LHfN8eB0Xab8X4I27NcrwhEqvRJ/l53mws0kt8wf7Qk92Z46X9XZF7r3EdexD7wn7xykk9ioCmOfHL6Wek9eP0a3AQLq/8INgkDWRBrBcRgCwiykQB6RKAaRVFUmc1/vjtJ5zY463vXoMT0228/h3vACipG7WIEtkeVFYpNHENXsJVPHj7KRNagyUr/904AWizAl0NGYPTFWj08ZAR8nHj+hhhDUI/JJgAzK8p5iqhd6qxzjoPfdsygXRRtIK89oVFQS+He6RKp8ubS0jJO19lE7be1Sl11kSWLTjhMUrFkrBPywNuwhSY3shMGYZoxsbu+qjIhwG5UDj0l+nhTrJOEn6oCWvmibJSxpKYC2Wwsx5Rzwp4t8+d6HcHLbbb6JmErtjAMv0FuqyWsUe1Gg5nGJAoaGd1XnaKJ+8dhq2r/E65OGmgPy6Kr5z41l/DCweE3U/rvnInJpZHVjRfuHgrRjDfosp7NA0MCmv27F9bawcIKg1bY4G6DkjJJVItLxQozAt2ldi3tuI2BSuX81fP6Pb2/fIbF2BxVwLvK7juR1nf+9Frkbh7bniyU151DXj0O1CUwBLT2ZgeoAWqJbkpgudt9GjekcngCN3T10tnb02768K3GGnbfLCCQ0iCl/SCDJTT9C0QCH5jPgv0SsOLpJHZ92M5mJo1Eto4qHAr/qNeONSgwDrtHA02ewkjPOsMHnbOvjQD+yvyrBVI3CNxSx5g+8Y3FWomjrXkXmDlC3WPazMmdWYK5vDF3H0k7vxPOTaFZHr545YUyiR5Fj/bZkUaDCIxbh0eyxlJK8tC4z5tkBC/ksVs+GG9HEhQCZ6m91LbxiY1CKb+NPmcZDTpJO7mAv07tRN5p4k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 13, 2022 at 12:34:57PM +0200, david.keisarschm@mail.huji.ac.il wrote: > From: David It's normal to include the surname in your sign-off, fwiw. > @@ -2447,7 +2443,7 @@ static bool shuffle_freelist(struct kmem_cache *cachep, struct slab *slab) > > /* Fisher-Yates shuffle */ > for (i = count - 1; i > 0; i--) { > - rand = prandom_u32_state(&state.rnd_state); > + rand = get_random_u32(); > rand %= (i + 1); Shouldn't this be "rand = get_random_u32_below(i + 1)"? > swap_free_obj(slab, i, rand); > } > -- > 2.38.0 > >