From: Matthew Wilcox <willy@infradead.org>
To: david.keisarschm@mail.huji.ac.il
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
aksecurity@gmail.com, ilay.bahat1@gmail.com, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/3] Replace invocation of weak PRNG in mm/slab.c
Date: Tue, 13 Dec 2022 15:02:52 +0000 [thread overview]
Message-ID: <Y5iUHJ+Qjso3U47M@casper.infradead.org> (raw)
In-Reply-To: <4925f0fe15e9cda5f9d90d75c6e15acdc413ef9e.1670890407.git.david.keisarschm@mail.huji.ac.il>
On Tue, Dec 13, 2022 at 12:34:57PM +0200, david.keisarschm@mail.huji.ac.il wrote:
> From: David <david.keisarschm@mail.huji.ac.il>
It's normal to include the surname in your sign-off, fwiw.
> @@ -2447,7 +2443,7 @@ static bool shuffle_freelist(struct kmem_cache *cachep, struct slab *slab)
>
> /* Fisher-Yates shuffle */
> for (i = count - 1; i > 0; i--) {
> - rand = prandom_u32_state(&state.rnd_state);
> + rand = get_random_u32();
> rand %= (i + 1);
Shouldn't this be "rand = get_random_u32_below(i + 1)"?
> swap_free_obj(slab, i, rand);
> }
> --
> 2.38.0
>
>
next prev parent reply other threads:[~2022-12-13 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1670890407.git.david.keisarschm@mail.huji.ac.il>
2022-12-13 10:34 ` david.keisarschm
2022-12-13 15:02 ` Matthew Wilcox [this message]
2022-12-13 10:34 ` [PATCH v2 2/3] Replace invocation of weak PRNG inside mm/slab_common.c david.keisarschm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5iUHJ+Qjso3U47M@casper.infradead.org \
--to=willy@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aksecurity@gmail.com \
--cc=cl@linux.com \
--cc=david.keisarschm@mail.huji.ac.il \
--cc=iamjoonsoo.kim@lge.com \
--cc=ilay.bahat1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox