From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C284CC10F1E for ; Tue, 13 Dec 2022 14:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 601BE8E0005; Tue, 13 Dec 2022 09:03:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B0B68E0002; Tue, 13 Dec 2022 09:03:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 478C78E0005; Tue, 13 Dec 2022 09:03:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 386AF8E0002 for ; Tue, 13 Dec 2022 09:03:27 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E2B91C65A1 for ; Tue, 13 Dec 2022 14:03:26 +0000 (UTC) X-FDA: 80237450412.23.4B535F5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id 02EC72005E for ; Tue, 13 Dec 2022 14:03:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=OXYUAfMi; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670940202; a=rsa-sha256; cv=none; b=YHGStADv/BM4U8O7tJUHVK1+WkmAMVErikTww9WlkQMN0DJsUbW9PoWIED7AUhHZtMd9fj S9QBhhfl981D+ldYIvNhBWQO0U3RvgVe01I6x2T4d+JVBf/8p/7cbIfJvjcbPOBLTW1DbJ vZxehibSKm0Ejp0jAPcY2ikILrGX96c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=OXYUAfMi; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670940202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XKy/NcC13yXOmU25oapyqo2lixJpYFXoptQAq2pSWKk=; b=yQa0THyGLgEoSPv3gVFbceM/4FnNnpgK8+3DLaB5UmNszOe25mVO57mOkLlHLSBGuDJf3x uVnGGu7iFBBvnfo4olcUPpGY2zD3WgUWa4GvpE3LPQsKzY5nbC4mN0kwR0b7TO9WIiuxUS cwn0wlj0r+qnduc20GETvhyim3ev+r8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 799EF22C51; Tue, 13 Dec 2022 14:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1670940200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XKy/NcC13yXOmU25oapyqo2lixJpYFXoptQAq2pSWKk=; b=OXYUAfMi2KkrqhWQhsIVfKCRYnn9puhrGfj1DKpChL2k4O+RB+uq/EZhyif4+UQRAMXvNh PM2zJr7QsmnppAyzVtHWA6+e2xcA1xU5R6hRRo3HDFKfJZYSdkZ/SkyYWM4bRPZYMh2VoW AzNkVq0gLDdu0r4il93PtD7Xrdo8wZw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 51E73138F9; Tue, 13 Dec 2022 14:03:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vJ3IESiGmGOJYgAAMHmgww (envelope-from ); Tue, 13 Dec 2022 14:03:20 +0000 Date: Tue, 13 Dec 2022 15:03:19 +0100 From: Michal Hocko To: Johannes Weiner Cc: "Huang, Ying" , Mina Almasry , Tejun Heo , Zefan Li , Jonathan Corbet , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Yang Shi , Yosry Ahmed , weixugc@google.com, fvdl@google.com, bagasdotme@gmail.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: Add nodes= arg to memory.reclaim Message-ID: References: <20221202223533.1785418-1-almasrymina@google.com> <87k02volwe.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 02EC72005E X-Rspamd-Server: rspam01 X-Stat-Signature: embwtuuatnujr7z5a48i7cm63jbuxwaa X-HE-Tag: 1670940201-246865 X-HE-Meta: U2FsdGVkX19kqXq74dAA2QnHliIk9aSyLAsxQxGmuOQqUgm7V1e7M625ddepyH+YTj5/PvKx/wwcyrHVtRvm+OyrxgarjmbFWckxIy/4aEr2aw1OWOTFCIo/6Fm6jaXEzOaS3AvR+EhyxhMWRG4eVfLCxXuSYsyIrHXyc2eWBviQspHLgQ3m0lynJfBCEnJpBFTxArM6DuIMsBzDtATYw6252TzUKsGV1qj/B6Yzit7r0Y/YVDq6yzyfzL48/tlU/wL5JTdJMw7fmTUO15R3DeoVg9ma+JhvBkcsLNV5cxTVt1KYTzyY0q1cuk7qHiyxClgMS6+qjaKeSrqgKXK2+W8iMZiTAxTqLR4Sj4xGbpNa4zO7gxO4FR5f/Sm5rhKatloHzWSTMZZTYGZ1ZjXSUn2/Pgb4iYS3dewsiPihEJy5fJr/3TuifavMhKWRx7ZJeWam3HjNGLHNfrDvO6/tqWj2MHanAWJUqjBFtlN9qfYm+d8ehNamrEydN3N0mJ6SXmiXZCs6R/76ZLVTnGyNC55iWETa4vV1fusqnNZzjidiLCXUF7Bjj5pq7H8TVIRmAG5clXbz/94Hpm4t9Wg5z79yPjyxX/apts9xqUSVCI78+WaTP/4q9uW4aujKTFMCFAqUvShxS+a1lZNc56fvHHM3dQFPvo4nFVf4R07uPs95CE6num5I6rBuUsKR2zi0S6caWvo3IwQ4YKDw7hEC4TCP0XZDkrpjHKS2PLYbRQnxFQUGi8T1XS4dAMrsggZa0Wq+22DBTi8LSWaJlMFhfhcZH2em7+PxtVM0JPnIEU9ngQMw6VqF/MTS1YgsERW7UdlEU0KHmjkMAfITL2MIS6+kMTOnXCAm/V80mrHMI8xpa+5J++/1PA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 13-12-22 14:30:40, Johannes Weiner wrote: > On Tue, Dec 13, 2022 at 02:30:57PM +0800, Huang, Ying wrote: [...] > > After these discussion, I think the solution maybe use different > > interfaces for "proactive demote" and "proactive reclaim". That is, > > reconsider "memory.demote". In this way, we will always uncharge the > > cgroup for "memory.reclaim". This avoid the possible confusion there. > > And, because demotion is considered aging, we don't need to disable > > demotion for "memory.reclaim", just don't count it. > > Hm, so in summary: > > 1) memory.reclaim would demote and reclaim like today, but it would > change to only count reclaimed pages against the goal. > > 2) memory.demote would only demote. > > a) What if the demotion targets are full? Would it reclaim or fail? > > 3) Would memory.reclaim and memory.demote still need nodemasks? Would > they return -EINVAL if a) memory.reclaim gets passed only toptier > nodes or b) memory.demote gets passed any lasttier nodes? I would also add 4) Do we want to allow to control the demotion path (e.g. which node to demote from and to) and how to achieve that? 5) Is the demotion api restricted to multi-tier systems or any numa configuration allowed as well? -- Michal Hocko SUSE Labs