From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E23C4332F for ; Mon, 12 Dec 2022 22:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EBE68E0003; Mon, 12 Dec 2022 17:24:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 674978E0002; Mon, 12 Dec 2022 17:24:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EE038E0003; Mon, 12 Dec 2022 17:24:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3AE8E8E0002 for ; Mon, 12 Dec 2022 17:24:07 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EB023120CBB for ; Mon, 12 Dec 2022 22:24:06 +0000 (UTC) X-FDA: 80235083292.22.487BC07 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf03.hostedemail.com (Postfix) with ESMTP id 3043420019 for ; Mon, 12 Dec 2022 22:24:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KUybaHVV; spf=pass (imf03.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670883845; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DduZ36/gNNuK+m5qHFBGb7Zr62cBswC5K6+2kXn9vQE=; b=3U1Z8/PmTqxqreZJsFH6C6teqgiubVhwIetYkiEz8HIcVGtCS1sKV0n5O052nrdEE5Ls0i DJB4ieZJ2DHPSndjsBirtrhQSh8F09ckSW3G1Q0AvWkzr5cbWv7jvrz8cOPylSa+lvwKhR mFCEw77Sex0j6/jYGf7sTvMhpMYlR4E= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KUybaHVV; spf=pass (imf03.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670883845; a=rsa-sha256; cv=none; b=r1PTrs4FMiCfXChBUcoW8QqIIkbK9HPWx8Yh7TO5JW/ZXx8fAvGpC7ErDRFxgP85iB9EvW T9rzaVeNljJ8V+6pVw+ZkISOW2e/VLVgyUA22BVQfkCvMDjueo90Klcl3bAgB+nU0M2qpu KVL2AHrUmdOmTBE0fbT7+UzLsekWRMs= Received: by mail-pf1-f174.google.com with SMTP id 65so921796pfx.9 for ; Mon, 12 Dec 2022 14:24:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=DduZ36/gNNuK+m5qHFBGb7Zr62cBswC5K6+2kXn9vQE=; b=KUybaHVVN3vB51GqoRWpHL2dDTx2qMFPypuONf/AmhxlZr55HRmLSgY5wpkSn1navb dyTi2H+7ZAZtAStM5HvFjAtD4ljlq5qcHJKd+rnNIe5MPoHkVUIrXEk2wYr8Qawciwe+ F3wYqQXQWHtzDjn2y/qMSnQuc+Cr3KqWgWxsE+EdXuTMEG6aOD9xbM9akomuQE/5nRWp AnAhL9RTKC4y0TrpDLXYj32qftrZhQQcovsuqi1GPshjIQuvDA8BDqaQ8hm82Pasqk7i dyTvyXn8iL4x7CjRudvASM1DyVneJ5/3auOxORwtTNf6DmwJ9N3OBtW+09+w3T0We0bI ixVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DduZ36/gNNuK+m5qHFBGb7Zr62cBswC5K6+2kXn9vQE=; b=Ed0fgEQh9P3NcKWXHu4CBWiagI/1Ed8h2OH5YrL7M/HEhK6D+ghwhqWqMo2sbByLs8 Ch3oQ6GazRqXryvscZxfGrTdbN4XlBhas9igzYrBX8H5VqCib5JZYfeM4/tR53cT0eCB yEo6PoMhhVD00w3W1DNFlUDgcu4XY4kZ8o0NcmknbXYsKZRt0ZoIeuXndQ0hk3R1kK2A 2+U14Ko5sK25k2jr+tRQPa07bR6bcxq7cjTKBkdxeAnkG0ilj47VnPdOa6X8i6teaNtw 6HxoNFlG3IzmRvXNhKa38gCw1wGl6BPRejPvDlkhdV9ZyrTue4g9Y3JksxrcdHKyG5gK OXgg== X-Gm-Message-State: ANoB5pnptnZwkiUqJkGK5ov1aNVm3H3mNXZhJGKeN+Yg3l62BlKHbdn1 pi34DmGIFKYFpexkN8NxdTo= X-Google-Smtp-Source: AA0mqf7w2sY2+JO/aSuCD35Y2z4vdxNFK4vcVZCzRRxri3yF2qj1Wi8BtYvS1At5X0J6AEo3xIYmLg== X-Received: by 2002:a05:6a00:84d:b0:566:900d:5ada with SMTP id q13-20020a056a00084d00b00566900d5adamr25516059pfk.10.1670883843884; Mon, 12 Dec 2022 14:24:03 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id h3-20020a056a00000300b005758d26fbf7sm6301027pfk.58.2022.12.12.14.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 14:24:03 -0800 (PST) Date: Mon, 12 Dec 2022 12:24:02 -1000 From: Tejun Heo To: Waiman Long Cc: Jens Axboe , Josef Bacik , Zefan Li , Johannes Weiner , Andrew Morton , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal =?iso-8859-1?Q?Koutn=FD?= , "Dennis Zhou (Facebook)" Subject: Re: [PATCH-block v2 3/3] blk-cgroup: Flush stats at blkgs destruction path Message-ID: References: <20221211222058.2946830-1-longman@redhat.com> <20221211222058.2946830-4-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221211222058.2946830-4-longman@redhat.com> X-Rspamd-Queue-Id: 3043420019 X-Stat-Signature: kwf4wqmpw4mnzchqwetyr94rgxze7eud X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1670883844-757602 X-HE-Meta: U2FsdGVkX186lOIu2GjwGqotmwGP1QhV691M9IbEpZ/UPxXaiHLk13z+1CJHd22cMQNo1vrExOGWmQbCNU3JhkVHliC+/CDHBhA2tBravyjROzy4lIx7YV4uiAbnU+Q+ap7T438cQlzojtUygUhFTgU6eSytyP/v/9l4qCJzdCf12IpeiTuYvIymMAMBE4aSzJOTzXQeLH0VzQBZ1+lHnvnZ1ZwyDYtjKxnnKw9430yIQVxLeElCuQeigRXJEerKYuzdhY/loqUtkCcLb125ZQneVMbaJ2ZCVp0Zl9sBXGQfxF7Rs7m8lQ96cXJfO+NbKfKwcEpc3Kh3uC83188Nov6ReDnZGl4IISauegPhbrUzVaizCeYi8LYwFr/GnAzF6wlRekNkLg9w/83Qoy3j65DFcCzWjjQkVEs7tNYaMAVx2eijSgk+Cx91y4wZJIQP/6/KdKMg7ZEOacVRiTKDNhYo/HWBI0Co1qH2Xb7PGoNDOlBeQzplaGG3jeb5Xe/ob8aXUEp1y2SmqDGvRRtbf3Fd8NtjesZj4Lx5B31/Fb0aAuAmTijFh1spmkwOJIryvGs1h8T5UEh5Kor/mifxENV3hU3vQlYnrms03HRJgqNVqQuLr5G4S+SdeOFMuaDjV17GeaOUqn/nh4bNkPpVzuMQH7kFdeRzylsXqFaDE81t8bavMYpKDS1+kJiQ+LGERW7SoEVjEeUPFjLJQ1GYIPYFiGrRDSlhvSX17RyXQFluM9EqRm9xsuKKz/ZREzIItNATf6cyOypl6CDqBDnBFUAIjcYFTIKwd/XMCARKHrKPscfSKtYe+g+bWu69O11+PsqjEWcaeh4wh0JI6n6Sli+0dPgPlIQpctEibebtSuK4oVytiOcss2+mQTuxXLJTzeGi/AadfvRX/ELP08qUFVDmAUMJDDhvrRfZuvjKGgiBjhAblZImwpYHsQEsUAwP4wKIVEfp6XZ6QRXmSAo U9GbD1+y Mw4M/EYG9CHQjb17/6/cgwQJeBWvYbIZDp0dPDV6FnOPv5TvgOYATPwbBu2/BsKH4WhBNIEXsyW4F39V4REBw82vb1ITDvbpvebgqfWdkyzFf/I6VG1T06JOFY65VuZAFjIisCIc1eGVMiJT4EmFD7o7aJ4B41orKNj2fXoMZpfMolJ5LOR2eydYxpUpWMquow4rnzG0y4riM3oU1Yr/pc+0IOZiZd+fP48ijqoMPrhdEKRWEmHXz3Y2ITg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 11, 2022 at 05:20:58PM -0500, Waiman Long wrote: > As noted by Michal, the blkg_iostat_set's in the lockless list > hold reference to blkg's to protect against their removal. Those > blkg's hold reference to blkcg. When a cgroup is being destroyed, > cgroup_rstat_flush() is only called at css_release_work_fn() which is > called when the blkcg reference count reaches 0. This circular dependency > will prevent blkcg from being freed until some other events cause > cgroup_rstat_flush() to be called to flush out the pending blkcg stats. > > To prevent this delayed blkcg removal, add a new cgroup_rstat_css_flush() > function to flush stats for a given css and cpu and call it at the blkgs > destruction path, blkcg_destroy_blkgs(), whenever there are still some > pending stats to be flushed. This will ensure that blkcg reference > count can reach 0 ASAP. > > Signed-off-by: Waiman Long Acked-by: Tejun Heo But a nit below > + /* > + * Flush all the non-empty percpu lockless lists. > + */ Can you please explain the deadlock that's being avoided in the above comment? ie. it should say why this flush is necessary. > + for_each_possible_cpu(cpu) { > + struct llist_head *lhead = per_cpu_ptr(blkcg->lhead, cpu); > + > + if (!llist_empty(lhead)) > + cgroup_rstat_css_cpu_flush(&blkcg->css, cpu); > + } Thanks. -- tejun