From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C674CC00145 for ; Mon, 12 Dec 2022 23:52:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34ECB8E0003; Mon, 12 Dec 2022 18:52:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FEA98E0002; Mon, 12 Dec 2022 18:52:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C7018E0003; Mon, 12 Dec 2022 18:52:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B3D78E0002 for ; Mon, 12 Dec 2022 18:52:16 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CAE1EA0919 for ; Mon, 12 Dec 2022 23:52:15 +0000 (UTC) X-FDA: 80235305430.28.1F1C1D9 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf14.hostedemail.com (Postfix) with ESMTP id 3F691100006 for ; Mon, 12 Dec 2022 23:52:13 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=dcvernet@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670889133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qipOPsspidMxqoo4oBDYgeBgzcLXxHtxJQXaWmeGNjg=; b=LO/727Dcv3NaM2dN+jgl2usZVDlS6GRHJ4q23T12vlxd8QguewYcHZUPO3YMVc+TSrVvuJ KGJtd47KMaSF5tWgcIUBR8Vp19PHQxgxruiDSQWhTAyNovhyVcYspNjlWshkxx5SVQW98N eLi6Qiwj7SgcZWTyYH/jhAgRIlG8ot0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=dcvernet@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670889133; a=rsa-sha256; cv=none; b=NkyXezDNsmmCDb4kHXw1+MhZCk3oE0NhQTVbMmYoaKwWcvDcAeWIact4hUirjWjF3VuMEc pB0FFSBwBToicFa055ysZUVceTRMGtY+bH1f03RFyqHejq6p2Fkn6nw6Dty8KvkLGFPktD 8O2LOObSzFsBvQ5E4Y+pcqB5fWJmtVc= Received: by mail-qt1-f174.google.com with SMTP id c7so2973928qtw.8 for ; Mon, 12 Dec 2022 15:52:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qipOPsspidMxqoo4oBDYgeBgzcLXxHtxJQXaWmeGNjg=; b=bhu2Ny2Bh/1oxZfQvxSpH4ri9IXk2T6rQvBfEQ7MKCVXoE/iHprPJsbzrlsmIcFsi/ GEg27yYvbIHRq0y06b7hsK+7rH1Nnt0aC2IVOaAwAiU8rCM0Fg8bokbtNVXMAdrHeYo9 KH1C8M0Zco+I6q5sRSll31EsIcZxm6jgliTCZdjmvsH1VfS8jV20QTsMy9ezXMmQhJqF PMbC3IwCKafn/VeOMOjrtkty/MNqwcIrUtjvm7lfNf6/1Le1/6XCUpCj3nZbtnCbPmvT z5FXmTunEYRGIPyPG82C4O8K8mMVlrLQr+cxEN+KqfR4Epr+OtXkMFKDHSqnnPADeI2a p+WA== X-Gm-Message-State: ANoB5plIYfV7DKWOkIcHeIAZS0m3dJvbDfuW3TrgN6aQzG17r1MxjZdu CqjIQFZUHlw/mY+fVFFv44g= X-Google-Smtp-Source: AA0mqf4Wp4XQTmHb2uDmp+hxS/HsJMf+1tLsS6USDt/JjjnwBP/kexha3QbPXHM2Dm8Jgi9OPtjblQ== X-Received: by 2002:ac8:6b4f:0:b0:3a8:270:c0b8 with SMTP id x15-20020ac86b4f000000b003a80270c0b8mr1577393qts.15.1670889132157; Mon, 12 Dec 2022 15:52:12 -0800 (PST) Received: from maniforge.lan ([2620:10d:c091:480::1:6a51]) by smtp.gmail.com with ESMTPSA id r18-20020a05620a299200b006fed2788751sm6895425qkp.76.2022.12.12.15.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 15:52:11 -0800 (PST) Date: Mon, 12 Dec 2022 17:52:10 -0600 From: David Vernet To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alexei Starovoitov , bpf@vger.kernel.org Subject: Re: [linux-next:master 7935/14039] progs/task_kfunc_failure.c:76:36: error: no member named 'last_wakee' in 'struct task_struct' Message-ID: References: <202212130502.iuVFgkdf-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202212130502.iuVFgkdf-lkp@intel.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3F691100006 X-Stat-Signature: f189f358s6hm47wnskgtnf75dynaw1xz X-HE-Tag: 1670889133-432473 X-HE-Meta: U2FsdGVkX1/9TL/E2xgUfNlO/tLKTsKkrd3b0FtWxsvVU0O63pyiWh6uspabFHY+dtEI2Fp+aYx27ecjPbjyBgFCcf0Kg5fVP6i+MNE5zSYox4PO8+kEHZP6aqWpy1IiDaNpEOqKelwpk+MRHvfTC1mQERAe39u6/3467TOK9s/93XUnMa7OlPv/PEU13JwRyQfE3dod25AGV+HTd7eQk39DGdmsgOG+OrkWJ3fAGeIsx0nMNRctFptJ3rZzf9blMt4v6dcieO7goCHvRVckkvlVEZIR9fttTCkYvaZnn81jm035IAdc4YHt88Ragfi6ICQkrmBcA0SEmuTQISmIlCIVbVou+GJTFYMeV6s7/fqAQUJ24d16sz2sNbH1VudQ5RHhv4knm5MTk/tmVHsC+57fuRFf+PnGuym4QMHE6OJ40zI7envRAv63uXyFjzmZ308pPbnA7s84YaS5F6hDfSWRnVgsCS9ZDnE4r5a02C3xZn729ysmDiI0TXbcREU1Y+JmmdyCJ5CyxUfm1rELtzTO5U4NTcz86S1yF2SgL70TWxlo9/sgtDOTwN+QSh2lFIgEaiOaseU7Eg3orGT0yTrjneatCEhgMqDf5mgynU0hG6STzsi9ThRDdxhXvsFZCOGB+GMxbupIzbxr0sbB6JRF5n1tGD2vko5s3y3R2pzurWh2b8vM3cF+XTRiGIubcLGUrHSgYtcJCTS1WfypAHwOsnFmUZjY+bppGPtW+VEbtG15SdNez5EsACR5XJUnr/vYG1TtezWsPDFEDjLxyEnSTSm0fikcqppDcAzc2fCnqXszz9r+3CoNCzCL0P7eSZ/lb9bcKAWUB3J7s1VdwkmT9FAGEYg8GMp4VGGMKzhN4pVgqXZeVUHUaf+TYi4yPFWop5WXeWPKqJEu3k9O+9gVRmeXnZCmXAWBsUx7oB4MFy2VMLdLq6fUcngwh+PwyvDsyomH6src0RT7ZFW DacY3DuP GzWoY3fN4tqtr/DCJkJ2ss5CBo0CxWBDa/t9zhSESDyQFEedHS+ZTUxG7Y8h6G4GKBC9/wJ+4X/FUDnWIukw/BVYOFB2fphf4QBex4IaN0Dj6dvB/P2iL8EnrBwS1ubQDvUkBJU2pNtK5Cqc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 13, 2022 at 05:35:01AM +0800, kernel test robot wrote: > Hi David, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: f925116b24c0c42dc6d5ab5111c55fd7f74e8dc7 > commit: fe147956fca4604b920e6be652abc9bea8ce8952 [7935/14039] bpf/selftests: Add selftests for new task kfuncs > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 > reproduce: > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fe147956fca4604b920e6be652abc9bea8ce8952 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout fe147956fca4604b920e6be652abc9bea8ce8952 > make O=/tmp/kselftest headers > make O=/tmp/kselftest -C tools/testing/selftests > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot Ah, task->last_wakee isn't defined on UP builds, my mistake. This patch fixes the issue. I'll send the patch to the bpf list in a separate email. >From 80ec7fa20b0beb1b047bfc66b49b0910c578da83 Mon Sep 17 00:00:00 2001 From: David Vernet Date: Mon, 12 Dec 2022 17:34:40 -0600 Subject: [PATCH bpf-next] bpf/selftests: Use parent instead of last_wakee in task kfunc test Commit fe147956fca4 ("bpf/selftests: Add selftests for new task kfuncs") added a negative selftest called task_kfunc_acquire_trusted_walked which ensures that a BPF program that gets a struct task_struct * pointer from walking a struct is properly rejected by the verifier if it tries to pass that pointer to a task kfunc. In order to do this, it uses task->last_wakee, but unfortunately that's not defined on UP builds. Just use task->parent instead. Reported-by: kernel test robot Fixes: fe147956fca4 ("bpf/selftests: Add selftests for new task kfuncs") Signed-off-by: David Vernet --- tools/testing/selftests/bpf/progs/task_kfunc_failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/progs/task_kfunc_failure.c b/tools/testing/selftests/bpf/progs/task_kfunc_failure.c index 87fa1db9d9b5..60508c20041f 100644 --- a/tools/testing/selftests/bpf/progs/task_kfunc_failure.c +++ b/tools/testing/selftests/bpf/progs/task_kfunc_failure.c @@ -73,7 +73,7 @@ int BPF_PROG(task_kfunc_acquire_trusted_walked, struct task_struct *task, u64 cl struct task_struct *acquired; /* Can't invoke bpf_task_acquire() on a trusted pointer obtained from walking a struct. */ - acquired = bpf_task_acquire(task->last_wakee); + acquired = bpf_task_acquire(task->parent); bpf_task_release(acquired); return 0; -- 2.38.1