From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E325BC4332F for ; Mon, 12 Dec 2022 14:35:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 194058E0003; Mon, 12 Dec 2022 09:35:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 11D378E0002; Mon, 12 Dec 2022 09:35:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFEF68E0003; Mon, 12 Dec 2022 09:35:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DDD198E0002 for ; Mon, 12 Dec 2022 09:35:35 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B161DAAB31 for ; Mon, 12 Dec 2022 14:35:35 +0000 (UTC) X-FDA: 80233902630.12.52F09AE Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf07.hostedemail.com (Postfix) with ESMTP id F3F134001C for ; Mon, 12 Dec 2022 14:35:32 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=Wl6pADoH; spf=pass (imf07.hostedemail.com: domain of "SRS0=Tsvw=4K=zx2c4.com=Jason@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=Tsvw=4K=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670855733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1KyY32z5nf0Lu8vM4J/2IpAlTcstrOO9+asdsS0mdQs=; b=H7CuUhZkU0b5zZUkUpjr2AfKwgOd+IA2PBxCAWhYeB9nyCdGKN82m0sNj/nuyKIBZB6SuN 2A74hh0UhULJdoFlJxnMpAsVT5Tg/tWYLAj6YY8zeg/Vjr/8Ris/1RO91dPAUIFNBLhMsm 82hyKBbOMRfP3e4cB3XS9mrTdTgm9Mc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=Wl6pADoH; spf=pass (imf07.hostedemail.com: domain of "SRS0=Tsvw=4K=zx2c4.com=Jason@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=Tsvw=4K=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670855733; a=rsa-sha256; cv=none; b=IL4QC16BgXo6fQUPrp0vsaXAw8v3kr700W2UFwc3iAAw9o7bfPMJn/4I0j2ja/q6xE0/WG Hr28YGiWFfH7vuf8G9drIuFutkp2pD0kcYGhsKTTgC9gPuVntEVhrzK0oH0BXGcxOPSVJD HtK3dwZa0yZhlHdvrD6pYderCEnTfJY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C246B80D8A; Mon, 12 Dec 2022 14:35:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B7EEC433EF; Mon, 12 Dec 2022 14:35:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1670855721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1KyY32z5nf0Lu8vM4J/2IpAlTcstrOO9+asdsS0mdQs=; b=Wl6pADoHCtIIbQYtGWyzoK0/ft/6K3+8UZfyGZQbHCn0OgumkLD978IERouS9rLh91V7py ofol1dOocMk4p1DFNAhuJ2rC6+TlFlqFiUo0IADIb6l2vBWdPsmninRN5yWI9N/OpXZpdd 5BCaUAKkpp98C6Hq6gwjcSOdDz781ww= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id db04abc2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 12 Dec 2022 14:35:21 +0000 (UTC) Date: Mon, 12 Dec 2022 15:35:20 +0100 From: "Jason A. Donenfeld" To: david.keisarschm@mail.huji.ac.il Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, aksecurity@gmail.com, ilay.bahat1@gmail.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: F3F134001C X-Stat-Signature: zwi5cbrszm8x9znnripjt7wjzxp9bzex X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1670855732-165649 X-HE-Meta: U2FsdGVkX18QEHAOuJlW9stDcU+lzCu7JMJGOhYW8vL14awAeWjkdaTFOJRXfi0jTKOGnM1uwgpBT7Hb4g1HLUTJFxRHDHEhnmHhxRp75tlp6DJorSNF6977iJq4vqjJdBj6TJpQmrN7qaK7IZGRnvuzxUkQLwrbcTOtYpo3+JaCNUd3SoLSiekuO0hjaCvNvw8RYE//mzux6wa+s8HA01MD2ri5RkRN5F+viX/zdhM9c/1egi4qBm7KwtGOOrspM0e724ypjweL+8Sxw6RgBRlmtK9AyDklPm9xGM4vat9hCLaPc3ArCxN0kqBS3BO0rcFrMekZjUHRdUOWh2m7SAvA7wUVKcf8gaKWwF2PhRcJ8soG6EZVdbnVJMtjVrd7Wi+/QVhAopIxpmF8cRAPILoWSlV+BG6AQaX4hHPrZ6nG9hJTVaY2z6/1t/G5i0gADgsknKCYPX6xOztoP/CO0OXl/dy6nuZD7YoqSBqUETQsPBQKpQSdGeZgjw8CFdi0DC9P4hrwOFPM4Sn0xQfWW+gnRebH1OIYWo12y+MtZPGHYs2gIJMM/cm88O6Wl0DuWKyB9E3VYsSMdJ88/46tIiGlH33El4DC9TI28Cfw0cEmVUUcyhlOygBNvCnPG1Ig8DcOCxjzFXG9b63bX8bAwmp2PSLeTpD/gINMMHCTNREuJm05Kly4fLe1+HXCoYRlZeh4WUeQt2AO9mXjIRzbp89Oe25m0yp/5Ql65KALNEsH4Q0DquQzMuEGypdHcY9VwtKC6F5Xwjvm6ZscB1GE5UcOknT/tYR0IkGagNCdO0ZNJaXW5OH1giwXevVWFtEK5ymIrca+hXiWswgw26mxrs0I/m0/r88XpOROleYRfdQ6GosCAKpNqo/TddZbit6BQx6tE5yPQSrnKREbL81NbZyPpVLRRb8Xg1gwr83vURs1OTPpeC6WvyYtHkZpZ1OILlDiCvvmckbS2SwsEsI /KDFDoWC BPFOUganmkcWdDDXTGcY+C79e6vXzFMLmAZIhTqzVYemU49WCz72b/5qvH9nftyPvDb2XrJMDboWMdE3sCaR8F1XS2cxJn/CvpPtbzCtG36i06Jd39deMsFhH8b0hd7xnm93G+Oz+DBnmtRRI84K3X5wMvh/9t2jrtSTXuL/pPZDs5KJq0hp6en1oBmG1zHyhTA1b3XQwX10jtQtZn7jIgAvhUbRwhywv3zGwsPPistS7ANBUVCJaqaT9S8kqZHSw0+zBnkrRGPi+kOErBcjZVLVUjy+oPfexlM6G6ha+ZIwPJYD+7Ka12jsqaLS8plwaObJ8w7GaNETnQR4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Please CC me on future revisions. As of 6.2, the prandom namespace is *only* for predictable randomness. There's no need to rename anything. So nack on this patch 1/5. With regards to the remaining patches in this series, if you want to move prandom_u32_state callers over to get_random_bytes() and get_random_u32(), that's fine from my perspective, but last I looked, there was much usage in places where being repeatable was actually the goal - test suites and such, where you want to be able to redo your tests with the same seed. So you'll have to look at each instance case by case and convince whoever maintains that code that they don't need predictability. However, if you do that, the right functions to use are get_random_bytes() and get_random_u32(). Jason