From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC84C4332F for ; Mon, 12 Dec 2022 08:36:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F89B8E0003; Mon, 12 Dec 2022 03:36:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A8818E0002; Mon, 12 Dec 2022 03:36:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 670C98E0003; Mon, 12 Dec 2022 03:36:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 54D358E0002 for ; Mon, 12 Dec 2022 03:36:06 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 15317C0767 for ; Mon, 12 Dec 2022 08:36:06 +0000 (UTC) X-FDA: 80232996732.13.23B7210 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf22.hostedemail.com (Postfix) with ESMTP id 446B4C001B for ; Mon, 12 Dec 2022 08:36:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WGhA0LNq; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf22.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670834163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vJ0e6TlPBu+QqbSE8efHwpDcCI1V8Fh4DjFbNdb2my4=; b=GmpaPxugdjBc7nKQZS9i/MRZdflrYAQED2Hl/DhB/zNx7sbjEK5uN8oi7ojtVrN/Krs0+P FMWoLGMmeE2h7NyBApvdFlZzIKTWJn8g9Q+iUO3ZD/LTiudFc1VSgGQuNiaQNa3B3tBJJz zdepmMbIxsBrQiATFNMDMuUtzqR/4lg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WGhA0LNq; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf22.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670834163; a=rsa-sha256; cv=none; b=2KwaMUv4qODJ6LvP3YDRo4CZA4DShoPcdlW0i0tODldNDVvhLBYEvJhV/iP9figlJioltV MOviDblRQsx9ktK3HdzIFtoEr0EBacqeRV0Hu7Kmbx7ftfANK3+YWq1njJelzvrVJGvxa5 gVGQyzSNTD8HwEQNeDtvqZzNXH3UefM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670834163; x=1702370163; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bFYTa27LxNC965Nl6ptrEOem3ftkvwtR2lcZjjhuh7w=; b=WGhA0LNqzc/Mx7NegPrd9f3tAPxRqROoq5PW/v+jm7Ru1Px3CTwH3q2f vXJ8msdvhp5QndwiiG3THXFvQBi0UH9gfwEIEUT/Llro5FNZtUOj5p5OR OTxdBNoAQnaQuxb4/RTDnDeyh5QTrUv8a0TyWF95/MAoaZNcTUAmVbWqD pR5MMcuKP2Im+vLx/yVkMq555otpu2fMGYMjXSDbf0BaT0p/tQ9F+vqfy 2VLvgbilIRSBZNQpprf8wnIH9KmshHSdUnVYx4VuLrtuLUAxfxZQdGjpX qaX1DFK1d7k8x0KSk1Pxx0RKqxDp/JdMZBWdUzM5vqOVJurtVpz7cKSYd A==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="380011021" X-IronPort-AV: E=Sophos;i="5.96,237,1665471600"; d="scan'208";a="380011021" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2022 00:36:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="822407894" X-IronPort-AV: E=Sophos;i="5.96,237,1665471600"; d="scan'208";a="822407894" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 12 Dec 2022 00:35:56 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p4eHx-008Nh5-28; Mon, 12 Dec 2022 10:35:53 +0200 Date: Mon, 12 Dec 2022 10:35:53 +0200 From: Andy Shevchenko To: david.keisarschm@mail.huji.ac.il Cc: Dave Hansen , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 446B4C001B X-Stat-Signature: pefbj98cijoyo4fhyqwmj7tk5jgawt7r X-HE-Tag: 1670834163-254254 X-HE-Meta: U2FsdGVkX182ZR3+uGCPn8cpk5GfjJq1zx1DG8flyuZ8nxxJrceIs805Nk1uInQkuAqwQqft2RiGi7AwFPz6poB37zAd3z70VKZKypxrJ1Sc0+iJ6YvqbpfeRkkoeZUUq3mm0K7sD4yDqq9ARjI0W5y1HP/XGZPj1FsDY48ZQFQUwMFeUj1DghR2U7aV6HNycpoe/2+Pn0LPyfqzuoj2ywoQJCZmblopCdCYolWOIpuSZHaK5PG5gQeCMYuJlHRmSl9AC4PufT88jitRIF83k4CgnIv85SfjqZfGMwJoYVappNThct34wGideY8fhqVVbqbeUeFW0AGj2kkh0FYdYlpFVFnHqSzkuIoL0WFzhzWHjrkNyltWCqvto/Ul6UyrlL5nLTKN6FQuOp7TM76kdDH2Fg4V2J61ERk2Aqnzllaoliw6uoeZjDmAbioBEH83eROLmkBaR0xnyj9FpyFg0jcUuXnYoPr/pOsJkGW543ghxl0RrgBTZjVF3GYiAGizgU9cEClnCFS/eNG4SZPUHXq7405nXO1F3tV3OX6CO+jo3EyUH/uaTQ10ni+T1rXvgHG45SkGTL7R0wBi0OZo2yrpHavy3fupYXzXFfWVnmztv01bjhcf4qPhXDYRtPc5eCaxn4v5bsEiXk1lTylW9jbZ0QWpI0dfvPgeCA+gqZkJAwPWAtAMeRVwNju3YCUrxv7aRzvnql2+Gh7fPA9OZI89sgQKQBsFbePYPQ0Mru3P0azmI+jZ0SzUGugT6oL3k5aaGcivTW4mmbIi0VHKWOEcQ3gZKEAx3M84W2uqT9ZYJEG/cQaLiXxqSefDWkbbmhulGwdGsPV77dJzUQtCRPb4Vm5bx6M1h1wimJgeRgzcqOoRX4hNo9tFXSUpwCygqSPcMQI+9lkARN/R9N9FFO2aqtaev/e6MZ7/5+F19O/HULhgG0FemA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 12, 2022 at 12:16:04AM +0200, david.keisarschm@mail.huji.ac.il wrote: > From: David > > Since the two functions > prandom_byte_state and prandom_u32_state > use the weak prng prandom_u32, > we added the prefix predictable_rng, > to their signatures so it is clear they are weak. It's fancy indentation. ... > /* Fisher-Yates shuffle */ > for (i = count - 1; i > 0; i--) { > - rand = prandom_u32_state(&state.rnd_state); > + rand = predictable_rng_prandom_u32_state(&state.rnd_state); Isn't it too many "random":s encoded in the name? I would leave either "rng" or "[p]random". > rand %= (i + 1); > swap_free_obj(slab, i, rand); > } -- With Best Regards, Andy Shevchenko