From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F33C4332F for ; Sun, 11 Dec 2022 08:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A34758E0003; Sun, 11 Dec 2022 03:39:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E4518E0001; Sun, 11 Dec 2022 03:39:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ACDB8E0003; Sun, 11 Dec 2022 03:39:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7C1388E0001 for ; Sun, 11 Dec 2022 03:39:30 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3C26380124 for ; Sun, 11 Dec 2022 08:39:30 +0000 (UTC) X-FDA: 80229376500.29.7888031 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf26.hostedemail.com (Postfix) with ESMTP id 71F37140002 for ; Sun, 11 Dec 2022 08:39:28 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=Cz4Td+Nq; spf=none (imf26.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670747968; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Y7vFlXN4dpdx112qEN+bSR77M2vRXyg5PmbyBVzU7I=; b=12Q0pjT3tIHzEX0zZmOQUdTsahSbYkDZh1Pp5QYPCWCuLXNjoFqYt+2RN7m4+2/N928U8k lpLhrGbTGoTBBMZspAen/aSYYOSocFA4T2AhRoGyNVdIP9vqVXSMtrFV5JBYzgGk/ko0UQ m1KL+IhkXsi4lEyhOWSxiHqQQsHkoRA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=Cz4Td+Nq; spf=none (imf26.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670747968; a=rsa-sha256; cv=none; b=LCqsZcj4JeulwLVACBWH5bW1ci8Xbm+ZISU7oVu8C9Eq/df6s3jK4zYSK83jCZOgoznVvY sV82bk2neT4z97aPPVsu20grNNX+NgPFmG95pUA/v55FPUccoplSC8HuEJlbXflp65gSu8 VNoirExu9q5Sn0XliH18xc2yhSV7prE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2Y7vFlXN4dpdx112qEN+bSR77M2vRXyg5PmbyBVzU7I=; b=Cz4Td+NqID70MKDTNuweMpREsa UeNFNbmjanwdx1Q0Y2XXA3Qq7yJOB3R7gLDo7/vDzk3/8pzc/220Ra8kG4PNC3y9Cfj8KlUJp7H/3 DTWAqBHoL4mitmAujoFBS8ugTrTqUx4IevnYdnnbgAWQ002YG02qnQ/snua0fXHQvjv0/dU80KQlK MRA97SP8Lu6J73TBAZjri9wZ0XRDYBBH26RVAvbKukd+RACkS70HQtJqETtdBownyHLG6Tk7CO6bX Zkl8ik2LsJJTyo3tf56MThyWMM8AruVpFIqyKfvgqn59Ri/e6+EDv6SICD63g3DlGm1iJG5j9PTOx 6Y5UGMsg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1p4Hri-00Azlo-0e; Sun, 11 Dec 2022 08:39:18 +0000 Date: Sun, 11 Dec 2022 08:39:18 +0000 From: Al Viro To: Hillf Danton Cc: syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] WARNING in do_mkdirat Message-ID: References: <20221211002908.2210-1-hdanton@sina.com> <00000000000025ff8d05ef842be6@google.com> <20221211075612.2486-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221211075612.2486-1-hdanton@sina.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 71F37140002 X-Stat-Signature: e9u6rtd1u6t7a1gx1xw1dusowdgyutb3 X-Rspam-User: X-HE-Tag: 1670747968-205173 X-HE-Meta: U2FsdGVkX18wKJ17cjIzVYdvmUE1FTfvNJ4JL5ZB9r9ggfn+7EVwHWAFDXHtg2gqjvjQ1Z6VMUb1svQLSBXofTYyVQJfqSbQPtkzVnSBBKNiq1jkYcUM8O8WCUPzM+prY3xUJrJTjkQGonA/qF/70lxIh18GRVA1qMbKhB4NdtV6yE0re2XTpkKzqxr82ao/t7n2OLlZe+hRGrvGqtdnnwMSCi/lXI7IgD1nesEchd0gtVdUmORjw6wG194+IzaijGcNllo7JZLdnNuQ4zCc/jfj1QDNH3z8l28oQDgizIP1VC8XX4uNSTIAlgcm6X+iXCx/xpH5n09ZRz08WG/3o8EgvVOsa5/Qi4ZaUn0w3w3hHp1YAnDMGxHRUQmtiDOSSdHBrIecxQZe0Q0tPEbZP2REp6BKbW/yQR6mzFzQy2xcCJ3eTRUDbetQ6BFJ/Wjt9eS9wPCGOWhvfj8WMP8nHicAPD9TNCATaYr3JnUNTygU3yTFvYbM64x2uAQXNQ2VQN2TaDXM6Nn+k6/RDtT4p5ZikuZiYHpVj4wZhPbZKBtCkozBr72i2PF5ElPiRsLip4ofgXjI1QvZ0d+jfNJ0vgGNl8+jWM0nZMHUybAj0OkCFgEGJOvAUvk+37jgsZf60u+5UThjNu61Fssj8/8sbd2/D2Wqe6oDxMNIiCl+7w6kkzmSBgZVRlF4MaZT2cmebJiHl0LOuIngBJyVhwxMdvRhIGHgEus80MfbBUwHcJNoumV7AMctYtCd6maZEkLiCwTI+Ual4/Ee/11MVpif2eGIIWNiOOHAWiYW/PJJO8/P1x2Dvt9MJasC2Snk470U+FWFPV48pM+4ox2Uq+UmXVrYP4td6E94bbXZ8/Av8uR8K0wCqJPuxfXvhbL3XR8WOokUc8AZDBkEYivdUUvf0LtqdPpIZ7UwobhVeNv8AmW40Qy9fmpd53cRxrOEuKweRsxl7GRTttroklMJA5D UE43TNO8 Zwqg3NSWfFmAXYTpR4GlFYt2Dywn5zYFGt22MPAOqOEemJMlHvdkoBIVWyitVeelsAE2/Tm1/FpOyAKfpp+AULXg5tdJev1VP6IZpcuNp/YeqZgJ+RdikBj4yAD67Lfu8PxSldhMN8+OCvG/TQVnwDJNG79pxreh+sX5txDxYGnx4UQQQsTtxh15AUsrlT19HpbQUykplRCmxALyuA4K9oG0agEgWXVihtQPrHd7Ko+GUhHw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002764, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 11, 2022 at 03:56:12PM +0800, Hillf Danton wrote: > On 11 Dec 2022 02:52:57 +0000 Al Viro > > On Sat, Dec 10, 2022 at 06:30:22PM -0800, syzbot wrote: > > > Hello, > > > > > > syzbot has tested the proposed patch but the reproducer is still triggering an issue: > > > WARNING in done_path_create > > > > How many times does it need to be repeated that ANY BUG REPORTS INVOLVING NTFS3 IN > > REPRODUCER NEED TO BE CCED TO MAINTAINERS OF NTFS3? > > > > I'm done with any syzbot output. From now on it's getting triaged > > straight to /dev/null here. > > Calm downnnnnn Sir even if this is not the east ender style. > > Frankly no interest here at all wasting any network bandwidth just to get you > interrupted if it would take less than 72 hours to discover one of the beatles > you created. And actually more than double check is needed to ensure who > did that. The first iterations of the same suggestion had been a lot calmer... One of the earlier examples: https://lore.kernel.org/all/YzEJ2D8kga+ZRDZx@ZenIV/ And I distinctly remember similar attempts from other folks. It's really a matter of triage; as it is, syzkaller folks are expecting that any mail from the bot will be looked into by everyone on fsdevel, on the off-chance that it's relevant for them. What's more, it's not just "read the mail" - information in the mail body is next to useless in such situations. So you are asking to * start a browser * cut'n'paste the URL from MUA * dig around in the files linked to the damn thing ... all of that for an fs maintainer to see if his filesystem is even present? Seriously? For each syzbot fsdevel posting? I would have looked at it anyway; granted, seeing ntfs3 I'd chalked it up to ntfs bugs (fs/ntfs3 has not been there for long and it didn't get outright memory corruptors beaten out of it yet). But how the bleeding hell are ntfs folks supposed to guess that this report might be relevant for them? Same for XFS, ext4, orangefs, et sodding cetera - and for most of those any of such reports would've ended up wasted time for the good and simple reasons that it's not any fs they'd been involved with. What really pisses me off is that on the sending side the required check is trivial - if you are going to fuzz a filesystem, put a note into report, preferably in subject. Sure, it's your code, you get to decide what to spend your time upon (you == syzkaller maintainers). But please keep in mind that for recepients it's a lot of recurring work, worthless for the majority of those who end up bothering with it. Every time they receive a mail from that source. Ignore polite suggestions enough times, earn a mix of impolite ones and .procmailrc recipes, it's that simple...