From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 259B7C4332F for ; Fri, 9 Dec 2022 13:17:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EC5C8E0003; Fri, 9 Dec 2022 08:17:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59B9C8E0001; Fri, 9 Dec 2022 08:17:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48BC38E0003; Fri, 9 Dec 2022 08:17:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3B59F8E0001 for ; Fri, 9 Dec 2022 08:17:14 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 079E7411DF for ; Fri, 9 Dec 2022 13:17:14 +0000 (UTC) X-FDA: 80222818788.06.13550F4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 9DEB614001D for ; Fri, 9 Dec 2022 13:17:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf23.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670591832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=svunTqVDG2oJcNd0UAEukkmvUEq0I5FdQGMP2yoHm6g=; b=dhD3vl5cIqETYcS7hgvgIrFRFiqHl/PS8gtW6+sxBHHN1+K2V8xOy3FaQAo8bRQYCR09+U Xgctx7zga6iA3GWoH2Emm0/EmNSEtvtR8oPlWyMuXDoWQwtropqtMAbdNV9DMLHbeHrtau aW0f3D/iUh8wbt5xrsTxzMtrwpV6JdM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf23.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670591832; a=rsa-sha256; cv=none; b=h0KshLsQ41nNxqFJl6kYk64OGjOP6N2Gd2AOxxfmCh+cXBcQtXKnxf5OxGL/+UIqTxBK19 pK0mjKz48KaISepMbw7EFc/RRRur/hxV6MbzoqtmQ4YFyIwh6V+Mx79Xs8zT4QKN1/DZpK uaYpWiU7JALDG3nl0B9yvmlmbmtdeRI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D8F023A; Fri, 9 Dec 2022 05:17:17 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.39.232]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 868643F73B; Fri, 9 Dec 2022 05:17:09 -0800 (PST) Date: Fri, 9 Dec 2022 13:17:06 +0000 From: Mark Rutland To: Xander Moerkerken Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xander Moerkerken , Xander Moerkerken Subject: Re: [PATCH] Added ability to vmalloc executable memory Message-ID: References: <20221209131052.64235-1-xander.moerkerken@omron.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221209131052.64235-1-xander.moerkerken@omron.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9DEB614001D X-Rspam-User: X-Stat-Signature: r47n771nqjjkupakd6w3r853see3jrkw X-HE-Tag: 1670591831-581990 X-HE-Meta: U2FsdGVkX1/bZ4nEWxSBxgu8y9ZFkFpGZhcWigWY3u7cwFwfupLZ8em0uTB4hdAL8b5cZf0FRw3u5DSjGSRLarMHaGg7IedzD8BSEfiyceA2uSu48eXdYEfnzXVZZi2R8s/6pd6Ya1mbzV/Fz/WAMWYniSq4PkwIkhu3XpSkwlSkr2/WsW407xU6X9ChL8nhu3MEj8ZeMQ6blMT7OLdzYDlBOEEj3qsw3JbvXZQ5N3QtNb8o/XO8s6Ac5c8x81I+YsUc6alVA+Fy3IOzZl363chYxw0Oxf2eGK55PiMyGRlcueIqI5BL8gS1UlfIzvSopYt48gRbI/j1a6iGhnuXmUsO1LNY8Xd1rQSIQ9kkkkmqm3A6EgToRe/QBApygN3haXpHX/YPOY3bQzOo1vSdPVbBGzZmxAQpjyEfAaqKirc/MgZk6w4UVm1TC03Sva0d8uDv0oap6gyLb3naXXqB/Ihfh6ZY6nghhA1nqmJKq8TpP9K2LPVft2PLZjVbynnLc+T8EnrHP4W1ntZ1Qc2vO+gEBf2OnyIR6aIzTcKvkU5OEN0yLg0hW80bfosw2jTGrrW28eAsySYyPQwsBjEokbeWJATXP1aMxZNmv9O9HEunJzkP9frZoUGAZ0ByhMUw5QrY2QJBglRz3ihYnBkM0LSh2RKvq6bRJo/Of12AwwSuBGqz+FVaRskmpkmYZJI2dwXBn3ZpgtwR6mnURn1GWPulMG/GqgvsYsNrJ4OzWwVVAVowddOv2ddtPEFAXeblxZ+zy558kYUQdmABGNVhL+C7VgFeaqyxcRAPwDEfT5LkjfuGpDrRcuFUS1BTby3JmQzs9ENdg9MD6uXF6EtVGluCwZhj1zlXBRKpThjjS7TNZbHdZM109ROATeJH1RQDEp1pgcclUsg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 09, 2022 at 02:10:52PM +0100, Xander Moerkerken wrote: > From: Xander Moerkerken > > Since release 5.8-rc1 the pgprot got removed from __vmalloc > because the only usage was PAGE_KERNEL as argument. > However, this removes the ability to input other arguments > such as 'PAGE_KERNEL_EXEC', which can be used to allocate > memory in which you can execute. For this reason a new > function is introduced called '__vmalloc_exec'. > > Signed-off-by: Xander Moerkerken What is this going to be used for? There's no user from this patch alone, as a module or otherwise. Mark. > --- > include/linux/vmalloc.h | 1 + > mm/vmalloc.c | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index 096d48aa3437..10c46513b6b2 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -147,6 +147,7 @@ extern void *vzalloc_node(unsigned long size, int node) __alloc_size(1); > extern void *vmalloc_32(unsigned long size) __alloc_size(1); > extern void *vmalloc_32_user(unsigned long size) __alloc_size(1); > extern void *__vmalloc(unsigned long size, gfp_t gfp_mask) __alloc_size(1); > +extern void *__vmalloc_exec(unsigned long size, gfp_t gfp_mask) __alloc_size(1); > extern void *__vmalloc_node_range(unsigned long size, unsigned long align, > unsigned long start, unsigned long end, gfp_t gfp_mask, > pgprot_t prot, unsigned long vm_flags, int node, > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index ccaa461998f3..8fd01ed7082b 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3294,6 +3294,14 @@ void *__vmalloc(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL(__vmalloc); > > + > +void *__vmalloc_exec(unsigned long size, gfp_t gfp_mask) > +{ > + return __vmalloc_node_prot(size, 1, gfp_mask, PAGE_KERNEL_EXEC, > + NUMA_NO_NODE, __builtin_return_address(0)); > +} > +EXPORT_SYMBOL(__vmalloc_exec); > + > /** > * vmalloc - allocate virtually contiguous memory > * @size: allocation size > -- > 2.37.2 >