From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D06C4332F for ; Thu, 8 Dec 2022 21:32:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5ADB8E0003; Thu, 8 Dec 2022 16:32:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0AFB8E0001; Thu, 8 Dec 2022 16:32:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD2D28E0003; Thu, 8 Dec 2022 16:32:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9E4068E0001 for ; Thu, 8 Dec 2022 16:32:49 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 71359A0F4B for ; Thu, 8 Dec 2022 21:32:49 +0000 (UTC) X-FDA: 80220438858.13.1884BF0 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf23.hostedemail.com (Postfix) with ESMTP id CA669140003 for ; Thu, 8 Dec 2022 21:32:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HoGLKZMH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670535167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+TrQiFZlVHCDTQZCh8d0lNxTCa2DqXYRVLa5t6bBFo4=; b=eq3ls8jDuDfa7IcHNWvQrl01GXXd38YKwWnA+4dMxos5dkE+cK3hi8pxVlANLewVz7G/lP 4uNaNedPnOlJVbDx7CYNn+tghNRyTyDjNA539PLcl7HONzc6Ge7o8WfwdCmUsUfrOx0Yja P9jWf8ptuhvdndT7u0Jk3N68vyAWDEE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HoGLKZMH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670535167; a=rsa-sha256; cv=none; b=b9pmzDD/KzFsU0LtNfi0+boFl1QIMBlKnqWzt5Fc8KQQQMq4XKLQQcJ4bsBDWdigmQY8a7 N8QUFowRlP8bjd8PjRvsKCQzrCJqO5+/SAn0m5GlGjrT2SsmZDjI5v5yIy1O2J/yH0Q0/e n7CgzSJ9x3wYgqQLDA3U1v+yDTtTA0E= Received: by mail-pg1-f175.google.com with SMTP id 142so2228171pga.1 for ; Thu, 08 Dec 2022 13:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+TrQiFZlVHCDTQZCh8d0lNxTCa2DqXYRVLa5t6bBFo4=; b=HoGLKZMHw915NF5vqn7lXXRKSXbZ1SPCMMapkTLnUmxiXPa7OuhV6wJjen2dNpuBB9 kSmJN6yLnBh8zJnIOmyf9cW3UehPdl84indT46fiDhl/boDQEOAR4T1CqhthfV0JRk+A TRM2ZcEpi+aDQXUw5lceStPgq4Ott6/LOdkFN3kBz26KL5IdqHNI8JyxOa8miefCSQVC KvtXbAUET8S3spLckG3ejH+N+iSWyvvCykclszNnMhVgJETG5s7V7kduWqPubfnyCX0G nvZ7C6FcRtJZhGdRxnjk5zBk0l/riQ2e+wRVnu7GaXTEGkUUeh1sgsokZRdrD7unngSe jZJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+TrQiFZlVHCDTQZCh8d0lNxTCa2DqXYRVLa5t6bBFo4=; b=Dw4qm6r2HgOr2gbVOicuwEgLpDm+V6QZFdWRaqQESDEHaJLkb79jb8Y99KgsD+tSjV TD/Gy8Mryr4fLdhp+BSewQZerY8Uy8A6rFwQAwQ05qdO95DbwldX0NdrY0kdPgK3VBLv RZMY9yQfBFLCckooGiL7wcwFzvw19YDi1QTK1DD6VNc/ZB0utwuq6h33etAwPDKGHwqy xG2Afym2v1p4fI6+1uaA9GaB9FsvVghzZfQYPV0kLKvlL9lvDK8/HyBoJ5SJ0b1eCXOD g8XVbxpd53P6OWrJ6FPo5GYkPvyZGEl/yW6qV+yGGQjVfW69fGpmwopiqNquW4G+PaWY +0VA== X-Gm-Message-State: ANoB5pkpepPbCJGe+Bw/0ibsmTa0M0ioiw7C4wosfjtjwnJhIN9wBcND ApW3gJeo8g8sVYPQuhXo1Ag= X-Google-Smtp-Source: AA0mqf7M6QgtFTdNPWkN/TG+ZEgfifAkZcyXsSnNeA+4G+mvo23tR2sS09f4X9rcsRqBwgsLQAsELg== X-Received: by 2002:a62:ee14:0:b0:566:900d:6073 with SMTP id e20-20020a62ee14000000b00566900d6073mr2758766pfi.24.1670535166649; Thu, 08 Dec 2022 13:32:46 -0800 (PST) Received: from fedora ([2601:644:8002:1c20::2c6b]) by smtp.gmail.com with ESMTPSA id 21-20020a621715000000b005609d3d3008sm16239132pfx.171.2022.12.08.13.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 13:32:46 -0800 (PST) Date: Thu, 8 Dec 2022 13:32:43 -0800 From: Vishal Moola To: Kefeng Wang Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: swap: Convert mark_page_lazyfree() to mark_folio_lazyfree() Message-ID: References: <20221207023431.151008-1-wangkefeng.wang@huawei.com> <20221207023431.151008-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207023431.151008-2-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CA669140003 X-Stat-Signature: wk64eaykx9458ejjupc4ociicff3iqad X-HE-Tag: 1670535167-341153 X-HE-Meta: U2FsdGVkX1/WRyeKKi7l7FEsXPDMTllcYnHvsflqld/PP/pqPdUFlyp3gk4QGIDZEUcHsGTNGYsLIVZkhV9p37Fv/IzWTi/EvwKHoTW9saCC9Quwx1ISXwafR5bZxAlD/GPIchcv0T6g8JZMnXvSHP97HbCp4UlmriWW03TC7ir4BTI4ZlCRNIguIafeqTqOLOO+/arTycK+F1CHMmVQMEHuXlxt3kGfFk5rpbb3lZ5APr7m8uB7CW7DmI9EPdbP3XXSobOL7w8+D7ra1My7HwExpob50hOv2FL453BJBWYeQi/H5EPKF6idAFLVRLOFqSLdYRjzWgsfxjopAQrN9K6OfYOCzWbjjLD5TBu+Zk65nSUs5W/ZBEgIGEuEZXyCcz0FVtCu3tupfOfAntzOdhH6AHrHTGiOAo78/o23g/Iu/5cvd0uChFsfIWqVXnDDuN62pcylNJIBDx0rDZqZlYKNcU4r8SvB59D915bjfYovQN2iHKjx5/1Q/xjqQ+p46TqceTZpTDwYGErLYoDjwBoAFhqOALpobWykL5K3c4C4/Z4Wlx0q8llrD5OlAoNRs5ALKNQoRryKNNjjwoYxLPqLUS3YlyIjowTnJsWAntxQCIaljuO+Nhzb1spSQ4XKnuKopGqp1GdSg058yKmv9ic4vs3lj1dPmT3HyBXvFwWcpufov5XqOxT9MtOp7zLQWVtzHpRUP1/devPFh+2N+09gjWYe9WJIv4tnE46hVMOb8xAi0aUWTmfyQYaw9WYP/w3tLgXD7OlVHzoEmoa4Q8hcVmXvd50pU3oq4EYJPP6qMYTdjbO/1C9CF0OykR19DMPtOTWza/LUUzm6CfPqgr42Kx/r4fCvomQrMEaPH2T4KuNltLQ4FuPKjx7awrNrAeN4ss3AM8t6vv2JqKB9YozVEwWtCKaXLt+d+ItiTfUJIIKlRWo2gXPjDOHsZkFCrIGxCy2ZQxbB4iAwJTm KqDcAX2p 8FC+BF6z0lXXSYssQsnH3UbrxE1VA67nzHv4emVwByhQQmtNikn5RDlBnPEJCb0oPq3FadPM7oZb3PzhMlhIIodt1smevU4woegQeFJH7M5roaFyoFkk58qBJHosqoUXHbX2qAwDrSLBev/8IGYP88cpnTSF4jTJqWts/5M7nZcyF4Ww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.011309, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 07, 2022 at 10:34:31AM +0800, Kefeng Wang wrote: > @@ -402,7 +402,7 @@ extern void lru_add_drain_cpu(int cpu); > extern void lru_add_drain_cpu_zone(struct zone *zone); > extern void lru_add_drain_all(void); > extern void deactivate_page(struct page *page); > -extern void mark_page_lazyfree(struct page *page); > +extern void mark_folio_lazyfree(struct folio *folio); > extern void swap_setup(void); Can we rename this function to folio_mark_lazyfree() instead so it's more consistent with other the folio functions. Also I believe we can get rid of the 'extern' keyword.