From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED76BC001B2 for ; Thu, 8 Dec 2022 20:59:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82DD38E0003; Thu, 8 Dec 2022 15:59:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DE918E0001; Thu, 8 Dec 2022 15:59:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CCE68E0003; Thu, 8 Dec 2022 15:59:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 59CA18E0001 for ; Thu, 8 Dec 2022 15:59:11 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3979D1C661A for ; Thu, 8 Dec 2022 20:59:11 +0000 (UTC) X-FDA: 80220354102.03.6AEB5D4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id BE59980005 for ; Thu, 8 Dec 2022 20:59:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ugalxz2f; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670533149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jb9j7hoUMtJrjIlX4VkfqzP4vBPOAIAet/v5+Ib4wy0=; b=bs+W+q3PxSxFIe8Cuog9o6iqB1cWcAuRfA2LdJhTus7WX4MAs+VGd473ZWoxfHguongqDa LMwuC1ZTQW4p7ZJDLukMr7DFl7L/J1XneODO3IQpR6QFdXJDO5xajRpg/ejh7OKZ0X8byu PhBGrZX9V2L/IqN+ZXM0GnV6Mi78isU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ugalxz2f; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670533149; a=rsa-sha256; cv=none; b=mI+LIxnURRqWbI4/r+qV65+5OvxXisivIJPBiWOhO5kXpSc+DhdqWRTGDFsRjLMZKSqHK2 E3E76YdnQ9n/3iam3IV1fGkh+PBrGDL10TeHP49KeOe2Mj0ggXoPWuCVa/M1wOcsN/ZdAO vyiJ1ZsWypuJsD0Z8uI5fMakklWx1Yc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Jb9j7hoUMtJrjIlX4VkfqzP4vBPOAIAet/v5+Ib4wy0=; b=ugalxz2fQQ9utCCE5YX4aE1dVs aQGxLZglMEbkiuoNTITgIi4+UIR0kY5qALFNc4uxXI5OcRa6Lj4Mz2cy6nvmQZxk/Sh+0nRUYYQl+ 5A1bIZ4YMXVacWKJIKZ3lzkXKa1S85DxH30zvLAUMrQ7ew3sez9uWAfk2CWgWsN0AqrVcNbYP5+9Q a7a012ZZuNZ3aXTWoFW8CuGwgDn9WScQY0BbMlEFWjsvMNO1S+iOf8jbu+VBH+KsgvdBXkJrCJiFa j1hIe8I+XrWsNM6AfDBHYiH7+cKa36D53rM+Eg3r/l7eb5/FXObtWQe1EJXIspLnO0/WzJjXXN6/l rIDGsA2g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3NzA-007Jqa-4l; Thu, 08 Dec 2022 20:59:16 +0000 Date: Thu, 8 Dec 2022 20:59:16 +0000 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sj@kernel.org Subject: Re: [PATCH v3 4/4] mm/swap: Convert deactivate_page() to folio_deactivate() Message-ID: References: <20221208203503.20665-1-vishal.moola@gmail.com> <20221208203503.20665-5-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221208203503.20665-5-vishal.moola@gmail.com> X-Rspamd-Queue-Id: BE59980005 X-Stat-Signature: 18t377t11dwrg99mdiuimjtr3mp61ayf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1670533149-394824 X-HE-Meta: U2FsdGVkX18tBfU94e8nnBoksXxyD3Zg4Jxb79ijFW8Jx8m7CvO+uVFFBc7sJG37vpKxSnWJ2Xq21Q9PbK5Ps2kdvTzyT1m2Xe6uTJYQa+AgUWxT6hPaMZ2GZq06JfhMWB4F0bXJ2fZlEsPiteJ8/tJ8cJJTnN0EyJ7l9G+76Antof1N929wN5hRy2BZBLTdrH1OOF8JYjxMWE6DoZDV6DIijdSjrsQmxy9m7q+H6GTGTn75rFff99SrZmHyMTdbQ7k0U0Qm4eWr3F9GdTjWEVSMIgAQgCbjynTcZvzPVc9ur0/nM1HS9OPYucNVJm/1UFpA8MYdgJZzSQ2r+X6tdxoBlE4vRyTn/F1db0u7m/kFIi72jxlDIaJ9xlocpca/mb4Na/OoqqMxNlksHX7yhBN+vleBUAxauvnV6HyGEcgF3qeMMdMl2R1yDXREFjxDOukFjyRBJSBvzJwtffPaEikM6XG93hvfRF0NnFGHpP53obkADVnR1CAjh8hvdNVi/4IHuuIoQpWniz5s9vsnCoFSgUh0ckTXK/9SHCjNeDkZweb0Fs6QuoJxtDu5Xj+WCeH+8z95kdLZWasQwbExcdsqdoipfs9are8WP5W1RBQX+p+D5LSaZnzS3LqmboMcMuYs4OrZPBtizKBJSliCVeqG+tm/k73U+nY7AAGXaZASGxzWA/fN1quLeA8sJeiGxZn1yh82hZ6Yz7T/uVVLSZn9X9Wp5BJczr/BuO1N+7HLPRO70q/fZ9EdZeabEdzevQyBsgKBH7hq/bGZXc/y1SqEh4W3J9GdnWen4CYeiJ7AGOB8qKmyw91jmP0PEwW4ydK1dYBrvv27S2pZ1u05fdLxjnLsKa4MS60laHgPrgy/Zp/8C1sTfXWKf6amvCV89mI3io6o9OOUaRWP7UwjzPLkVmhhhR/fe3zmbu1epOL+NJ2c6Y2w1q/Ddy+WAf6mGf6YKvEqaULEwFpprQR PVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 08, 2022 at 12:35:03PM -0800, Vishal Moola (Oracle) wrote: > Deactivate_page() has already been converted to use folios, this change > converts it to take in a folio argument instead of calling page_folio(). > It also renames the function folio_deactivate() to be more consistent > with other folio functions. > > Signed-off-by: Vishal Moola (Oracle) Reviewed-by: Matthew Wilcox (Oracle) (for future series like this, it's slightly fewer changes to introduce folio_deactivate() first and change deactivate_page() to be a wrapper. Then patches 2 & 3 in this series can just be converted straight to folio_deactivate() instead of being changed twice. wouldn't ask you to redo the patch series at this point, but next time ...)