From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EF0C4332F for ; Thu, 8 Dec 2022 20:47:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CB4C8E0003; Thu, 8 Dec 2022 15:47:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37C1E8E0001; Thu, 8 Dec 2022 15:47:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2420F8E0003; Thu, 8 Dec 2022 15:47:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 16D438E0001 for ; Thu, 8 Dec 2022 15:47:33 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E44CB4068E for ; Thu, 8 Dec 2022 20:47:32 +0000 (UTC) X-FDA: 80220324744.28.A945420 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id C28C5160016 for ; Thu, 8 Dec 2022 20:47:30 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e1ymvY1a; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670532451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n2IaWo/ElxMU4U0hZAO6Xw6wjYlafg6eLVU3ehWaqxQ=; b=Wt4n0xln+NqLv5Hsrks+15IyAaiDNMC+hTOaGY47BCoFnnQOhPtGoWBTlgRTxktypUQVq0 sTC835Y3QSr9D2rKStMDrAJsAPPWA/P0CUM3CDLsS77jEUfGayj+nuEr5YSbnPwfw8XbQ8 cQFqTJbtGt0q8L+EAsEadNbzHPdY2DA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e1ymvY1a; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670532451; a=rsa-sha256; cv=none; b=uYdBg+IkLOuOuI2uGdbmwAmx3V9lnya7S3HJV8ekMgeKarXNNckb/QMnZt5mgXbOE01LzY iF+QpdyZ826I9Esd/u2hAQ1bbQluI0f9C5L/HnhgleFuX3mkbv03n+mlmqcXsQhbOCmo75 hF7I5xLqW3cbIGjCrFvyfCV2e888qFk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670532450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n2IaWo/ElxMU4U0hZAO6Xw6wjYlafg6eLVU3ehWaqxQ=; b=e1ymvY1ahmrxbEaNnUpo4lyg5iyIl054T9vxB1zk02LywXzS1WRGFn1v3E6zl/1B151nUP rXXi/tjSeVwH5bKR2Um57qWS76wE+Uey/gePpQCv3Iv9aj7TDwPTkbnCdO9tVIYkHfDhjK GUU8KSWnfC0WXEyztOOTUTfALD4M8d8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-373-wP-yvKlKPgSRzRP63oGg5Q-1; Thu, 08 Dec 2022 15:47:29 -0500 X-MC-Unique: wP-yvKlKPgSRzRP63oGg5Q-1 Received: by mail-qv1-f71.google.com with SMTP id oo9-20020a056214450900b004cfdcb99fa5so211682qvb.13 for ; Thu, 08 Dec 2022 12:47:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n2IaWo/ElxMU4U0hZAO6Xw6wjYlafg6eLVU3ehWaqxQ=; b=LBjiYHK3n6xVrLglus3k3AriiSxTDe2kGj/vyOmFDLq6RTnKZScwteCqPZ+VT05LDT Bkj7oZe1kPDwgRIcT09GOx7LqFWcrndw7LRSBPlR2zX1RiGJ6Ja93gcOOdD9MVRCPNzj Yt8bytgQz+KjKFeReHTztroPf/tI0S66ybEzHle/OMeOfnNIor6hh4/TTp5eVxufVaKh DCcPY3LxPtRdKN+I6ryXF52K8vq/tj9TkSGj4TjUVTQxm5D94Q0UlJzDBA1yGyt+VoTY eWuse468Sw4L9yfgcpdBthNw+UvYascO3hSczSyWEH4ypxT7zgn+QUi/b1ZAn5iwyYQ4 fNzw== X-Gm-Message-State: ANoB5pmcL1mWuBuhE7CtBuNqbxcoZdGGN7WzIRlnVF6ro11Xz5Mn/wUd AK+0hRG/CaQUgiwrPoDqGWdFGV/FdZX/y4obs1pvONEymRH/osqyFovMBFaE0kVhHJeljqO533+ SRq3XVQokzbE= X-Received: by 2002:ac8:5347:0:b0:3a6:8be4:b0b1 with SMTP id d7-20020ac85347000000b003a68be4b0b1mr4346633qto.33.1670532448350; Thu, 08 Dec 2022 12:47:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf76qx0fTDXNDecqcepM9jyXl4zuHN/DRq9/4bEhX31vPTvcUzwXEWh3/CDlV8qnyDBkqmKdnQ== X-Received: by 2002:ac8:5347:0:b0:3a6:8be4:b0b1 with SMTP id d7-20020ac85347000000b003a68be4b0b1mr4346610qto.33.1670532448017; Thu, 08 Dec 2022 12:47:28 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id x13-20020ac86b4d000000b0035badb499c7sm15469372qts.21.2022.12.08.12.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 12:47:27 -0800 (PST) Date: Thu, 8 Dec 2022 15:47:26 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , John Hubbard , Andrea Arcangeli , James Houghton , Jann Horn , Rik van Riel , Miaohe Lin , Andrew Morton , Mike Kravetz , Nadav Amit Subject: Re: [PATCH v2 08/10] mm/hugetlb: Make walk_hugetlb_range() safe to pmd unshare Message-ID: References: <20221207203034.650899-1-peterx@redhat.com> <20221207203034.650899-9-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: C28C5160016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 8onsho8oxx166m33d4zjwxiu5iqc9fw5 X-HE-Tag: 1670532450-844776 X-HE-Meta: U2FsdGVkX1+urfH+bXR21rgsb/Yqc8LQzjN+AMvjsg+e8R6b0EIclGPhUOflBkP8tFO4odd9pFvHRCMAprH8J1YpuxLSq4tJD8E/bPRJLdvQSKDx9Gj8ickWYPU5bizMhxnmZ4wlILgwARQd8NXNnucCnpNyR23HTz8FOKrQZH/GCTipZIqKTS6EHcGTcZRz5Cl9fGXZ3LaKmbAeHWu1vmy3a080UVVpC/Sb4163WUC792Oq84tU8/z11lOpoCIQM7QM9hVz4givbiAjgJnu2MiehnLVi6DLGGP3zox3w1MY9cwXwCj1yLVEg0VtITy5QswIW1PRGWR3cXOL3BnWEvvwaSGyhVrkvCiBMcfbxAKHsNX5r3XPxgf09F2J9BYkH6DKEcWn+fuvznLWjuHiXI6OTvi76fKsrZj5yqUMwHz5reEkGzLE2ioESdp8HxHYEbSpWgCUzaRVYOslEhBIRaffZ7V65KcvA4in+EeBj1Zy8TvnwGZpukwW86w3c/DKzEJObUqlOrfuHZcOYgmBFqBnn98Vv54sqk1f49t5HLdF61HwW8wOdAt/AjVfVHEHl8DPg03nziUpy3al7de/jOEbVP6oc3zIBBLr1Ptj7Xf2OjTsbLS/U9lr5bVEGY8aRCBH3sYqZB06LRCqDffcytjhl95wBHtb6SoHkmXEnA3jRGOr8luTXWQi6NrlzC8yV9NjnasoSCWTNQaD3rwNde6S3oe4plPNbNRhAm8uNWASBMeNes4cSOT/nem9WUuDJ8VqLGZGuykPCGKRpnweAtYUETybNuaKOCb+12UZxVCR94FBtV1h1s2kRyVdBvWKwRlnqYZgYWPlwa+AnBdQ2yH2wkNJXMFfazxdxCjDX1NnnM51YqQcJDswOsa+wi3o41/9AwWwNrj6wAbjJyVOVMY3b5b7G5Pn9modme0ARPm+jDPjm2DEPqBAUK6NAnYBpIMhpXyV8Atl1huiVRR 7MKPYiYZ a+Lv4+YmKkLPR4TT3lbbhS6eosU3Q8Qen3HLPN3kp0BMg+INb/x4k9/CV1rl0nxstS56cqw9IF5Op477Jd5QNT/vujM+Zh8RJ1PaAik9sqwu7Nsa5812ZTWOunhuamWZ6YlLTVWt7YUaHbS1chwhd76u2N8+c4yUopl/YzQP24vfdtjYl9HBjqsIC2H18txnTwDzJWGeh/2crswVYP6tfVE0CGm9xCwxd0oAA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 08, 2022 at 02:14:42PM +0100, David Hildenbrand wrote: > On 07.12.22 21:30, Peter Xu wrote: > > Since walk_hugetlb_range() walks the pgtable, it needs the vma lock > > to make sure the pgtable page will not be freed concurrently. > > > > Reviewed-by: Mike Kravetz > > Signed-off-by: Peter Xu > > --- > > arch/s390/mm/gmap.c | 2 ++ > > fs/proc/task_mmu.c | 2 ++ > > include/linux/pagewalk.h | 11 ++++++++++- > > mm/hmm.c | 15 ++++++++++++++- > > mm/pagewalk.c | 2 ++ > > 5 files changed, 30 insertions(+), 2 deletions(-) > > > > diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c > > index 8947451ae021..292a54c490d4 100644 > > --- a/arch/s390/mm/gmap.c > > +++ b/arch/s390/mm/gmap.c > > @@ -2643,7 +2643,9 @@ static int __s390_enable_skey_hugetlb(pte_t *pte, unsigned long addr, > > end = start + HPAGE_SIZE - 1; > > __storage_key_init_range(start, end); > > set_bit(PG_arch_1, &page->flags); > > + hugetlb_vma_unlock_read(walk->vma); > > cond_resched(); > > + hugetlb_vma_lock_read(walk->vma); > > return 0; > > } > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index e35a0398db63..cf3887fb2905 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -1613,7 +1613,9 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask, > > frame++; > > } > > + hugetlb_vma_unlock_read(walk->vma); > > cond_resched(); > > + hugetlb_vma_lock_read(walk->vma); > > We already hold the mmap_lock and reschedule. Even without the > cond_resched() we might happily reschedule on a preemptive kernel. So I'm > not sure if this optimization is strictly required or even helpful in > practice here. It's just low hanging fruit if we need that complexity anyway. That's also why I didn't do that for v1 (where I missed hmm special case, though..), but I think since we'll need that anyway, we'd better release the vma lock if we can easily do so. mmap_lock is just more special because it needs more work in the caller to release (e.g. vma invalidations). Otherwise I'm happy dropping that too. > > In the worst case, concurrent unsharing would have to wait. > For example, s390_enable_skey() is called at most once for a VM, for most > VMs it gets never even called. > > Or am I missing something important? Nothing important. I just don't see why we need to strictly follow the same release rule of mmap_lock here when talking about vma lock. In short - if we can drop a lock earlier before sleep, why not? I tend to just keep it as-is, but let me know if you have further thoughts or concerns. -- Peter Xu