From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A00C001B2 for ; Thu, 8 Dec 2022 20:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12A108E0005; Thu, 8 Dec 2022 15:06:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DA548E0001; Thu, 8 Dec 2022 15:06:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E96728E0005; Thu, 8 Dec 2022 15:06:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DC2398E0001 for ; Thu, 8 Dec 2022 15:06:12 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 99D7640FB0 for ; Thu, 8 Dec 2022 20:06:12 +0000 (UTC) X-FDA: 80220220584.15.2D5C5C8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 6D5311C001E for ; Thu, 8 Dec 2022 20:06:10 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XVRdGacq; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670529970; a=rsa-sha256; cv=none; b=Z+Lhfny88Az5e65Pkd398ezhTUuqrUEZZ1qtR9ElD52reuev+3CXDZzsHUmNlwLtUCxRCs 19pbEA3Dr8SM+vWfGD+RARMBZmE2NIijUB1TaqB9cUguRHhLvG7H30qr2BwRYMxttho0vF /3ROvS7+WYR2Od9y4Ll1GZQhmGf71q8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XVRdGacq; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670529970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aO91Cy3aiM72NJuvUVHnXgYZwK+vF7vmwZ76fFMKBJA=; b=MenXlL+hSLecgQ/FYct1+k2CkB7FpZezBELr5XmoeitBsupT1TfdtY0I/Z12IqbEIZBSya g47sovfYmye92MAHQotLcYxAgIld5R+Dm4uDW6d10mXekJg+tj8Zj9bUOf62NMr3NvnN2r 5G0SUunRHgVml9pMMAq5OS7sf5+K/IA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670529969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aO91Cy3aiM72NJuvUVHnXgYZwK+vF7vmwZ76fFMKBJA=; b=XVRdGacq5xYBE6LeU8GfdgL7RucRbRTnCPfntAG2+UGLv6/9YdVJoDbh1BnR4x4EZQgmMQ D0s4Mf3KwTbIGGsVzfwRu6bw7VG+Yv3JSQAZ/nSApOVbOGj3UVOl1YnEEMyCxHSZ+wtgpj 0ZpSzShRlbaUfp4bo21ZIL6d+B/FYWs= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-619-QqrtJ9azPwOL-SMEHcMUSA-1; Thu, 08 Dec 2022 15:06:08 -0500 X-MC-Unique: QqrtJ9azPwOL-SMEHcMUSA-1 Received: by mail-yb1-f197.google.com with SMTP id i10-20020a25f20a000000b006ea4f43c0ddso2625282ybe.21 for ; Thu, 08 Dec 2022 12:06:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aO91Cy3aiM72NJuvUVHnXgYZwK+vF7vmwZ76fFMKBJA=; b=hrgIfH9IOJaJMh5Vm4Cu650MazzrqvuWldWcQteRjOt9kJLal4LT5R/THNSC11o8gz Gk2FSs1xy73I2++s9RuEOX37Mljclf57RA+Z1WVmbYqb6aeo6RE+c2H/1DCl8T2CSIh3 v86cAjgfbJ0T/pYDqE2yaG4VNGgo0XqwLfwypG+Ns9rfw1X309cbZ5mvEgt8rVrNap6z rwUqJl0vBEGj9WoAON72kZY80a5ZMBDb6AcVJJ5M3f8EyoafT0071bguGvzEl8L5zB/6 GtaoYUq1tOz9R+j09Tor1Az9BjJ4wAhV3n+WK6M5Of6gcXK4otWgaFXuW/qLeA9mtY9a SQCA== X-Gm-Message-State: ANoB5pn1fAXoIyg6Z8L5PUKLvtGXiNhJUaiEfWIJ13Oj/4ihGGS4/uoT DpcZDPoq+N6aWSGz5r2lUxFQoGbvjS5c+kHLKiSL30wCR8oiMF6l2TRHBZKGlrhS+O2lOylLXCi 1x7RSSvNciA0= X-Received: by 2002:a25:2314:0:b0:714:e101:8548 with SMTP id j20-20020a252314000000b00714e1018548mr1353390ybj.58.1670529968073; Thu, 08 Dec 2022 12:06:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf6rgZb0VkMbKMAwlRjV5wDNe3+42qmtQQXCtPakXyJ8UHqzCz/Y5cKAOu9FJotIYvo1ZV0gPA== X-Received: by 2002:a25:2314:0:b0:714:e101:8548 with SMTP id j20-20020a252314000000b00714e1018548mr1353366ybj.58.1670529967829; Thu, 08 Dec 2022 12:06:07 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id q13-20020a05620a0d8d00b006fab416015csm20082249qkl.25.2022.12.08.12.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 12:06:07 -0800 (PST) Date: Thu, 8 Dec 2022 15:06:06 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ives van Hoorne , stable@vger.kernel.org, Andrew Morton , Hugh Dickins , Alistair Popple , Mike Rapoport , Nadav Amit , Andrea Arcangeli Subject: Re: [PATCH v1] mm/userfaultfd: enable writenotify while userfaultfd-wp is enabled for a VMA Message-ID: References: <20221208114137.35035-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 6D5311C001E X-Rspamd-Server: rspam01 X-Stat-Signature: q7xra998u9469unxss5o79asizwha1f6 X-HE-Tag: 1670529970-716003 X-HE-Meta: U2FsdGVkX1+92ufY6GHErr0cFV1jHOH4RIIKkqqwH7N0pu2519g3Eg26jLv5uU7i2bsPgOaQ/pT03Yrg5fTwsW+QRodqCZYtnD5p5rzQYoLA5qcC7/F9H7GRL5oc0EvVnkFL4R4XdyVnEDHF0Osn2xiP0XMLAdFIlU/I7iGd8fUY6jdVrGnad3Wpxp8f5p2ZPjruqCY8lUOxut2KDseQ6Almi9oYCj5PPTf8Ux0eq8uEC3QLXxe8DSTamFEY0PSNSVW4PTWDpV/9SiLgej7qpaX7xSn9Q7umhrU1xOjtSHYPhfmZ4c3BoKNzHoutRvon3HArv0DTHFGcwindNmOP4BGYOJJAwKYomRzsL4o/ocWxUkLMpRZyyaiJUODHTbeiHA3Nq1OtxySFndKuaS8r9WPUpNud0AeL6ZcupE+lXucMOY0hXO2TUbMotzkSzJMU2HBHJIRGO5gNy/S341tERIGxWsBEBgJwcNMxBU7fWhXGt7mFO46/aZF+M3p3gsxjuM2wT736E496Tt/+nemCCTZMYbSkunJsiRMagnWEQ4sJykoa04w3GU/+usa9ZGmwNOYa0vC3NQaRlHJSYTQ9Ovigu7zt/w26GKR1Jq49A9xwP+v31CX/3wdYUbZ0+JhYbVN8oj2btdI/v+xPQoJlREquC/hjn5mmq6zRVQ9kBgHEieVQOiYGrf9Ahv06hgJzFJ9OqR93FzCSLFyB0NHMAGDkC0wEsbjD6ywqujzMJo11ULCxSqTF1CrBqlYX90TShw9pc87FQhQguY18U9lyhD04j7d2Kmi8dcSZ2IyJStQ4m6HKxeqZVVhSChhLhph5Km9srSX1Bpf5b9nI5IzT9Z+29wUjKm5cvICavrbLvjAoJZlpqF204SsQQ+lEDIFrnVUKiRtkfwnrwt2I+cyCkDycVO8+g9x97jyoziPsZ5vuI2iuXye9T3yG2+vOT33pePcbLobdqNaz7rpXJBO HKesFk1g hWCHpVZexcKmzk15ikDVr/nIj0QshuCfvaiYkXgMCCaPKibjse6Qeia/w6HG+nQyH+gL4hFiwNEGmXIww1Fec2an9XqqkKTCa0UxFW8WmX0Ig0wscVTTd3kb/c0OWEocSuyx/ba4Y0X3Q17MpQcj4i39OeVhPGotua6Pf4joj8AHn2oM3eHEVvTELHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 08, 2022 at 05:44:35PM +0100, David Hildenbrand wrote: > I'll wait for some more (+retest) before I resend tomorrow. One more thing just to double check: It's 6a56ccbcf6c6 ("mm/autonuma: use can_change_(pte|pmd)_writable() to replace savedwrite", 2022-11-30) that just started to break uffd-wp on numa, am I right? With the old code, pte_modify() will persist uffd-wp bit, afaict, and we used to do savedwrite for numa hints. That all look correct to me until the savedwrite removal patchset with/without vm_page_prot changes. If that's the case, we'd better also mention that in the commit message and has another Fixes: for that one to be clear. -- Peter Xu