From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B7ACC4332F for ; Thu, 8 Dec 2022 19:09:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA2338E000F; Thu, 8 Dec 2022 14:09:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A526B8E0001; Thu, 8 Dec 2022 14:09:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 941228E000F; Thu, 8 Dec 2022 14:09:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 83F558E0001 for ; Thu, 8 Dec 2022 14:09:09 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 43F661C6712 for ; Thu, 8 Dec 2022 19:09:09 +0000 (UTC) X-FDA: 80220076818.26.53EBD41 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 93E0EC000F for ; Thu, 8 Dec 2022 19:09:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OizC4Mlp; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670526547; a=rsa-sha256; cv=none; b=SEkJ+hcuhL8JKhyMFtQUx3p2g/5j8mcJ7OKcJoJ0sZroHsw+OAy1hcBjjDjCRrk17ZYNPE BrsTx/BGUeNqyM/2MIh0zHa1mS+BnzdICIczFJ16B/XP/RgFOlpi2AZ8cLJpy4ncLeGwxE gn6n916CGUz8MuxssalV+THwJup0cKY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OizC4Mlp; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670526547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0BpgFcTykCUCdNZRtCyOHoFGbH5EWy6ZB0yXQQsP7Ic=; b=WepWHczY3/cjRR/R8W27scGPCcXrVtD/4e/RfGHSoJpRDQ+WjeYClqdu/iPxrywlaGs1Wp LFQDg7/Hm7Im7/6v4JqRYkJnQXAW/v3DC68QZdnsVlD09Ki2HC5LKqso8w6SvgFhUJQ3UX YUTOhGNsm5+gzbDsbeNotvPb5f71YMc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0BpgFcTykCUCdNZRtCyOHoFGbH5EWy6ZB0yXQQsP7Ic=; b=OizC4MlpzR1c9dp0FY5822u9OF rFkKvAgpEo31ALaS+ERQtjvTkTiSxS8d8Ub7gTgyY2RWqcYeHiDnz2xE83b6N/p4oyezjrb0cEATV X+JaX6SN7ZsDNpeKDlNtJI3XisP8L1yEuAPUCtAMlDnRrHBaC2FGeJ1Y2oH5NMJ6lR5CT6IF7Dmuu h44a7RzR0JOVWzwnljif3iKDT78hpcMgsyEP3AsKx0FlTJtPdKcDQoUN2wIt/C3TFKOGmJKbUE4zy BRiILkwLPxJnCYBsWx2E8/2ROLC8AYV9P2M0E8ODvwajIhlyk81AfMOhpGAld9+/sLkkyy5VGK5JO QtgckbEA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3MGM-007ERl-AY; Thu, 08 Dec 2022 19:08:54 +0000 Date: Thu, 8 Dec 2022 19:08:54 +0000 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Miaohe Lin , David Hildenbrand , "Huang, Ying" , Hugh Dickins Subject: Re: [PATCH 3/5] swap: fold swap_ra_clamp_pfn into swap_ra_info Message-ID: References: <20221208180209.50845-1-ryncsn@gmail.com> <20221208180209.50845-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221208180209.50845-4-ryncsn@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 93E0EC000F X-Stat-Signature: 9bmk4fz3c4g17s7rzbwm3wtgzxfjhrpg X-HE-Tag: 1670526546-855630 X-HE-Meta: U2FsdGVkX1+ov9LEekaItba3McuN8ISyl1HTVnp00dPo2RSB33nslZD+6yvTNLEQdqdBnHmgQOdshj3FQfr4rr/tYmo7+qO0d/zSCCCLDP130ntqCN10g49iB2okJEsEz6gFO5ywnzY3yxlhRuAr390uXrMHdTalYV2exzbSmmlj+4vGrXey59N0wuDIDRLIHz3yV7LzXiUW+ccgtgbg9SWiNv5Wtnl1V/BuFKT98yp9pSaZTJCd/ra5/Yxk9BcOpNp0MQhAR2YZ/nLDtuFCgwWem1mtI4vzwcuHJvtrPlqcX4Mc6GMeUPyHNnV9Gzm/wb0xspB8vtEF3pOSf+sxPuRcPZKi7GO1r4PO0WjaGR3AKUCGCUAQwD9I9HJmYuCUxUZCVAS6DPnex/mVwoff0SPYlbV6hldVWKahsPlMEaR9gkJTap8CzTOgd/ntplk9GdeQBUXpw13qPLojLLfJv4LQD82VSItNDE08Rfddt2RJCkGyu2ksr8ln52P4Rq5eM4n4oEULkvYnadW+euO5P65wF4ygLYzXBKvoA2ayFPag1uUTRhcOUQg00mz8yqXZVXrA+EYbbO+u3P3Sd/oeEDBwdhvPjudrxeMSFQdixWdyP6Y4mMS1VyD+bsekueuPsB8jDQTPt9p0dhps20xmSIiITXBvCuqy1YUEQ3w/oGK3sv9p577SFY8XBXy+j9rXWgCaExtnKjXo9rSKJJ5KRYGML8dxwH4gMkoUlSskG8Q+5ZvSxCFLU5D2xpb7P8ZRUwyYuSaFoouRp8mqwxyiWG0Ek+9m4m7D3PJUtKo4609SLT/TXVj9WPABsuKCQ/MYWuWJ9b/kd29KsmuAhHjjsXRlhNhLHOnNwUhljkE+rjBRJDE7A5edp3/vZkVykp0scO4QT+F2GOPMwwpm3oNwig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 09, 2022 at 02:02:07AM +0800, Kairui Song wrote: > From: Kairui Song > > This make the code cleaner. This helper is made of only two line of > self explanational code and not reused anywhere else. > > And this actually make the compiled object smaller by a bit: > > text data bss dec hex filename > Before: 9502 976 12 10490 28fa mm/swap_state.o > After: 9470 976 12 10458 28da mm/swap_state.o FYI, you can use scripts/bloat-o-meter to get a slightly more useful analysis of object code changes.