Re: [linux-next:master 11969/13282] drivers/net/thunderbolt.c:733:47: sparse: sparse: restricted __le32 degrades to integer

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, Dec 08, 2022 at 03:04:52PM +0800, Chen, Rong A wrote:
> On 12/6/2022 11:07 PM, Andy Shevchenko wrote:
> > On Tue, Dec 06, 2022 at 02:40:16PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   5d562c48a21eeb029a8fd3f18e1b31fd83660474
> > > commit: a479f9264bddfd0c266615b83f784222eccf9b91 [11969/13282] net: thunderbolt: Use bitwise types in the struct thunderbolt_ip_frame_header
> > > config: openrisc-randconfig-s041-20221205
> > > compiler: or1k-linux-gcc (GCC) 12.1.0
> > > reproduce:
> > >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >          chmod +x ~/bin/make.cross
> > >          # apt-get install sparse
> > >          # sparse version: v0.6.4-39-gce1a6720-dirty
> > >          # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a479f9264bddfd0c266615b83f784222eccf9b91
> > >          git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > >          git fetch --no-tags linux-next master
> > >          git checkout a479f9264bddfd0c266615b83f784222eccf9b91
> > >          # save the config file
> > >          mkdir build_dir && cp config build_dir/.config
> > >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/ drivers/nvme/target/
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > 
> > Yes, it's expected. The change flip-flopped the warnings. As a result the
> > amount of warnings has been reduced from 17 to 9.
> 
> Hi Andy,
> 
> Sorry for the inconvenience, we'll add it to our ignore list.

Ideally you should have compared the warnings before and after the change and
tell something like warnings number dropped or increased to N (arbitrary
number, should be real one based on the parser's output) and leave new warnings
to be produced.

> > (wsum warning is not counted in the above statistics)

And this warning is still in place, so it shouldn't be reflected in the
statistics.

> > > sparse warnings: (new ones prefixed by >>)
> > > > > drivers/net/thunderbolt.c:733:47: sparse: sparse: restricted __le32 degrades to integer
> > > > > drivers/net/thunderbolt.c:741:47: sparse: sparse: restricted __le16 degrades to integer
> > >     drivers/net/thunderbolt.c:742:44: sparse: sparse: restricted __le16 degrades to integer
> > > > > drivers/net/thunderbolt.c:838:40: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le32 [usertype] frame_size @@     got unsigned int [assigned] [usertype] frame_size @@
> > >     drivers/net/thunderbolt.c:838:40: sparse:     expected restricted __le32 [usertype] frame_size
> > >     drivers/net/thunderbolt.c:838:40: sparse:     got unsigned int [assigned] [usertype] frame_size
> > > > > drivers/net/thunderbolt.c:839:41: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le32 [usertype] frame_count @@     got unsigned int [usertype] @@
> > >     drivers/net/thunderbolt.c:839:41: sparse:     expected restricted __le32 [usertype] frame_count
> > >     drivers/net/thunderbolt.c:839:41: sparse:     got unsigned int [usertype]
> > > > > drivers/net/thunderbolt.c:840:41: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] frame_index @@     got unsigned short [usertype] @@
> > >     drivers/net/thunderbolt.c:840:41: sparse:     expected restricted __le16 [usertype] frame_index
> > >     drivers/net/thunderbolt.c:840:41: sparse:     got unsigned short [usertype]
> > > > > drivers/net/thunderbolt.c:841:38: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] frame_id @@     got unsigned short [usertype] @@
> > >     drivers/net/thunderbolt.c:841:38: sparse:     expected restricted __le16 [usertype] frame_id
> > >     drivers/net/thunderbolt.c:841:38: sparse:     got unsigned short [usertype]
> > >     drivers/net/thunderbolt.c:842:62: sparse: sparse: restricted __le32 degrades to integer
> > >     drivers/net/thunderbolt.c:842:35: sparse: sparse: restricted __le16 degrades to integer
> > >     drivers/net/thunderbolt.c:953:23: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted __wsum [usertype] wsum @@     got restricted __be32 [usertype] @@
> > >     drivers/net/thunderbolt.c:953:23: sparse:     expected restricted __wsum [usertype] wsum
> > >     drivers/net/thunderbolt.c:953:23: sparse:     got restricted __be32 [usertype]
> > 

-- 
With Best Regards,
Andy Shevchenko