From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7152C4708E for ; Thu, 8 Dec 2022 02:48:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 459958E0005; Wed, 7 Dec 2022 21:48:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40A2C8E0001; Wed, 7 Dec 2022 21:48:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F8438E0005; Wed, 7 Dec 2022 21:48:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1DA748E0001 for ; Wed, 7 Dec 2022 21:48:45 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D6EB6C0744 for ; Thu, 8 Dec 2022 02:48:44 +0000 (UTC) X-FDA: 80217606168.25.74391CC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 22C2F20005 for ; Thu, 8 Dec 2022 02:48:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PeTbLrft; spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670467723; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HZZV66Q510zOYrSZ8gvjocnRVxTk+78FBZKmi0gwUK4=; b=anYgFkuLj2spjpehNj4QqllXPA7ZKsS7xtezySUI/bYLtqv0Ho3H3dhzKdjTSpntANtPGX bn8IAWk4GK7PGjkTkRcMkixE6M5x/ifd+RdL19LoODs8yamV7Rr2kDiegHUewWUNVJVMud 4LUZ2NkYgnKi22goYerwwojiCM0bbH8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PeTbLrft; spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670467723; a=rsa-sha256; cv=none; b=qkdOA5Z5Uj8eq+KnrXU94CbM7DOyPLQ2leBwIjz9DMOmshe9NcTefBOg0Z0oa5+V2kgEMm YMq++/kmmjQeoZTTw3dTqFhPhWrSBMlUzHeZOYh31qKOgrriyBtdwJ48/CON6lQLVLFdje hnmNywPT1JZ8FNkH0oeXygFFWHrgKvA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HZZV66Q510zOYrSZ8gvjocnRVxTk+78FBZKmi0gwUK4=; b=PeTbLrft3SflFkZlDXqUlDKUXe KvD6z8Gk8Fl36p/CGgFytM/8xq9bmGtdgdWTYi4c1pKZPz2IDQm67VOUnW3ABOT6SJ/YDUvhYO00t +olq42xjfqjEG3mgBN9LBSDIGhNklM2UFF739diolakBqaacFuO7dPICD88ok8X1acbDf7FtarIuP IuQfO7Q+ONTu29L7tymXPo57yoUmBid//lalUDHYpEpzInOwRtjpxY3ispWr7BliDNujg5ZhwMKbu UkXGtbjDXwKxms4mTCWCqQfCXBfJwcmmcKuTgXwD4BKuyh8S43ZAjQ4uSlzhunnPdgXQMt3PTlYUu 4qIf84Fw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p36xf-000WUx-Kg; Thu, 08 Dec 2022 02:48:35 +0000 Date: Wed, 7 Dec 2022 18:48:35 -0800 From: Luis Chamberlain To: Song Liu Cc: Linus Torvalds , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, rppt@kernel.org, willy@infradead.org, dave@stgolabs.net, a.manzanares@samsung.com Subject: Re: [PATCH bpf-next v4 0/6] execmem_alloc for BPF programs Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: qh39qq3nza1fsqpqgm9o1nbrcddycrys X-Rspam-User: X-Rspamd-Queue-Id: 22C2F20005 X-Rspamd-Server: rspam06 X-HE-Tag: 1670467722-274850 X-HE-Meta: U2FsdGVkX1+08AwjG//mEuIfwmFlHUNJEfPMfBTOa5qA1j9RvyKHy3W5uPYYsk12vq+ljGGGBR+mtEnRKa3deVunL8xZsc1WMcEs3TiA1wOM9L1ORxsFX3WLLHGeQtw6HB2MfKbO/zmGOMKBqxW86UD6bGdBfzieJMWyRWeV5gRSfKikUoCHEdV2ftkEW6vllkYuhE9OtMzXf4qd2GUB3CPAPF/rNamFt8c7lEIJuMLN1ommgNvXt44xuetPH1pbruVxA+5gFnvPEJdT2Sfo2yiglpJqa0X8+4G7DlaL34eNpoX7kKoAcz9D8ylN9hdqZ2ok+B+2OV6r0mppbMd7doWT4vqleEgiij5i4+GJHZrpFmcXAbPalcXhCKNyX14QBYVRKMb7ft16xEGljxw9GqBNBVvtJU+a/5zvNFYGySiYJMM9+YO1VAO2DiMPFt7e+QSY5P106o5RSGlTj8HDbpl0pzQAhXbV8fr3O+TjIQO6FLJPktvvrDxI4HDhRpOfajJkcMNHrGBnv7CVVI3qTtczU3T+7FCcNUWMmRpdGpyjezfYMzkRaMfXAzQpN2x/PuiApgM/TLVKzaJ7NLT6vimKIdLteySJUx025rJxl/h4OZIs/exYEhmGJvCopEKOG/ZlQZmTtjGNfTqKT22TXyUkgR4Lz13XM5kaNb1MDwhhgsSk7XSuRHTJRhWAXUk2NbCXW3/kiQgFTikIBZFthEqCL1HRHaloahD4GGrueacuni0arLWx2zRguKFYuh5geIxgc4TQT5tuqtT7V2D16v1lzpjoQIO08PlBcHQtnWdMbQES7iL6h6LFuvOE6PrENiSeJbYHgTzV5f0rFER44ZbuuxnyzSeiefgYYPbTerEWunoE30cI8yfpw1uNiCTDD8hR4hNyNdllsvNMcoDxTpe5Nx3aD+v4dGmVYVti8VtZ1n78Nl6APqiZty/8SPA+TBVJ6x2SICE6zf+twxK rWPEI//9 D0nPuHCGQz3ljgQHkezM24Yj/txlNnVzP6hZ3QnpwqNbzCoMLMtYft+9f7JTRZJ1mLGVNiLWQ8R0+gWoZmRRY5hG4rkdGu3Q5uIbI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 07:36:21PM -0700, Song Liu wrote: > On Mon, Nov 21, 2022 at 1:20 PM Luis Chamberlain wrote: > > > > On Mon, Nov 21, 2022 at 12:12:49PM -0800, Luis Chamberlain wrote: > > > On Thu, Nov 17, 2022 at 12:23:16PM -0800, Song Liu wrote: > > > > Based on our experiments [5], we measured ~0.6% performance improvement > > > > from bpf_prog_pack. This patchset further boosts the improvement to ~0.8%. > > > > > > I'd prefer we leave out arbitrary performance data, as it does not help much. > > > > I'd like to clarify what I mean by this, as Linus has suggested before, you are > > missing the opportunity to present "actual numbers on real loads. (not > > some artificial benchmark)" > > > > [0] https://lkml.kernel.org/r/CAHk-=wiF1KnM1_paB3jCONR9Mh1D_RCsnXKBau1K7XLG-mwwTQ@mail.gmail.com > > Unless I made some serious mistakes, Linus' concern with performance was > addressed by the exact performance results above. [5] > > [5] https://lore.kernel.org/bpf/20220707223546.4124919-1-song@kernel.org/ AFAICT no, that still is all still artificial. Luis