From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 690E4C4708D for ; Wed, 7 Dec 2022 23:11:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06A3E8E0003; Wed, 7 Dec 2022 18:11:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 019F08E0001; Wed, 7 Dec 2022 18:11:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4B768E0003; Wed, 7 Dec 2022 18:11:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D20608E0001 for ; Wed, 7 Dec 2022 18:11:40 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 890441A0616 for ; Wed, 7 Dec 2022 23:11:40 +0000 (UTC) X-FDA: 80217059160.08.CD940A6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 1A6B2A0019 for ; Wed, 7 Dec 2022 23:11:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FydI6eJm; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670454699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3nhWzv5kOP+18jCYMyraj01yZ+JzMJWApOTFLI0bTRQ=; b=Ea8EW3PapsxTEa50/Eb9Vms6B1E5Gg8ryscO8L+s1C9ZcknqDrIDT+wzECgvxVcMjAaaar UNxRB57XCfXVD/pVjtBfLBBJ6VeL6M0ZgKE0bIgXGKn4p3bTMKb9NLnRDT4fggkQ50294b wLoVFXukpv76wWbfP4KNbS+AMGcWxdc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FydI6eJm; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670454699; a=rsa-sha256; cv=none; b=h3UyLeUpmvBL5jPHINRX7ErnfPfCYY4CeX1ABAIR1K8NVq1E9h9paj4VexMl6vmhPMzU5R qBfwgfMMWaT5P5hlO2f/8nfkkIQ9YzpljfxQU1woii7Rq0fmO5DWAbdHVwfLvGWMGqbM4F Tc+s2DTe0BjkBs9u4gF2zB7sugxK4dg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3nhWzv5kOP+18jCYMyraj01yZ+JzMJWApOTFLI0bTRQ=; b=FydI6eJmQWybADU8AzYClMtvWI SnV3+4iqHL0dfU3JsO4kIyiOIzhsBjCoIDcDB9ZU8kq+/6jqiV873YLqBv20a+QNvSp3gufk52pXJ n5hz2ZaCEa1kRf2XVtabRlFLisEWFTkg8ZQ4k5/a25kZd0ypoghg4ZyGkg6Oo51UpDIL+eRL7rCA0 FIDfahjK0fo9IWnsqv7tY6tEt0+/b4tJK2L9WR6L0pPmOKVdM7Bm/1ORVWMsYEZYTeruKLWswHKbN +MZJPOhdIoHKVATjNIopJBJtTCi0S/7moEs4YRGj02+5eHtVV5hXaW7Pt/oy1kO/k8eo2R/oHNJAG /wrO69pw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p33Zo-006IWy-KV; Wed, 07 Dec 2022 23:11:44 +0000 Date: Wed, 7 Dec 2022 23:11:44 +0000 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sj@kernel.org Subject: Re: [PATCH v2 3/3] mm/swap: Convert deactivate_page() to folio_deactivate() Message-ID: References: <20221207230152.22938-1-vishal.moola@gmail.com> <20221207230152.22938-4-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207230152.22938-4-vishal.moola@gmail.com> X-Rspamd-Queue-Id: 1A6B2A0019 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: arc9q6cfg8g41d6iu78c7opi9d8ziwmn X-HE-Tag: 1670454698-848032 X-HE-Meta: U2FsdGVkX19YIYFApntiGWlUuvsntA2+E2/wwhUCXPLPy+GJ0mG9jFcQy9QWYjKjqmKlb6FBzEC1QfjncT23nhMQZTTfljSAMjyECTMLWpj2Isx8ITyUwgePLnxw16+zQK0/b8ns1Gbj7cV/qHJ4hhHjdReNMmwBsD/4cS62zc30QXpZjT5S/BHHV0X2js6QDUpoFVak3Ah0+9TPpTvd/33AeCBzvop/eVrRd0zSQBPcrQWXArXlPxkhoV9DQIpVr27iKqdkJl+pTT8VwpJwwCNrz+oPMvCmFk3EmYDix8znOeZszbwZO+XkqitZ6i3mkhzvJnm1duieXmcyzPssyn04kyVlfnnT5yWKFe6mNptuyY4uCvtyAajZ/S8TYRRfzHg34j1td7/JkDM2/g1v9Wl+21BgRBWwdLiWS/l68QnMQBco1/Rhpgzk05+xrAK9bMZGXij4XTWNiMltvWnrL39vfaoUrS7I+Ch+oys65rcS0ntkmq8KHTXwOGtIuMfUPB88NPNooM1FJVdhjsONaMPLccbxYYFHwLImtjM0bb125y4YKRY4KnmfJJ5ba5ilTQQ1HaQ7g1CFn9E4TYqRfGpcR/0abIFmwX6vdMekhpiRogj1gEYsDFMh/9ojhn4ILQsxAin0hbau0Blk2TUJl3RkAwhR5MkwepW0oozfP7b4b14eWLn0sj0ULye9/uMO555GSkfaNkxQHFVOsUCvWqFoXOkevthyZ9oSqMtsp+cxjeY6t+q4WqKJaMXO+rj7CEci6jxr9QO6jkCX4iMDG4dlXusBD8DuqBCdcbic5CRywR8cs/vgx1BLn4NExSqgaj4c9RypID9rQS5/GItLqQZs94NEaNHYoIPJW86Rn6AdvXupvCx5UaVngduLx/H5PJBAkEEFsoMubm+7jJm0YmQRKPadAAIY+8l528BSoGGrWjZqglwc/nw1R9y51/D0GRxwyde/YjDt/90wF+X hwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 07, 2022 at 03:01:52PM -0800, Vishal Moola (Oracle) wrote: > +++ b/include/linux/swap.h > @@ -409,7 +409,7 @@ extern void lru_add_drain(void); > extern void lru_add_drain_cpu(int cpu); > extern void lru_add_drain_cpu_zone(struct zone *zone); > extern void lru_add_drain_all(void); > -extern void deactivate_page(struct page *page); > +extern void folio_deactivate(struct folio *folio); > extern void mark_page_lazyfree(struct page *page); > extern void swap_setup(void); Using 'extern' on function prototypes is now unfashionable; you can drop it if you respin this patch.