From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C24C4708D for ; Wed, 7 Dec 2022 23:09:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 525E18E0003; Wed, 7 Dec 2022 18:09:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5E58E0001; Wed, 7 Dec 2022 18:09:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C50F8E0003; Wed, 7 Dec 2022 18:09:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2A71A8E0001 for ; Wed, 7 Dec 2022 18:09:59 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F1AB0C0E60 for ; Wed, 7 Dec 2022 23:09:58 +0000 (UTC) X-FDA: 80217054876.07.C8DE5C1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id DB90D40016 for ; Wed, 7 Dec 2022 23:09:55 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Z2+ynanT; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670454597; a=rsa-sha256; cv=none; b=vo45kM0pHBuyVzOjkF6UqPInr9+ZfKqVaVaZxE5wyapumO7V8WfOtmfqI4h7NQDTCBR+93 KLqwH6Ae7OztOm9ZKoAgseWLHyWLxjQ0eQqvcR/fSHqQsyIJDDJpWsa42P1sermD5M+xw0 EhUu8VPd2q7MyhqhLauc85r+JfwsI4U= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Z2+ynanT; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670454597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xqHiRihBJ8iX0F/IkBiJScs1HhKDLwhRskwhnIf3MT8=; b=VfKqF6pLTZwlSCT/yI22Qpj9jfXEZRkSZS3RKhWANnuUxNA+nQxmvm4hqGRW9PTi+YwJeV w5T0xwpsItmKvPXSNJovkuhtMAu3s0iEuRLCeG8zxkS3nWNGouvyj1fUFPjciT2lXfxtLl SDqu6bODn1ZTzvZnCsHxuS3JZfO8UmQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xqHiRihBJ8iX0F/IkBiJScs1HhKDLwhRskwhnIf3MT8=; b=Z2+ynanTTY8D9mWJ9eqW9lYfd5 Xwe0VmlCYl+gVh/rHRHIuDPnWB2VRRrvl9FJ05OxNsb2YI1exSW+EYKuNiji4yv1pr7+xiJeQ/XzK N79p6UQhttIVKpVjUJjuC2HCHkFpcwHzx7ky9ym0f8+cONc512UwqHcHtMkuFzgMJpfpoaW4lqYwF +6wr3GhOMPcFQRg4QMhzpXbWCiAj/LmzOC/Gh2l3i9eTVHDF2OLB8UbHvY7BuBVYDgUEMIJiCAXnr OzS4OTYhnzcVKOBDp/YE0jTGezZFOZ8GWUcdwvY9ovgQob+KHkwDkqpsUiXApDOPq4WEBQShgAwle 1Aa32cVQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p33Y7-006IRG-Nb; Wed, 07 Dec 2022 23:09:59 +0000 Date: Wed, 7 Dec 2022 23:09:59 +0000 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sj@kernel.org Subject: Re: [PATCH v2 1/3] madvise: Convert madvise_cold_or_pageout_pte_range() to use folios Message-ID: References: <20221207230152.22938-1-vishal.moola@gmail.com> <20221207230152.22938-2-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207230152.22938-2-vishal.moola@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: DB90D40016 X-Rspamd-Server: rspam01 X-Stat-Signature: pgn9314ezrbdc9gbqs1xrspr486m69ow X-HE-Tag: 1670454595-200258 X-HE-Meta: U2FsdGVkX19LWdLu2wY//J1H/HwsbC5XdoWDv8zqo+vxNVcD2KAzHRDrc9SQJTSPh8aYSkpHWAtoTPDqX05hmJ0p9uzMxD8BM3NHoBo5A3B9h8ngSJX+hRKL7moKa8fh6mJNDWz/Tajfic/9Ad2V1GENj8nXma7fs+MkMRSubKDJPaxw38e/iOxRzz4yOzO4txnFaYKFeAenSfJaXp9vuROZbNTlVBxRkb+q783VJkWPbNFMpPJBGmHB4GGwlA3fbnMGs8EwlITAPZ6C+wJ+jJ5nK3dr7bW9chSagpVIsnOQq19ofGeZJADgEbbcy97X/nU0+hZBZx2qKM50qoshHe15UhXGntZULMMfOROuaEa/Fw0WUYh/qs47H8/oAWncaDGxcsHEO9rHxdVO+IU/GVrUi7+9woUfnpwLQ6qkaltSnaHYlMKk0oQLmXlll4xv6TpebZc4miOAnyM9yDPGepbcCf06nXVUkVQutnrdZb/V57aqMCJLGyylgTh7PPN4QUMK/eEqnO9/9lMdwWYzhQhvont9bAiYQpuXfdg1MCXmT1B6uEFbTemlmMuhd+d1iPj6U7jWFfdGmBIJTHT2woSWosW7hLK52Bxi79XtHmiOXf2Fk8NRkk8JjyJPGZONWplZrigaTcoKHfctikcO5++0ewQDylEuKHH10dRh6DHRY/7KZfjy1ER/fbpGcRCGS7PmdU3b7gxeQVccuWsR8+TELA/tJl/+Lb6bjHVBYELZDe7dcFM0vWroyV7bIbq2Rb+lSSm+4KzgL9GKgpdDZ7MuAFDFCOuQwl2MA9OoaSR8fjBbVo36GbVToWyqlp0o7B1N8+JpS3Zom8ZhbAlKWM3R+vpAB+R6RIAdOXj8qJ29n66/f3df9IGJ/4e9cWscnCOTIxbD1CsVFdFhmPcTq+/Op5/DwdzitcJPep8wgw/kgQZbphpzYpKOK0rqyOf48KP3/80Gc+YUUHy6MFa 0iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 07, 2022 at 03:01:50PM -0800, Vishal Moola (Oracle) wrote: > @@ -424,28 +425,29 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > page = vm_normal_page(vma, addr, ptent); > if (!page || is_zone_device_page(page)) > continue; > + folio = page_folio(page); Maybe we should add a vm_normal_folio() first? That way we could get rid of the 'struct page' in this function entirely. > @@ -453,13 +455,13 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > } > > /* > - * Do not interfere with other mappings of this page and > - * non-LRU page. > + * Do not interfere with other mappings of this folio and > + * non-LRU folio. > */ > - if (!PageLRU(page) || page_mapcount(page) != 1) > + if (!folio_test_lru(folio)) Why has the test for folio_mapcount() disappeared?