From: Matthew Wilcox <willy@infradead.org>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: linux-mm@kvack.org, damon@lists.linux.dev,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
sj@kernel.org
Subject: Re: [PATCH v2 1/3] madvise: Convert madvise_cold_or_pageout_pte_range() to use folios
Date: Wed, 7 Dec 2022 23:09:59 +0000 [thread overview]
Message-ID: <Y5EdR1l1Ho3FyrY3@casper.infradead.org> (raw)
In-Reply-To: <20221207230152.22938-2-vishal.moola@gmail.com>
On Wed, Dec 07, 2022 at 03:01:50PM -0800, Vishal Moola (Oracle) wrote:
> @@ -424,28 +425,29 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
> page = vm_normal_page(vma, addr, ptent);
> if (!page || is_zone_device_page(page))
> continue;
> + folio = page_folio(page);
Maybe we should add a vm_normal_folio() first? That way we could get
rid of the 'struct page' in this function entirely.
> @@ -453,13 +455,13 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
> }
>
> /*
> - * Do not interfere with other mappings of this page and
> - * non-LRU page.
> + * Do not interfere with other mappings of this folio and
> + * non-LRU folio.
> */
> - if (!PageLRU(page) || page_mapcount(page) != 1)
> + if (!folio_test_lru(folio))
Why has the test for folio_mapcount() disappeared?
next prev parent reply other threads:[~2022-12-07 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 23:01 [PATCH v2 0/3] Convert deactivate_page() to deactivate_folio() Vishal Moola (Oracle)
2022-12-07 23:01 ` [PATCH v2 1/3] madvise: Convert madvise_cold_or_pageout_pte_range() to use folios Vishal Moola (Oracle)
2022-12-07 23:09 ` Matthew Wilcox [this message]
2022-12-07 23:45 ` Vishal Moola
2022-12-07 23:01 ` [PATCH v2 2/3] mm/damon: Convert damon_pa_mark_accessed_or_deactivate() " Vishal Moola (Oracle)
2022-12-07 23:01 ` [PATCH v2 3/3] mm/swap: Convert deactivate_page() to folio_deactivate() Vishal Moola (Oracle)
2022-12-07 23:11 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5EdR1l1Ho3FyrY3@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox