From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B24C352A1 for ; Wed, 7 Dec 2022 07:39:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03D3E8E0003; Wed, 7 Dec 2022 02:39:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2FAE8E0001; Wed, 7 Dec 2022 02:38:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF7028E0003; Wed, 7 Dec 2022 02:38:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D04AD8E0001 for ; Wed, 7 Dec 2022 02:38:59 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7F5BDC031C for ; Wed, 7 Dec 2022 07:38:59 +0000 (UTC) X-FDA: 80214708798.24.F8B8D45 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 72E44120016 for ; Wed, 7 Dec 2022 07:38:57 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=23zWkMQ0; spf=none (imf29.hostedemail.com: domain of BATV+5297cf3c0cf7521e1e16+7045+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5297cf3c0cf7521e1e16+7045+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670398738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A/eq4/wgg2rp1ld2NuQJrWGKee0voE45fREibRm9FUw=; b=eKtJFlYZ24L8NFpleV6rHk2EHOump9wR2PjUJs8T8xDSh+Kpl0+qiNe752gr8YfxPre3l3 +Qmoyvfyukwmj1V9AHdvjkR/JckwG7bsEh/OeAAKhWPjAFR1TY42ysoHArlf4TWTUnNfYM sizo1YzPgd3LfPLbhpmRHl1gAMLJBls= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=23zWkMQ0; spf=none (imf29.hostedemail.com: domain of BATV+5297cf3c0cf7521e1e16+7045+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5297cf3c0cf7521e1e16+7045+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670398738; a=rsa-sha256; cv=none; b=1e1ZXSYBookKnB5uaGyVvblNp6vj42mS4vCp5SjP2h6K8GI1CaLebQj7QjGaZ6Axa4k0li woiDGnILc1dwZXDrPYsPP3fcSj1OO9fYmk9T5PO/s1ZkzIrPIw9z7o7UsT7/mrH/uWs2PG +aWj25pXXOMxWyAHDGmecB+oYwNlL0M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A/eq4/wgg2rp1ld2NuQJrWGKee0voE45fREibRm9FUw=; b=23zWkMQ0yZoj9k5q6yInfok+g/ +eKXpmTUpvK26qhTXssR43JuDx5KaBiJ6Y4NTXmY0HQa+kg67H8C0xsxE1u4sQMzSHTqFEW/Ys8P/ mFDKrC3SkxdtAyZwE/oQoTtumJn8SoMniscm4Xvvf2UTgV1L5+ni7CrYAdfWDSFm93XJOUyJ49fm+ l2LQghB/ezZ/5gYC/0duKvJgq957XVDuc32bqlprarj5Zujk5O4sjl9LIA4NN3Op74jMqD09eOwhG UpSDAxvwZ3q8NeZ+Gq8/BEgYWysrMfu3UYmrtXwBZHV/ZAwmYNcpVnSj/XX8Rgo3eJtoQT47fCVfX d8G/iZfA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2p10-00E760-PT; Wed, 07 Dec 2022 07:38:50 +0000 Date: Tue, 6 Dec 2022 23:38:50 -0800 From: Christoph Hellwig To: Jan Kara Cc: Theodore Ts'o , linux-ext4@vger.kernel.org, Christoph Hellwig , "Ritesh Harjani (IBM)" , Christoph Hellwig , Matthew Wilcox , linux-mm@kvack.org Subject: Re: [PATCH v3 11/12] ext4: Stop providing .writepage hook Message-ID: References: <20221205122604.25994-1-jack@suse.cz> <20221205122928.21959-11-jack@suse.cz> <20221206105225.nr734teqlkueqdph@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206105225.nr734teqlkueqdph@quack3> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 72E44120016 X-Stat-Signature: azw9trpj8guuig7df8m3ek8orrepqzm6 X-Rspam-User: X-Spamd-Result: default: False [-4.00 / 9.00]; BAYES_HAM(-5.60)[99.13%]; SUSPICIOUS_RECIPS(1.50)[]; FORGED_SENDER(0.30)[hch@infradead.org,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_SEVEN(0.00)[8]; TAGGED_FROM(0.00)[5297cf3c0cf7521e1e16,7045,infradead.org,hch]; DKIM_TRACE(0.00)[infradead.org:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[hch@infradead.org,BATV@bombadil.srs.infradead.org]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[infradead.org]; TAGGED_RCPT(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: rspam08 X-HE-Tag: 1670398737-231064 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 06, 2022 at 11:52:25AM +0100, Jan Kara wrote: > I don't expect any objection. The only reason we didn't export that > function when I've added it was that only blkdev code was using it and that > cannot be compiled as a module. Should I send a patch to > > I've added a patch to the series to export this function. It is attached. > > I can also repost the whole series if these are the only changes that block > the inclusion. I'd do an EXPORT_SYMBOL_GPL, but otherwise the export looks fine, and it would be good to get this conversion going!