From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B37E9C4332F for ; Sun, 18 Dec 2022 08:08:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D3E78E0002; Sun, 18 Dec 2022 03:08:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 885878E0001; Sun, 18 Dec 2022 03:08:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 725628E0002; Sun, 18 Dec 2022 03:08:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5F9998E0001 for ; Sun, 18 Dec 2022 03:08:36 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 291FCAAEC7 for ; Sun, 18 Dec 2022 08:08:36 +0000 (UTC) X-FDA: 80254700232.21.E1C1236 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 6D2794000B for ; Sun, 18 Dec 2022 08:08:34 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WUdkwt3B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671350914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6poDqm4UxtCN0MX55dOstQULvn1wLze6+Wp6+uy5QxQ=; b=VQsPjbA0V97l2ZyW5orvFw261u3rrR4U7phiSiv1bTNNJT2nuCOt0gg5d5QnZwnfjblD4u SIuIcLT13WJXdCMnThClu7mQGWQHhtc2tzX6gmFIUbNTIgonfG3C1ZeZCwwquG+0po0WHT 1g7iQAvl8jo0D9eO4N7MVfWmHZWIJuo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WUdkwt3B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671350914; a=rsa-sha256; cv=none; b=1mxHJuCpbJUM8Q2j36amn4TANStUb2FKuieTfDyOJ2Nu6kw4WY3+4rAlvS1oIl/6TjvW8t OPExpNN4nmQ61nCeuugWIfmwRjNA34dIHxQ63T5bQHL1j0VSvZYEQFEC7w68dqm1V9pHdt IugHbGVvaHAAmSEUEvYm8hTwmhhRJOI= Received: by mail-pl1-f171.google.com with SMTP id d15so6264809pls.6 for ; Sun, 18 Dec 2022 00:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6poDqm4UxtCN0MX55dOstQULvn1wLze6+Wp6+uy5QxQ=; b=WUdkwt3Byo3bw4iv6YVvbLXjm9cXbqJiaflDT8O9h37abkq8ZrHUSIeW5qrevT8wQ5 Zm9IJmGOvtETphZEf4BSut9xwNOj6BRfZSPbJ24Qc/IfHkBCLaW0YZmNKjVBK2RIV66G CqD9/Edtul2U7jvsxE+peTuQuJsuL7VAnpnB0cfucGsDOzuD0n9fvs8wLG0pd9SpXOOw W1ncSliPAcT/hPJHzqvICaoYce9t9kW3agtHL6m7HbOXaImLpEAp6rYwdpwVO4P78uJB ZswQhUl8VyLpIaNChnPytyfwmy+vKZue1ksPnieMEl98qVcpYAcEWV8XwuuZSBWvdXkT mx6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6poDqm4UxtCN0MX55dOstQULvn1wLze6+Wp6+uy5QxQ=; b=d6U9Ekoam0dscCASDfbG9OgpAnnvK9oek7nOlQ8TqGvua/3MiW+N3Q6VOVoXlxkA0H QTyewB/WamgfrRUvWElO3jLHlM5QEjjlJIa61maetjisl7YqtWcWBTO0rrgkn4HFWO4+ 32vugn0YgIHBQLbiiHizlFIcz5g2gU/Cu8p44awfFuUdMQuDsyr1grCVnDyEIj/k9DTD DeaMEM03G5J0RWecClp5IWTWkG5HSU0903gqVIfLn4+O0lVDSEzR1oJRbawRwG6c2Ha9 cqPTHgL9CibKTkVGFrZZ/rYybLHbspn2snqg6r8MGBiD13dgObiYFveZUcxV0exDACZ+ pMmg== X-Gm-Message-State: ANoB5plxPhIPRqTgY3AO0y87GAbbkg+UaCsHnMVr1BOc6Ys8LBuZXNsL BWCd+ZncaWQ2iUt/3uLDXWM= X-Google-Smtp-Source: AA0mqf5sNcGDh01Ud44YNMjPxKpoV53vd9+6v6j1KkNY58b/VPadBnvKc5RUZXH8edwSa9RYnbMUhA== X-Received: by 2002:a17:90a:cf02:b0:221:4105:6621 with SMTP id h2-20020a17090acf0200b0022141056621mr31008286pju.16.1671350912938; Sun, 18 Dec 2022 00:08:32 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id j5-20020a170903024500b0018971fba556sm4603937plh.139.2022.12.18.00.08.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 00:08:31 -0800 (PST) Date: Sun, 18 Dec 2022 17:08:27 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Yafang Shao Cc: akpm@linux-foundation.org, vbabka@suse.cz, willy@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH -mm 0/2] mm: page_ext: split page_ext flags Message-ID: References: <20221217105833.24851-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221217105833.24851-1-laoar.shao@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6D2794000B X-Stat-Signature: 1o5efqpj8n5jdo53ewdj3we5q9mhzf1i X-HE-Tag: 1671350914-712901 X-HE-Meta: U2FsdGVkX1/zHH3MsELXmyuU/mfcAsRFum4GNzyU/aVhbubcwfNAip//84ZZtHO0rcA0yzbH+Gqj05iNOe0Xn69w3/jSexuPV8X+yuxxT8L/9NEh6mJS5ZFBjxNKPs0Sk1oImiAfAvh0ybxwp3JQx8vO7O2qZGCVPoEt4UcwL5gSHY9HTPUBdwXLATPXdZ6maajaJmXsC2GU6N8nr7csZQDtEGWzuw9ALZO7Qwm6jqA4f/a9K/44rCv5eI9+2MpePcsNO+CRs3rami3fGt6AbrWGDCqgHlS5g6lhqlq/nSdhAywqEaKCADl7ZBoEtK+QAFEaQXIg0/EtrgfoDXFoqi//rm1ObwiV+ZkegwY8iWiopR5lV+ZmJTumrtb0QlUti/+1x49Wm5j4l6Q0mstPI9yBLxe18mD3gJljg4duyxCCQi1mRyczN9mek6H8TcOPSwOV+yJ/XgFv15Ipfl9HTAwg8p/8Vh1gFXpKlq4oyDSY9Kue9/e48j8xy0Ts97qb/0a+nON+qNuD8+s9x5jiCW7NFh1rG8UMh1Hz5lHowvIWycVt8FKXFEdFW5ovu18DWxHswkdIHFRQn5E7QnXFya5FDWAdMbiLFMzJa/KpYKlRa5iO6foYy7H0jcBEwIzdyR80vZPPSqO1nhWxmvwatn5ziV5zdTL2ATrQ/YQ1I0qBsZt2E3Ljs/GQoos5s0gqZsVAnbK1GB77wS11XF5AVaZPV5WaZ1+dfXP9vkXk3mC1qgqYq2+6k9p8u+cEPMbE/Rc0Z/9IyB/bSkgBOsY0Ovf1y9rPrfGssewReWbV5qkgQTrx8pM2UY1lKjmQtrBSoOZM2lQZ0I1gnWYvp7FyomsaQBOjmvF5zeu9rNVmcZiTAWEbg0tGtWW8jD7uo541sfdan90kvK+FXIFkcAgXPh7W14+OoJPcOre17159zdJHihzhs9z+s66Hom2CpkvH667tvyPfUTQOmFKW+C0 cPhEXBxh yaKi00CJYiSaVAXvYPa8UYLvgmzPPNYasFj5T2DuzYUKYcbqmTH1nMVbyX3M3rF7TW/uAz/LqRWUCftn2g3UuFv3PpaVrw5iW5q9Y++S+hfvI6Qq0B60uyrkNL03gNa9uepSqegsQEJCKpxQ7jMSj5OXHh031gMGBN5lM7nLweZ/zCX2eypwwv3cU/hgY9NZF+ZWG2SVLWByzKzLjMbb9D7xjRtD9Q+EAS6q/SiWDodVc/4w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 17, 2022 at 10:58:31AM +0000, Yafang Shao wrote: > On 64bit system, page extension is for debugging purpose only currently, > because of its overhead, in particular the memory overhead. > > Once a page_ext is enabled, at least it will take 0.2% of the total > memory because of the page_ext flags, no matter this page_ext uses it or > not. Currently this page_ext flags is only used for page_owner on 64bit > system. So it doesn't make sense to allocate this flags for all page_ext > by default. We'd better move it into page_owner's structure, then when > someone wants to introduce a new page_ext which may be memory-overhead > sensitive, it will save this unneeded overhead. I'm still worried about the approach of using page_ext for BPF memory accounting. Let's say we finally accepted the approach of using page_ext for BPF memory accounting, and if it's not enabled by default, you need to rebuild the kernel when you want to check BPF memory usage. (Or make everyone bear the overhead by enabling page_ext default for BPF memory accounting that one may not be interested) How the problem of accounting kfree_rcu() is going? Doesn't call_rcu() work for the problem? I still think it's much more feasible. > On 32bit system, there's page_idle running on production envrionment, > which also uses this page_ext flags. So it will take another 0.2% of > total memory if the user enable both page_idle and page_owner after this > change, but considering page_owner is for debugging purpose only, the > memory overhead in this case won't be a problem. > > So, let split the page_ext flags. > > Yafang Shao (2): > mm: page_owner: split page_owner's flag from the comm flags > mm: page_idle: split 32bit page_idle's flag from the common flags > > include/linux/page_ext.h | 14 +------------- > include/linux/page_idle.h | 39 +++++++++++++++++++++++++++++++++------ > mm/page_ext.c | 10 ---------- > mm/page_idle.c | 12 ++++++++++++ > mm/page_owner.c | 36 ++++++++++++++++++++++-------------- > 5 files changed, 68 insertions(+), 43 deletions(-) > > -- > 2.30.1 (Apple Git-130) > -- Thanks, Hyeonggon