From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25846C4332F for ; Sat, 17 Dec 2022 11:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C8968E0002; Sat, 17 Dec 2022 06:44:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5784B8E0001; Sat, 17 Dec 2022 06:44:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 440388E0002; Sat, 17 Dec 2022 06:44:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 34FC78E0001 for ; Sat, 17 Dec 2022 06:44:27 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 10A43A0A94 for ; Sat, 17 Dec 2022 11:44:27 +0000 (UTC) X-FDA: 80251615374.18.348D27A Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf17.hostedemail.com (Postfix) with ESMTP id 5F7334000A for ; Sat, 17 Dec 2022 11:44:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=k0fpKgaZ; spf=pass (imf17.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671277465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GBSVB2Oi5TbTIwwaOpRKfNJzplXssZ9oR2ZKAZimo4E=; b=x0fmDYWX23sWFXwPYNW2s/Ypgljy3oSww0LiBlDYANC6wdvqMSiiRfZkAIgPBINKrboQmv K0lFGIpSKQXVs52OGhj1PiDEQGwVBy7OPC2FERIgHaY8bj5EgJM8IcVP62E777Vr17gz2R XH1KaAGUgU5pEquxGcIg7FePPCv0Xe8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=k0fpKgaZ; spf=pass (imf17.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671277465; a=rsa-sha256; cv=none; b=SLAcFMbry656A+PD1wrPz4r4YDEEU0SLGudEnU7pc9lAjr3AwMuL/dohEobI0byhRKvi2k z1TBFnN+JvVXcuNosmEwgHI+fYv4jtvtRtYL6n5ner+9LDQrWRI4m/KWh669RVzfLKxiKn ytDj0hnmqlZKYyNPNz8HE2znW/sNtMQ= Received: by mail-wm1-f54.google.com with SMTP id ay40so3473379wmb.2 for ; Sat, 17 Dec 2022 03:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GBSVB2Oi5TbTIwwaOpRKfNJzplXssZ9oR2ZKAZimo4E=; b=k0fpKgaZIUGDT6X0DZ06jlzs25bISKhHU8bB9iJXybs6SUxcmHz9r0S8xiebXfjzX8 THW+vbhhcdK+2AP0ygoxLy2aURFM1ZisP7eBv1m0Y1yBXewI5nBtOl+ZZ3jOn+lBcoTr T4jbe7AmYMuKIgpOr2CCC7SsOZMuIbfKb52WMBhhAxowekO3hr9891cassApDuvzcSYV NfOWeLj2rP1/jdtA1r6KV9xpZmrQW3OBh4AT1J8oMES7ixoKtzYbANxIlTaYyYyQM3Mm npGVkj3MjY/3JPn/uDpJJNcLMuoSN+UR1B3jVLSvmYo2UqF30KFUzfh7M5c+5EVTv6Zc 1d4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GBSVB2Oi5TbTIwwaOpRKfNJzplXssZ9oR2ZKAZimo4E=; b=H5RT2A6ku8Aez2360dz/Hx94ev3fHhmBTMh8xDH+sZXzizyUNWTAJv2MxvpqoWvJN/ qmEr6m56mvQtNMvCuvL3YG1oar6TSQVwfDMOYgXn3ShZ33Q7Dx/dHE73TMUeG3YFLR0E fu9fdAhTWIerzPd2kGM09CGrIKHwI0Ia7CS9LLcQuhBUxwH1CukGQvM6psc1xXitaB5h z5gxyxlsdAeQ1HWVpWuUWblTMCNBarrdJiYHQGfszsnH+m+sqtDWQxalAPM9oIcuSzoA zenJNK/GMnVOyu521SpVIHsIHhSs9+mi93jCMX9HJ3X1iJdwyCEgemMIt5Owl9+5Pcja /g2A== X-Gm-Message-State: AFqh2kp9YTe71fKPcMUrwB7BBo4PFHmIMgzWlGoORgEBOv3rshWl56Ud s5Ph8kmA5pC8vnjCftE6lbep+yLE2Tg= X-Google-Smtp-Source: AMrXdXt6sqQP1NtKTr05MgB5iN/MzMucgIdOEJXOXRqsztLP+6QiRv2Fa9AnrwbtJV0dBnZ1y4jSWg== X-Received: by 2002:a05:600c:210f:b0:3d3:4406:8a3c with SMTP id u15-20020a05600c210f00b003d344068a3cmr4380165wml.32.1671277463842; Sat, 17 Dec 2022 03:44:23 -0800 (PST) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c020800b003b4935f04a4sm6505486wmi.5.2022.12.17.03.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Dec 2022 03:44:23 -0800 (PST) Date: Sat, 17 Dec 2022 11:44:22 +0000 From: Lorenzo Stoakes To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, urezki@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v2 2/7] mm/vmalloc.c: add flags to mark vm_map_ram area Message-ID: References: <20221217015435.73889-1-bhe@redhat.com> <20221217015435.73889-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221217015435.73889-3-bhe@redhat.com> X-Rspamd-Queue-Id: 5F7334000A X-Stat-Signature: 6r4hrcomhb6uwfemsiymajpa9dxje7ke X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671277465-538431 X-HE-Meta: U2FsdGVkX19MWqA66r/YfN+CrNPKl/lahJGZOdjFIDTyRTMyJnvRvAwSMP+jO/RF5+BO+JhYNa8cQ+E9zVJZwp7SFL+D9aE3XbV/vHlXVaGSNWMz+L0OcKtukCSnLZPioCr+UfB78+teLiZmFK9X0S8APwvsgn64iCCH1yl5ES6qBzKW6iLV+nPTgIwYTQbWh3n6SYKczoMA+sjkyt6poIlOsALI+i2dRA/ET7A9EUaZyeBIqcjvK29mYEcOrDk8dXIXSOiU7X4xGWClxdsdp4qpjqzsoJecGeYCjDkSVMfVfYzVI4WAldBTr4Pz7KIViaTrgj9zkLo/QoN1pynaXRrdrODlRFx31uuVYoHAv2SjGJbJ0t9LW3ImaPFNGHYqTd06UrTxG8RK1foFqY5blMHP3B6lMwl64jI8f4sYimxv2EmBqFM9BCbA5DzUWa3Q6TQ4YMc1epFLTBdh7v1UcTd1Cv63Y2KdEIi3VhOw7CeL2v3ynbBDAZMD5SRxSj24G7/j1iIXfxQqiENec4cYiAA2duNfChSHRih9XLk6fblUD10WTcelocdYGw68Ux12BpisAtg5aGsmQ4+o40K/YC7u03vo88Frdhy2npBPkC3cutln0VrMLEbEGjBP1NFPPNYNMszBOnCqcTn1gaFqeRTsPDMtxdC3cud9j+3FFPM9etoMERyk/euD9couar8tu/q7sBtd2GqKPq7F9mdst5ZOV0CRm9UNWYU/qm+9vohBL2tuKglG0qjH2XgrM020zj+kQMZEsjXL2FSbT42VcuCmfBHBS/quNtfHuvrWat0gljM8rxh6U7dFYw3UtG9EJTDo5QsJs+6MBs5p+egCwRuIp5kasSPRuuEH7rf5MaKe+jQPzDT7+WZ6Ecbbd7MZHE7A4VATiCMIuhhd2LKnCLntF2shunvyzykYDUrnr7oEEpoKnedeQUY+2oIpZ+H7gXGY+2UmDtA29/Bk7DD LHvGc9a2 ShOxyg0JxZSGuTXpT9uQIXUzykzJuN0rne/wjEsu2pstLrEZ4d3fvkGojkAKo35l08KrFrLEzS3/QKENj9DcnEK9sbi7ITK29o0tlEaWTecCgdFRHgREBsoCAgLYjddrsY7kV X-Bogosity: Ham, tests=bogofilter, spamicity=0.001947, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 17, 2022 at 09:54:30AM +0800, Baoquan He wrote: > @@ -2229,8 +2236,12 @@ void vm_unmap_ram(const void *mem, unsigned int count) > return; > } > > - va = find_vmap_area(addr); > + spin_lock(&vmap_area_lock); > + va = __find_vmap_area((unsigned long)addr, &vmap_area_root); > BUG_ON(!va); > + if (va) > + va->flags &= ~VMAP_RAM; > + spin_unlock(&vmap_area_lock); > debug_check_no_locks_freed((void *)va->va_start, > (va->va_end - va->va_start)); > free_unmap_vmap_area(va); Would it be better to perform the BUG_ON() after the lock is released? You already check if va exists before unmasking so it's safe. Also, do we want to clear VMAP_BLOCK here?