From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6855DC4167B for ; Sat, 17 Dec 2022 09:57:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC8458E0002; Sat, 17 Dec 2022 04:57:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B79A98E0001; Sat, 17 Dec 2022 04:57:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A40618E0002; Sat, 17 Dec 2022 04:57:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 94CF98E0001 for ; Sat, 17 Dec 2022 04:57:12 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 586FD1607CC for ; Sat, 17 Dec 2022 09:57:12 +0000 (UTC) X-FDA: 80251345104.05.1278F18 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id 6E9A01C0016 for ; Sat, 17 Dec 2022 09:57:09 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=LzEcwgGh; spf=pass (imf20.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671271029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SoLRNQRrRqUNC0cGrLyDcGJ7nXiwl9BQ5rqnla0AEQg=; b=xvWibY83+lVfBPKZ74FlSUoLuNXy4M25M8QIGmzwE/QvbvP7KSeD86+pCWO9iSUHxMRB68 25zieRd8loEqnys3Vyo90bNOhFNBTiVD84cd44DZOx3ocvSuAs2UC1ikUUJUxwr0KxEcWj J6ReWv7wFvSuVNEaM2a9l3wqEXOWkAQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=LzEcwgGh; spf=pass (imf20.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671271029; a=rsa-sha256; cv=none; b=IVbP2Z+IuvNKce66NezEIKpRbwdnRdLnhCDMsfJvybg38LIgYLfG3bk9AUnBYt/nCzXf0a yOf+uyDOOlyrZyGVNv0pw29s+iPgdD6Ez4IPPp/7ndPwYxhxklXPVib760crhWPJi0TEZy Pfr/3Xo1EBX6A6i4Q6bMv2d+pgoffqw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CEDBC608B2; Sat, 17 Dec 2022 09:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1671271027; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SoLRNQRrRqUNC0cGrLyDcGJ7nXiwl9BQ5rqnla0AEQg=; b=LzEcwgGhGGz8nj03JB5W4TiSbEKztKdG7hrQa5MIO0bwc5t2NC30MAA0U3vd2UhSj4T2Pz Tx7x3OMd+ZGReDRDIwwbXqxis7W8upuGmgfxuw87vV+OuG3oq1SRHDCSet4bS0DJKP0ag6 XpG0vDOWegM0J6b+oztGV495X5UdU2I= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A96941326D; Sat, 17 Dec 2022 09:57:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id St90JnOSnWOFNQAAMHmgww (envelope-from ); Sat, 17 Dec 2022 09:57:07 +0000 Date: Sat, 17 Dec 2022 10:57:06 +0100 From: Michal Hocko To: Andrew Morton Cc: Mina Almasry , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Roman Gushchin , Shakeel Butt , Muchun Song , Huang Ying , Yang Shi , Yosry Ahmed , weixugc@google.com, fvdl@google.com, bagasdotme@gmail.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] Revert "mm: add nodes= arg to memory.reclaim" Message-ID: References: <20221202223533.1785418-1-almasrymina@google.com> <20221216101820.3f4a370af2c93d3c2e78ed8a@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216101820.3f4a370af2c93d3c2e78ed8a@linux-foundation.org> X-Rspamd-Queue-Id: 6E9A01C0016 X-Stat-Signature: qyacoj1r4usouj5ppd3pifyf95zyp9o8 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671271029-495152 X-HE-Meta: U2FsdGVkX1/SRFFLTiGbJW+RjIaa9E7ioQvwj8gKuNH+f+Q08XJ+u1WvivKVlnCdfDslUAaq95SFkMPxa7upv7gmD2wLVIVwh3ev2nDQxET0IiS9fH8iOlVYZTc0MF8tREzaGjuHRK4mK7gRHhTdLc9l3gfwHE7ZKymv9WQ+kuM7kLOys1avuHHh6P096yw68q0GqEzj92xv23B9Fa7ip8J85iuxo5WFSYPbV0aDPjaNJDrblAcp2ajtNhGCh3Hl2AoCwRUHA5kZj4Bt1JSBnna8F6ZqHxXVHusFAGxirTSmy9NadikGk2p81WTaK9KcgMJCbK30fxWh7EwxNDC5d7MDRKJTNx33YRXpb0RPFtGIaRhX8ivSPzl0Jq8/QT4M75JL1LETud7n72hIfemCpboDP1/zZdDXFMmc8hI33H2Gm0KLJNprdSW5pyr7XHUkCEZhh1W4QEeHk5offoll6vm6dMlQMycRBlLzenxQEc1LZcADmg+PwZhWE5Nji+IDQJAcLnzx7qT4p96ufzcsCWVes84NBhesZCsEY5ViKsElKvb7zirSRr+RAKjWK1o1fs5DDKUDEFRiz5Bhe+0i8KkkoYDUqkEBMnlNGystsWSAihpUjGYdIUWIC3gEXUdtDDVo3uR2qyN1zE7uHkuF1mOvFr7yfRMH94bIIMTAjihkD3fMySbRgkrh32U/vW3bk7zoCvGhQpt/Eg66U43A4FBlZkZCEAVebn0H4uGB9hdNbwo9/JJArpW7o0Qn4/aw+ufTVpCB4ZhI9DDIerG8g3pAFEjJux6g9tyN514KZzjvsYvt0ObfmvGBJaRak3+J82q6XF3e8UicNGUJ5Knlbm9ig9YC3+BIuAl+ltzg8OdElz5s4/4Mcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 16-12-22 10:18:20, Andrew Morton wrote: > On Fri, 16 Dec 2022 10:54:16 +0100 Michal Hocko wrote: > > > I have noticed that the patch made it into Linus tree already. Can we > > please revert it because the semantic is not really clear and we should > > really not create yet another user API maintenance problem. > > Well dang. I was waiting for the discussion to converge, blissfully > unaware that the thing was sitting in mm-stable :( I guess the > > Acked-by: Michal Hocko > Acked-by: Shakeel Butt > Acked-by: Muchun Song > > fooled me. Hmm, as pointed out in http://lkml.kernel.org/r/Y5bsmpCyeryu3Zz1@dhcp22.suse.cz I've failed to see through all the consequences of the implementation. SO my bad here to add my ack before fully understanding all the implications. > I think it's a bit premature to revert at this stage. Possibly we can > get to the desired end state by modifying the existing code. Possibly > we can get to the desired end state by reverting this and by adding > something new. Sure if we can converge to a proper implementation during the rc phase then it would be ok. I cannot speak for others but at least for me upcoming 2 weeks would be mostly offline so I cannot really contribute much. A revert would be much more easier from the coordination POV IMHO. Also I do not think there is any strong reason to rush this in. I do not really see any major problems to have this extension in 6.2 -- Michal Hocko SUSE Labs