From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B1BC4332F for ; Sat, 17 Dec 2022 04:56:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62A838E0002; Fri, 16 Dec 2022 23:56:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B3B68E0001; Fri, 16 Dec 2022 23:56:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47C408E0002; Fri, 16 Dec 2022 23:56:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 30F8E8E0001 for ; Fri, 16 Dec 2022 23:56:02 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 087DE1C6CAD for ; Sat, 17 Dec 2022 04:56:02 +0000 (UTC) X-FDA: 80250586164.27.832AF1A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 878D940003 for ; Sat, 17 Dec 2022 04:55:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HT0Ah9m2; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671252960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HNBvGcqXcWq+3AAYbJatmTxzCpFZhSTTEH3kZBldKRk=; b=Z79Q682EeRLaKaotDW7LOe8nIuPuOElfUK05OT6dbpQbQCwLBMrRm16IH9TK9Tyc8ozSwf RGqusASIy8DBOMLu0Zg5yW18NZFfPn0SsZkiyScc9DdX5evZF4xDF6uI2wMHyGdt1tNeJj 2xcZ9FYzBy9F+a2Qy8XGZwxYi4tE2co= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HT0Ah9m2; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671252960; a=rsa-sha256; cv=none; b=I3PY6Afz6Rrf/V82FujTpVEdlXSk13zF0N1DvUjAF6eqUkAN9BuT3Mh2kEUhv7Yc11dkRp ilfhkVEe0FTSaAKjnTucOy936vgy7AIx2/ngfffemi8SPoXu13m/MHGxCBQ+VvtE/Aa52r tDnal0z1DvmmLMGxvGjlP7ksJNXGAXs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HNBvGcqXcWq+3AAYbJatmTxzCpFZhSTTEH3kZBldKRk=; b=HT0Ah9m2HWt9/79RcWQoTS44Yh jPIVoCsfrNoXelxm9k2DHCigiLm0vWPQV7Y3I2lio1Q2alC47WCgUhppGnE9zK10zGcfBPj/3O4Km DGm82gmAGv9di/0dQla9ZtJkfIcJ6YJTMuY8SAAZ7UZaoaH9WAISBLi6vWqdF7GedcvAHHlMcA6SC hRx1IB+ONdM7kUUBd6qArE/ao5tjayPnFtaI7Qdi/RI5oSR/imdfmwrsnJVh/lv2donWwB6SkHosZ HqEWwwjJQxWIkKkUwXIyEO+7SeUzPzYN4mBV1sJ/c3TOFZuTs+h4Sut+oRHLHmgnlfgIjy7THE/Ue EeGfuDBg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6PEx-00GFDv-J2; Sat, 17 Dec 2022 04:56:03 +0000 Date: Sat, 17 Dec 2022 04:56:03 +0000 From: Matthew Wilcox To: Lorenzo Stoakes Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() Message-ID: References: <20221217001554.554913-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221217001554.554913-1-lstoakes@gmail.com> X-Rspamd-Queue-Id: 878D940003 X-Stat-Signature: ya6g8gbiikit7reqnnxu4ypin8bf6qkf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671252959-763657 X-HE-Meta: U2FsdGVkX19H867ouLw/cdDpRsMXde4HIJoZGdNcBL58BqHP1C7ge6B4vlC1ILH/bWOvTQfSY5HhIBZsmj3LZj2Mz7FyEmbsUBrOV45doIk1NlHX6eV4y1icrmeotc1nOsUauYNET2jjtxi/uoaqCRdwhS2UNuE3rCCDm33Ees6sz1EUOXuJb2dI4yREX4zFxD5Y4sOd3dOjlRf9tHlUvuAOQpjTeaZT7rqr1pUWZS1WsqsF117R60G60bMjZv2BFUndgvTmxG8zeGKPtl7D//Ki2M4InkPpatUqb2DCVA+AbZYvw7aVGGbRZ3IHEQ6JrqXXI9ehJ/loxsE+AyMPH9cufOSJrKJwmgRvxdfD7rLKWwIWh/9uGO4nQAS7sKVoqeYE9GNHLiYGTp7mC9TjJgvKX7lteY4uSnagMbamMLFZTM4qtRv6IGXK4alLvthwf/JL97cQN+u+oOo2bL6V7OLIbvxzRjMcCmLDXOBOy8ZqFsf0lkp7AGbUxr2iQzVbYbjVnsQMTh3O+TSaSt53rRFFXT1b9uzFFoXcgVlQzuPRcNojqsT8QM/3pLjOT33zmKM7yeTzpwT+xrrOqLERGlrrP26eUlT0OO8sX4O3oKfK0hH03mM9dgg+klg4BFmasm19WGJULqF8l4eEWNGMIRRkhhqSDUbRJs9PESjCjkDKhITpbJ6NC330Tf6i/Sb+h+6Ec0cxeD4GwsNn53xBfS5bRctR9nCuLzas/S8/J2OCXNJIAmnCqSSl8+PAkYpsNHZz/I+HVC1YH1k35U0LCKQOQ7e75KGDhAgGxsCinuUdZ/2G9BoTLFTpdjiuCLWSYTtFIXvwW9/T+JJNNPR8FWlMz3L/BE0El2PvZRhPOVUpUWQ+3juSPKvvZk1ZPF4OUc8OHf7Bx9eU7dcOseKdOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 17, 2022 at 12:15:54AM +0000, Lorenzo Stoakes wrote: > This function is not referenced anywhere else in the kernel, remove it. I think we're waiting to see if any users show up. It's only been 18 months or so, so perhaps wait a little longer? Also, if we do get rid of this, then __alloc_pages_bulk() can lose the "list" argument. > Signed-off-by: Lorenzo Stoakes > --- > include/linux/gfp.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 65a78773dcca..67c5164f4758 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -188,13 +188,6 @@ unsigned long alloc_pages_bulk_array_mempolicy(gfp_t gfp, > unsigned long nr_pages, > struct page **page_array); > > -/* Bulk allocate order-0 pages */ > -static inline unsigned long > -alloc_pages_bulk_list(gfp_t gfp, unsigned long nr_pages, struct list_head *list) > -{ > - return __alloc_pages_bulk(gfp, numa_mem_id(), NULL, nr_pages, list, NULL); > -} > - > static inline unsigned long > alloc_pages_bulk_array(gfp_t gfp, unsigned long nr_pages, struct page **page_array) > { > -- > 2.38.1 >