From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F06C4332F for ; Sun, 4 Dec 2022 12:11:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69B578E0002; Sun, 4 Dec 2022 07:11:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64B2D8E0001; Sun, 4 Dec 2022 07:11:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5141F8E0002; Sun, 4 Dec 2022 07:11:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 432208E0001 for ; Sun, 4 Dec 2022 07:11:35 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1B26F1C5E6C for ; Sun, 4 Dec 2022 12:11:35 +0000 (UTC) X-FDA: 80204509350.26.3B63CED Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 28C0B18000B for ; Sun, 4 Dec 2022 12:11:32 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YsapCOmV; spf=pass (imf06.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670155894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1JxOufhWg2/q5pW/704na++qHz+lwSgqzP8cOwq2c60=; b=IYOIHZgGist5XrCjCdR4fu2kI3cm835sKleaLj2VcotJj4C2nId1aSZ/pa5hOxFrLNJDDi I3cev+BllsYobvmlaebVeeMzZgIIayjnuA8ePe4nbifF3ium3NMFRYvg1qzdUK4+Go9EYl P8cU5DOz1jrCGPz5VXGWwyIg99zySMw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YsapCOmV; spf=pass (imf06.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670155894; a=rsa-sha256; cv=none; b=PJJlQLiihgTZDgrd5xOkY3CIoaYiQ1wZ0Sea4qqbLN4RsfUVBZ0RBi1Cu33CwD1MVskx5Q 2wNRh2+cOQuuGZ8HSkJxExeTSPRyhNykgDn5O7CTs2QusVPTVkDKcUAZXzZ1Sr69gGuE2h jN9Kkz9T9EYpEO2nTJWGgBZXJ1uCNvw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670155892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1JxOufhWg2/q5pW/704na++qHz+lwSgqzP8cOwq2c60=; b=YsapCOmVOM6NdKUc/s9NQqZ+cTlBOmk55rohDYfYRbIkBLmNufp/0dyC/Zyzuc0dusLm+Q RWU5a2b09t2kx+pd/OA0i7Ug7Nx0/OYYHt0JtRlTdedXCJj7P9Z27PCEcGtzNEJsKhPAa2 W0/UH0kX8OeYBZfRUjMUugFKQjHa6Y0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-75-5Kn7jIqNMaOlqQDvhbxhBg-1; Sun, 04 Dec 2022 07:11:29 -0500 X-MC-Unique: 5Kn7jIqNMaOlqQDvhbxhBg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90F9F3C0D181; Sun, 4 Dec 2022 12:11:28 +0000 (UTC) Received: from localhost (ovpn-12-63.pek2.redhat.com [10.72.12.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96A6E2166B29; Sun, 4 Dec 2022 12:11:27 +0000 (UTC) Date: Sun, 4 Dec 2022 20:11:23 +0800 From: Baoquan He To: Wupeng Ma Cc: akpm@linux-foundation.org, tj@kernel.org, dennis@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu_alloc Message-ID: References: <20221204031430.662169-1-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221204031430.662169-1-mawupeng1@huawei.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: 28C0B18000B X-Stat-Signature: nx9j7nrd6b95qkf77ogfrneus97reos9 X-Rspam-User: X-Spamd-Result: default: False [-5.08 / 9.00]; BAYES_HAM(-5.68)[99.31%]; SUBJECT_HAS_UNDERSCORES(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[redhat.com,none]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:170.10.129.0/24]; R_DKIM_ALLOW(-0.20)[redhat.com:s=mimecast20190719]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[redhat.com:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; TC_DOMAIN_MIX_CASE(0.00)[] X-Rspamd-Server: rspam08 X-HE-Tag: 1670155892-702091 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/04/22 at 11:14am, Wupeng Ma wrote: > From: Ma Wupeng > > Assignment to err if is_atomic is true will never be used since warn > message can only be shown if is_atomic is false after label fail. So drop > it. > > Signed-off-by: Ma Wupeng > --- > mm/percpu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index acd78da0493b..df86d79325b2 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -1817,10 +1817,8 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved, > > spin_unlock_irqrestore(&pcpu_lock, flags); > > - if (is_atomic) { > - err = "atomic alloc failed, no space left"; > + if (is_atomic) > goto fail; > - } This is good catch. But I think Dennis may not like this way because he added the message intentionally in commit 11df02bf9bc1 ("percpu: resolve err may not be initialized in pcpu_alloc"). Can we change the conditional checking in fail part as below? diff --git a/mm/percpu.c b/mm/percpu.c index 27697b2429c2..0ac55500fad9 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -1897,7 +1897,7 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved, fail: trace_percpu_alloc_percpu_fail(reserved, is_atomic, size, align); - if (!is_atomic && do_warn && warn_limit) { + if (do_warn && warn_limit) { pr_warn("allocation failed, size=%zu align=%zu atomic=%d, %s\n", size, align, is_atomic, err); dump_stack();