From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BDD0C4332F for ; Fri, 2 Dec 2022 22:21:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 813236B0071; Fri, 2 Dec 2022 17:21:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EA646B0072; Fri, 2 Dec 2022 17:21:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D8E56B0073; Fri, 2 Dec 2022 17:21:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5CDDF6B0071 for ; Fri, 2 Dec 2022 17:21:08 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 310D21A14E6 for ; Fri, 2 Dec 2022 22:21:08 +0000 (UTC) X-FDA: 80198787816.18.8EF59CD Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf21.hostedemail.com (Postfix) with ESMTP id 6D1791C0002 for ; Fri, 2 Dec 2022 22:21:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=UxM8kjrT; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670019666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nb8k+DXeBU/J0+0BiQ1cnwf8hXfYeMnAmujWdPmsnKU=; b=e6fpnYogzAKxKaWrL9+Cayjqn5i/GpcTBl5WdrZcXeVKPx3ClGo9Bf0FAKSoTYZBt3vk7D XE9xlWNZiBiflEVkfL/P3uG/S097mI6G2C4pLbacoFwPFkoeKJLB1O33N5DC5kK65ajGu8 3c0717b1CHAb4GjbUDLiRIqOFOBK2Eg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=UxM8kjrT; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670019666; a=rsa-sha256; cv=none; b=Ri7xWIXy3/fgS2orSVHkg16EafXzrZ1FCet8EK3Np8zYJv1R0SuwZWBlgyJKSo8PRB1D1S D7o6IsnYtZNX/byOHsRkIXhU4hB9Ei6lFOPldFFS+8MW7bxReOfZowLZJifVzpWW5l3uUf e0ZRWoG6JUV55KAUzAohmvvPaSm6qgo= Date: Fri, 2 Dec 2022 14:20:58 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1670019664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nb8k+DXeBU/J0+0BiQ1cnwf8hXfYeMnAmujWdPmsnKU=; b=UxM8kjrT9Ea2zn2bW1xVTLb0ig9zVs+Un8YBzcLzK7pOIf97+C/ov/djzFl3e7QSaXWeda FP0gGaYLRkXM8B1mFBNJc0IsIcbnK3fQgl0fMEbesY65k0hd48x2jgSiiNubIX1gTlc9SL 8p/21LJMfIiYG6LzYyf1NcABb1nKOqw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Yosry Ahmed Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Yu Zhao , Muchun Song , Tejun Heo , "Matthew Wilcox (Oracle)" , Vasily Averin , Vlastimil Babka , Chris Down , David Rientjes , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 2/3] selftests: cgroup: refactor proactive reclaim code to reclaim_until() Message-ID: References: <20221202031512.1365483-1-yosryahmed@google.com> <20221202031512.1365483-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221202031512.1365483-3-yosryahmed@google.com> X-Migadu-Flow: FLOW_OUT X-Spamd-Result: default: False [-0.46 / 9.00]; SUBJECT_HAS_UNDERSCORES(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[linux.dev,none]; BAYES_HAM(-0.46)[72.47%]; R_DKIM_ALLOW(-0.20)[linux.dev:s=key1]; R_SPF_ALLOW(-0.20)[+ip4:188.165.223.204]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; TC_DOMAIN_MIX_CASE_VALID(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[16]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DKIM_TRACE(0.00)[linux.dev:+]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TC_DOMAIN_MIX_CASE(0.00)[] X-Rspamd-Queue-Id: 6D1791C0002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: cw1phshwc7frabhfqfwu135ymxw4e7ro X-HE-Tag: 1670019666-104740 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 03:15:11AM +0000, Yosry Ahmed wrote: > Refactor the code that drives writing to memory.reclaim (retrying, error > handling, etc) from test_memcg_reclaim() to a helper called > reclaim_until(), which proactively reclaims from a memcg until its > usage reaches a certain value. > > While we are at it, refactor and simplify the reclaim loop. > > This will be used in a following patch in another test. > > Signed-off-by: Yosry Ahmed > Suggested-by: Roman Gushchin Reviewed-by: Roman Gushchin Thanks!