From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B44C433FE for ; Wed, 30 Nov 2022 15:53:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC4016B0074; Wed, 30 Nov 2022 10:53:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E4D2D6B0075; Wed, 30 Nov 2022 10:53:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6AE6B0078; Wed, 30 Nov 2022 10:53:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BA3486B0074 for ; Wed, 30 Nov 2022 10:53:15 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8E5B21610FD for ; Wed, 30 Nov 2022 15:53:15 +0000 (UTC) X-FDA: 80190552750.24.ACA3E66 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 30CC140014 for ; Wed, 30 Nov 2022 15:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669823593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CeqSwNjVEno70P0tD7HNeu67BLU3wBvOKBuwAC7eQo8=; b=OW7fqjLb6yldBqZy+aEqF6LD8ioHtLNh8gqhVSS9H1rfm+IS+0AkoO31TPqGDk0e2infTp Ha10H/Ux7p/dxxFttRUtxk1twc+T/dbKf3zkvuwTbdq9W1Aztz7pWC7uZYjVDnUfzw6WW+ kArd6gmNCxnCtYbpKrot3VgdTARMPkQ= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-651-6jA7EG5ROqGqmuEzNUSoww-1; Wed, 30 Nov 2022 10:53:10 -0500 X-MC-Unique: 6jA7EG5ROqGqmuEzNUSoww-1 Received: by mail-qt1-f200.google.com with SMTP id fz10-20020a05622a5a8a00b003a4f466998cso29506794qtb.16 for ; Wed, 30 Nov 2022 07:53:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xRwTsRF/kFVt6li6b4D8+8/D8JRMaZAotCBJm82Pt4o=; b=IGnIfPg7P4z06S+E0kpZmHnuP23lHKPblGOrFnhNYcnkFACH19rKqKXgRp5ceuB/UG 3+RuaNC53FRl5/V4EOb4ksUTsQKYfQBPU/hYPc3f1GptfhTpI3l5xRexDVRK0EJgah6G /HejKsP2byuT0JlyPlrDGWAsybirWKx/pgY44+0Ngc9BSr/u4qH6xRrr4F5vuQXBG76a MUSxJ6s0qupeD0FpgXUYk2ciN+9PIoPwjaL2UtcnSBuu/rS7zMap1av8V7y76s8dbq/u 204Qh3ANqXlM+S9t3z5xwWAkBHPsv/SPgtdMraxAySCk46VPcOHuCYu8mGA98VYu0aEs L65A== X-Gm-Message-State: ANoB5plJYUtGtOm/HpRJTmDSqogocPAbaX6QdXi5Oj22PHEYAKBtSfeF H7PHKIVOgvt887hqB51hwXAJrIkYNjqfj8KcW33iOSIWXTrGslJxBr180Uabc4eXkPEfxo1wXfW QtWg+a+CofZ0= X-Received: by 2002:a05:622a:424f:b0:3a6:6d91:5fb with SMTP id cq15-20020a05622a424f00b003a66d9105fbmr24122883qtb.308.1669823589725; Wed, 30 Nov 2022 07:53:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ZSaU+dqJDqP7grR9JlDuDEx2h1DbFetTYt21IHghT2tVphV5Uzs/xGB+T4aCqvBGmWwqUmw== X-Received: by 2002:a05:622a:424f:b0:3a6:6d91:5fb with SMTP id cq15-20020a05622a424f00b003a66d9105fbmr24122863qtb.308.1669823589430; Wed, 30 Nov 2022 07:53:09 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id r26-20020ac867da000000b003a5689134afsm1034541qtp.36.2022.11.30.07.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 07:53:09 -0800 (PST) Date: Wed, 30 Nov 2022 10:53:08 -0500 From: Peter Xu To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: Re: [linux-next:master 11904/12006] include/linux/hugetlb.h:1240:33: error: 'VM_MAYSHARE' undeclared Message-ID: References: <202211301622.RXGmFGTv-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202211301622.RXGmFGTv-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="0znsW83eknVlmdnn" Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669823594; a=rsa-sha256; cv=none; b=zE27eBIoIKwfMusI3bf4uV+R+BG4FMHrXOVB3UOKnr4hWI7tvFsWDiJJi08dZjacY6VZPK lt+FpdhqOBfIfQYug0Z90n+6/8NLHMCB8BDDpqVgceKP3J1zrfy9A5UA7FS9rPEYqkW5km aSmKRe4T6uj+bJgrVPlLsLtmaTBk5W4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OW7fqjLb; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669823594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CeqSwNjVEno70P0tD7HNeu67BLU3wBvOKBuwAC7eQo8=; b=bn8pF6cTFE1/nbgXF6u2oATIT1s6Qik4VtPykOLfnj8UhB8F9U/vivuyWuK+H+aLYaeUu2 5MOKa5hZ2YwyXnJ2AN7yil/IGVcuqr/peC8aKXgtCH9A7VhBIqy8dYAKHrDX8KGN1M0DIG UYTK8GM27+ydCzsRPywNqRFmfmvsqb4= X-Stat-Signature: xeap9ywinnpndzpjkp67e7ne514nfihq X-Rspamd-Queue-Id: 30CC140014 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OW7fqjLb; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-HE-Tag: 1669823593-331769 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0znsW83eknVlmdnn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Wed, Nov 30, 2022 at 05:01:00PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 700e0cd3a5ce6a2cb90d9a2aab729b52f092a7d6 > commit: 98438ed47d60a6d30d5d2ad9c8786a0b92ca23f2 [11904/12006] mm/hugetlb: introduce hugetlb_walk() > config: s390-randconfig-r031-20221128 > compiler: s390-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=98438ed47d60a6d30d5d2ad9c8786a0b92ca23f2 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 98438ed47d60a6d30d5d2ad9c8786a0b92ca23f2 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/mm/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from arch/s390/mm/pageattr.c:6: > include/linux/hugetlb.h: In function '__vma_shareable_flags_pmd': > >> include/linux/hugetlb.h:1240:33: error: 'VM_MAYSHARE' undeclared (first use in this function) > 1240 | return vma->vm_flags & (VM_MAYSHARE | VM_SHARED) && > | ^~~~~~~~~~~ > include/linux/hugetlb.h:1240:33: note: each undeclared identifier is reported only once for each function it appears in > >> include/linux/hugetlb.h:1240:47: error: 'VM_SHARED' undeclared (first use in this function); did you mean 'MNT_SHARED'? > 1240 | return vma->vm_flags & (VM_MAYSHARE | VM_SHARED) && > | ^~~~~~~~~ > | MNT_SHARED > > > vim +/VM_MAYSHARE +1240 include/linux/hugetlb.h > > 1236 > 1237 static inline bool > 1238 __vma_shareable_flags_pmd(struct vm_area_struct *vma) > 1239 { > > 1240 return vma->vm_flags & (VM_MAYSHARE | VM_SHARED) && > 1241 vma->vm_private_data; > 1242 } > 1243 We can use some ifdef machineries too I think, but not as solid (and clean) as just include mm.h in hugetlb.h.. Fix attached, to be squashed into "mm/hugetlb: Introduce hugetlb_walk()" too (along with the other fixup to the same patch). Thanks, -- Peter Xu --0znsW83eknVlmdnn Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-fixup-mm-hugetlb-Introduce-hugetlb_walk.patch" >From 0064540dd67aea788ec5dac2d87bdb83262b941a Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Wed, 30 Nov 2022 10:45:21 -0500 Subject: [PATCH] fixup! mm/hugetlb: Introduce hugetlb_walk() Content-type: text/plain Signed-off-by: Peter Xu --- include/linux/hugetlb.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index ec2a1f93b12d..1c20cbbf3d22 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -2,6 +2,7 @@ #ifndef _LINUX_HUGETLB_H #define _LINUX_HUGETLB_H +#include #include #include #include -- 2.37.3 --0znsW83eknVlmdnn--