From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF260C4321E for ; Wed, 30 Nov 2022 09:40:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F17226B0072; Wed, 30 Nov 2022 04:40:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC7796B0073; Wed, 30 Nov 2022 04:40:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8FE06B0078; Wed, 30 Nov 2022 04:40:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CA0A36B0072 for ; Wed, 30 Nov 2022 04:40:09 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A0341140114 for ; Wed, 30 Nov 2022 09:40:09 +0000 (UTC) X-FDA: 80189612538.01.FF857C5 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 0F87A1C000B for ; Wed, 30 Nov 2022 09:40:07 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 152C2B81A94; Wed, 30 Nov 2022 09:40:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57F6FC433D6; Wed, 30 Nov 2022 09:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669801204; bh=j4pbxURSkB/qMAGKhX3c71/EfzCnkVfnezE1/DTusgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qWusOV3BBSkYy7rrN42u80HXQwwdVYZOFUGbiEihPaSrqL2ILGP8e1vaCHK2E2lTZ S7WkLtjnjui8RQQW3//nhppG3vhYZOhtZS4ibsuCM68bewY08jB8YrelFxVN46yITz 6vBdiV5AtEMGKWlOCjeKkk2fL4F+1N432YCxdLHjLWEuH/rTiMLDUYma1AAL15yOTh oGi83OUsyDR/N3bh/pm1v8RdKaGX4cLTw0eEfBYq9pG3oMXVUHdCvNSSaxVU35H5HJ 1WjylIAn3qadSUyNbO9ut3S0ZagD+OrfQ4XjAgTkRVil1dYQnhLJ660Nfs1gQ2HmPn Su0xPK1NkLdJA== Date: Wed, 30 Nov 2022 11:39:47 +0200 From: Mike Rapoport To: Song Liu Cc: "Edgecombe, Rick P" , "peterz@infradead.org" , "bpf@vger.kernel.org" , "linux-mm@kvack.org" , "hch@lst.de" , "x86@kernel.org" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "Lu, Aaron" Subject: Re: [PATCH bpf-next v2 0/5] execmem_alloc for BPF programs Message-ID: References: <9e59a4e8b6f071cf380b9843cdf1e9160f798255.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669801208; a=rsa-sha256; cv=none; b=ZTwdI3Q5rpEeODDzVQZBlWp/CaJoL5Yn5iABlmLrSGvL9jdCksZTrEHF6AqMtiJsdY+A4z AnUQfJy5m6y8QCanoxiKwH9jRHTFwP7W1k7JJZ27jvwvTdp1c31KWuKVPKNxDrDcqKB/h2 x164pJX0wb6iVNpBLy16E4zzsglejnc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qWusOV3B; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669801208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yVn1pVW2c2NhlJVLKqVIUim7P5QdLVI5CYQubFmpXBk=; b=T+N+AX1kobh6kvwhcj2LVZO/7/HBTDl7xvXPnWnEzagjBCWSrtvuEY9VNKtlRyYDyy7bP2 +rLN0XREUlzOgkwKwfGChrsJXd5mjGQ3zhO+IoeHvTubrV2/o6NvsoIpMixkKpfvFdGWGh JYfSWgrB1Um8s5y0BuH3RANa/jqLcVw= X-Rspamd-Queue-Id: 0F87A1C000B X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qWusOV3B; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspamd-Server: rspam09 X-Stat-Signature: fr4cninj145x3ju5kxp5f6dq5y63dgeu X-HE-Tag: 1669801207-625685 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 07:52:12AM -0700, Song Liu wrote: > On Sun, Nov 20, 2022 at 3:41 AM Mike Rapoport wrote: > > > > > > > > The most obvious one to implement Peter's suggestion with VM_TOPDOWN_VMAP > > > > so that execmem_alloc() can be actually used by modules. > > > > > > Current implementation is an alternative to VM_TOPDOWN_VMAP. I am > > > very sure it works for modules just like VM_TOPDOWN_VMAP solution. > > > > It might, but it still does not. And until they do I consider these > > patches as an optimization for BFP rather than unification of code > > allocations. > > We haven't got module to use execmem_alloc yet, that's true. But > this has nothing to do with VM_TOPDOWN_VMAP at all. The point is that Peter suggested a way to make module_alloc() use 2M pages, so that all code allocations could benefit from it. Your execmem_alloc() isn't anywhere near this. > Thanks, > Song -- Sincerely yours, Mike.