From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31A6C4321E for ; Wed, 30 Nov 2022 07:46:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D0526B0072; Wed, 30 Nov 2022 02:46:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 481166B0073; Wed, 30 Nov 2022 02:46:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36FEC6B0074; Wed, 30 Nov 2022 02:46:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 270476B0072 for ; Wed, 30 Nov 2022 02:46:08 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E94971A0900 for ; Wed, 30 Nov 2022 07:46:07 +0000 (UTC) X-FDA: 80189325174.27.AA67768 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id 97DC218000D for ; Wed, 30 Nov 2022 07:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/b2I9sGziyoTDblkJQLbT8vhNq6H4Gm3rpxhNbK1VL0=; b=scozBRBWpRmKRUKEktCpdXQ+l/ PvybwKOb3GhgNyTh5Oh8vQpQakY1MnznHSDs4BonCjAEXZNmxEzGdqz9IUkeMVmOya6jY75kJLztx +x6IqWyEH/VGCxaTjmucNpujpONmniG826XNsunahSGVrONyOOb3zoUC9FpsZQ7JpmdhI3AEiI5d2 utf7RHQt7oURqayrusBNEmPkGelX0eNdAXjefTdmgpWrNS1GUwA9ECYVsG8lA1kffOLGPlRnZ1A39 YuhVOOqrP5lw0l86TIeVx5kegWXpVl5+UzW4kHZJGuNM0FicCZNePM06fKq5UQdgq2KqUVB0m0Psw 4yc4R5JQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0HnC-00EF6d-D7; Wed, 30 Nov 2022 07:46:06 +0000 Date: Tue, 29 Nov 2022 23:46:06 -0800 From: Christoph Hellwig To: Brian Foster Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig Subject: Re: [PATCH v2 2/2] mm/fadvise: use LLONG_MAX instead of -1 for eof Message-ID: References: <20221128155632.3950447-1-bfoster@redhat.com> <20221128155632.3950447-3-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221128155632.3950447-3-bfoster@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669794367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/b2I9sGziyoTDblkJQLbT8vhNq6H4Gm3rpxhNbK1VL0=; b=ed6hFCSSQm3OPoppdcYPdr5rH69toFTBzTJQFEC1tEH2wRRVzqIrHsdNc7VFr+1IYcaroJ KN6ZD+ZpRk6qLAHqCH8XD7m7C7cKU5EyVGZMmR6HZesV9AWWlVDV7pMve2QlhPYSskCXNP K9Zw8K+IXMBF4etiArH1Fe7svqDJi58= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=scozBRBW; spf=none (imf24.hostedemail.com: domain of BATV+2c3c6761283ff0291f20+7038+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2c3c6761283ff0291f20+7038+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669794367; a=rsa-sha256; cv=none; b=rGpboGSB08NF3HWCoT7q1oruAYd1CAknL0DL17mXUux35TwixX/F9QuHjCkO8fhEbO8SRb WLI/OOQHhvgjz+oR+kvDtSj/biSv6OqEnSkU1LgChrfEBolXoksDIjidYDeZ4ndGlyewWn WehkcorZLLnru7DkEiB0wDGLzAqh2kU= X-Stat-Signature: ytg37oi1eo84s1yxk8s4n71hmbudu6ho X-Rspamd-Queue-Id: 97DC218000D Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=scozBRBW; spf=none (imf24.hostedemail.com: domain of BATV+2c3c6761283ff0291f20+7038+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2c3c6761283ff0291f20+7038+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1669794367-877462 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 28, 2022 at 10:56:32AM -0500, Brian Foster wrote: > generic_fadvise() sets endbyte = -1 to specify end of file (i.e. if > length == 0 is passed from userspace). Most other callers to > filemap_fdatawrite_range() use LLONG_MAX for this purpose, > particularly if they also call fdatawait_range() (which requires end > >= start). For example, sync_file_range(), vfs_fsync() (where the > range is passed down through per-fs ->fsync() callbacks), > filemap_flush(), etc. generic_fadvise() does not currently wait on > writeback, but fix the call up to be consistent with other callers. Looks good: Reviewed-by: Christoph Hellwig