From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F24C433FE for ; Wed, 30 Nov 2022 05:18:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 836B06B0072; Wed, 30 Nov 2022 00:18:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E6DF6B0073; Wed, 30 Nov 2022 00:18:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AE566B0074; Wed, 30 Nov 2022 00:18:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5947D6B0072 for ; Wed, 30 Nov 2022 00:18:13 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 224C61A0C7D for ; Wed, 30 Nov 2022 05:18:13 +0000 (UTC) X-FDA: 80188952466.03.79E14BF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id BB594180009 for ; Wed, 30 Nov 2022 05:18:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B45FA619B2; Wed, 30 Nov 2022 05:18:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2B40C433D6; Wed, 30 Nov 2022 05:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669785491; bh=LthRoD/zLPG9U+Zco97eCEddMkCmFyhLksJ09r5LxBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qf+88bujVlsGtbJhGEKuyTN8cI+YiRVYOwBRf5XX7L4QvEQfQk5nzyrlNxn93NpaM DMmkNdtS8RU5BeWhKxovjrCPXAO7uUU+RO/1qQwxohR63Bah0gB4RJ9cWIrjwcc+mZ +HCX7PR0eyAeOPE5IbSoGDgoy2rDOWFtoWJ7PePTgJpzGK8tfELHAMKkX1ktQrZr4z zIIF74BGt0CE49UGDWwAEJUXotUuw53TTmuM6nyZxyZuuhkyJBhEQNFHhB3sTeBNKW 1teCDxRTdLRj61Z6GTWKPDSj5C5FeS/K/A71B2Mibc29dCg66RjBN4t23WbbqqvZym 7+27oIX/FjJdg== Date: Tue, 29 Nov 2022 21:18:08 -0800 From: Eric Biggers To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , Jann Horn , Andrew Morton , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz , David Hildenbrand Subject: Re: [PATCH 10/10] mm/hugetlb: Introduce hugetlb_walk() Message-ID: References: <20221129193526.3588187-1-peterx@redhat.com> <20221129193526.3588187-11-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129193526.3588187-11-peterx@redhat.com> ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qf+88buj; spf=pass (imf06.hostedemail.com: domain of ebiggers@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669785492; a=rsa-sha256; cv=none; b=7oxciOUXwN1nKsKcu9aYWLdpRA1O2myWLD+jmPUxp727HpmfUJKpbkUrLtw5yvJz50ge5P Wa24u+SQ+iGxZMiCkbQvR6PqcFCinhB8JzObce7sXuxfvHP6bFkUXfkFdIu5XCHSBjP866 MkezNOZHo+lHBckqcBu3uEJu8Uet4Yk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669785492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8UahAMjd29iHvYXqRSjUosxmwEcfUhHXKNOXp/KbZ5Q=; b=NfgQDQlaXECk77D119aGBdAhVxljpdVkFhNGt6UaCsSE52OJQnOo2z9K6ENY8oBuh0Wm+C hf/kv3NWrVMkTTQTGjZ1GPYCtTh+EQ/2lfkfbtTZAMkvRFrbL49IIpEDMwnqkFHSRchxDa HaPoIPvVyXvVrY41HdAMHa2qTFZW2ec= Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qf+88buj; spf=pass (imf06.hostedemail.com: domain of ebiggers@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BB594180009 X-Stat-Signature: jtt5quk1rg4kwxzfzkupiubimpkpjtwd X-Rspam-User: X-HE-Tag: 1669785492-608626 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 29, 2022 at 02:35:26PM -0500, Peter Xu wrote: > +static inline pte_t * > +hugetlb_walk(struct vm_area_struct *vma, unsigned long addr, unsigned long sz) > +{ > +#if defined(CONFIG_ARCH_WANT_HUGE_PMD_SHARE) && defined(CONFIG_LOCKDEP) > + struct hugetlb_vma_lock *vma_lock = vma->vm_private_data; > + > + /* > + * If pmd sharing possible, locking needed to safely walk the > + * hugetlb pgtables. More information can be found at the comment > + * above huge_pte_offset() in the same file. > + * > + * NOTE: lockdep_is_held() is only defined with CONFIG_LOCKDEP. > + */ > + if (__vma_shareable_flags_pmd(vma)) > + WARN_ON_ONCE(!lockdep_is_held(&vma_lock->rw_sema) && > + !lockdep_is_held( > + &vma->vm_file->f_mapping->i_mmap_rwsem)); > +#endif FYI, in next-20221130 there is a compile error here due to this commit: In file included from security/commoncap.c:19: ./include/linux/hugetlb.h:1262:42: error: incomplete definition of type 'struct hugetlb_vma_lock' WARN_ON_ONCE(!lockdep_is_held(&vma_lock->rw_sema) && ~~~~~~~~^ ./include/linux/lockdep.h:286:47: note: expanded from macro 'lockdep_is_held' #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) ^~~~ - Eric