From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A27C4321E for ; Tue, 29 Nov 2022 21:36:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BE676B0073; Tue, 29 Nov 2022 16:36:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06E576B0074; Tue, 29 Nov 2022 16:36:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E77AD6B0075; Tue, 29 Nov 2022 16:36:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D50EF6B0073 for ; Tue, 29 Nov 2022 16:36:54 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 924D0C01EB for ; Tue, 29 Nov 2022 21:36:54 +0000 (UTC) X-FDA: 80187789948.11.3FD8000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 14903100009 for ; Tue, 29 Nov 2022 21:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669757813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BWaTZSPo+HO/zYxVJ/xWxSiqucUXiQzkU4LC8VS3r40=; b=AhqjkXpWM5wZNluLo3oyVZmcnx5NU6j1o9aMdoKPoDnk3mxvSCeFp4sugQISPyboaa0Sza 0crsh4QVVpVFXU8YVhxlFlpbCybUoDy0PYV/nwlH5oXsKXZkdHWbxkDjEZgIotQSH/Ie8v ospr1uwxecGkhGjhLIwaIZCqWkpoeFU= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-12-7CK2g-6jPfWHHpoXdQcZvg-1; Tue, 29 Nov 2022 16:36:52 -0500 X-MC-Unique: 7CK2g-6jPfWHHpoXdQcZvg-1 Received: by mail-qt1-f197.google.com with SMTP id y8-20020ac87088000000b003a528a5b844so23804462qto.18 for ; Tue, 29 Nov 2022 13:36:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BWaTZSPo+HO/zYxVJ/xWxSiqucUXiQzkU4LC8VS3r40=; b=Zw0QbDsfFGtgz2UJKGh3rEFE1Fm0h1PyGVzbc3RvQ35tjMS4aXNyq1RrDdQsEC1LzR +dKXPUka2WSe9a/QaDhpqgygXCp5G+Bz6sgXNvutySID0h0pHhJcAIHe2gIA6iR+SU1A M7inVT2u0RyuxV3x0C5N0GLmkEHek1tfFX0a/hfogBHyvIgFsivNDaAGQtl0tbsN0XiI gOXtfyODRVdOpbpG8x0hoU4+/p81jBIAw7s9ujDJ7/ceVw80SYqCm1ImGehNXK9gJ1JJ TIkd1md9hX700v67KuvwGBB5wCXZ4QVv3/o46u+FqZbUFcDIvTcDBy5uVQA89cQ2fssK Be2Q== X-Gm-Message-State: ANoB5pkLvhVV9lNysxtTaatl9bgCZzwE5MOQDZK15m1Dp8bjbYasJ0zO RTkAO1CCPA8Gjyo2xAfIGVIKkkz+JWmkfhCB7KDH+LOkds4HXmgMBnRsMVJITMusLVv+RiTkI1C t0gAY+w129QU= X-Received: by 2002:a05:622a:6022:b0:398:5f25:649 with SMTP id he34-20020a05622a602200b003985f250649mr55357230qtb.673.1669757811539; Tue, 29 Nov 2022 13:36:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf4O3P88Az221sAQckplDC94c73NQebw1mJ1mivlR3sPQM+UXsSc1nokCTAlyNeJ14Caezk6DA== X-Received: by 2002:a05:622a:6022:b0:398:5f25:649 with SMTP id he34-20020a05622a602200b003985f250649mr55357219qtb.673.1669757811297; Tue, 29 Nov 2022 13:36:51 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id dt31-20020a05620a479f00b006fbf88667bcsm11300718qkb.77.2022.11.29.13.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 13:36:50 -0800 (PST) Date: Tue, 29 Nov 2022 16:36:49 -0500 From: Peter Xu To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , Jann Horn , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz , David Hildenbrand Subject: Re: [PATCH 00/10] mm/hugetlb: Make huge_pte_offset() thread-safe for pmd unshare Message-ID: References: <20221129193526.3588187-1-peterx@redhat.com> <20221129125117.6d31c7cf4c83510be0c8cf10@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20221129125117.6d31c7cf4c83510be0c8cf10@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AhqjkXpW; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669757814; a=rsa-sha256; cv=none; b=TOCPTKd3YUSAiH6phlsUls53iUH8PlAJWcsL3NOUcvgQTw+uAUDqhmRoB9SNQPvbJXCrr+ IaOU+YJ/tJOvRnZOKuWRboYxrGFiqlKwHEhDRPRH0a/OVG30/XojNenZ7HWKt8jMwpEKKj 6473TOf+RBLp99gB1HbCr9xxoXIkVvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669757814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BWaTZSPo+HO/zYxVJ/xWxSiqucUXiQzkU4LC8VS3r40=; b=tKgkDDMB+xaGSR7JpcO+9fu6rBOUoG5cnT3wApSitUcVmp/L4fG50k7zyd3Z3o2kAjG8tR rbYo5jk/r6hyW3AxlyqO+/XNiuah8NUaesG/cWi6rAA7haGhB63Dpdntv+RrfePWgix5R7 UkRd5bnwxDoIvvszEQm6t/L+hp0TiiE= X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 14903100009 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AhqjkXpW; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: fro19u3c91xt54te3ajken4s1q4z4fo5 X-HE-Tag: 1669757813-261536 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 29, 2022 at 12:51:17PM -0800, Andrew Morton wrote: > On Tue, 29 Nov 2022 14:35:16 -0500 Peter Xu wrote: > > > [ 17.975943] Oops: 0000 [#1] PREEMPT SMP NOPTI > > Do we know which kernel versions are affected here? Since lockless walk of huge_pte_offset() existed since the initial git commit, it should be the time when we introduced pmd sharing for hugetlb, which means any kernel after commit 39dde65c9940 ("[PATCH] shared page table for hugetlb page", 2006-12-07) should be prone to the issue at least for x86 (as pmd sharing was proposed initially only for x86). -- Peter Xu