From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A44C4321E for ; Tue, 29 Nov 2022 14:04:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CD5C6B0074; Tue, 29 Nov 2022 09:04:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 07D8E6B0075; Tue, 29 Nov 2022 09:04:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAEF76B0078; Tue, 29 Nov 2022 09:04:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DBBC76B0074 for ; Tue, 29 Nov 2022 09:04:22 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A3B5BAB676 for ; Tue, 29 Nov 2022 14:04:22 +0000 (UTC) X-FDA: 80186649564.10.4C1F84F Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf23.hostedemail.com (Postfix) with ESMTP id 74EDD1400D7 for ; Tue, 29 Nov 2022 14:03:52 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id t17so12749458pjo.3 for ; Tue, 29 Nov 2022 06:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7Z+IcAbiLKvMQ/ifv4+wjr02j49KjulQRaKardeM4iU=; b=X1JUWSnB7jN8UPlhMUWuSe9NpQEFdBjqsTqKXathiY/4oPl8zKvNucEHGkEgR9ZFXa tMiTC/FsrpGedTA+VoPnC4VAKpHEUtRp+pUf6M97UNTDiMIM/aewUVPewHH1Qz7Zqtuw A/6d+S/wQYqFih/kPWM/X7NOPhGr5G5OvIUnY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Z+IcAbiLKvMQ/ifv4+wjr02j49KjulQRaKardeM4iU=; b=AG3G4WpWyEZ1IcBw4ZfThxHg02/6962Nl4rVkcTod9O2xrrRrZUBZD/yV2+2Jgrg2k HD8QD1O9JT3SXndZ6CD5ugUutuaJWgdf1ehsL7d3unSD6pzLc6eQmh2RsFv00WJ3+V+W odn1NWVbySfYSuZEb7dLInGngkZv3VHuoZ65jruFfeofH6+wca4Q7T/e+/MCLUSMqily Is+EHwL3Gu7ECu2PyxDlLoT46lCurytg6LBHnDWGHpC6v+alGSo+xwGRtPiz0mDs3tkJ a5htKP5lUTB2uZfeL7mACnBk/wj3Jl9USgmpXfMXRizKCM9qKAE+1TkOHDIhUCeBKYn2 giWw== X-Gm-Message-State: ANoB5pnOMeY6xpUfPdr9YFdbaqrM3zZXS9pJgWn18yu5tyu+H5VCnvO1 wl7LNR2A/BZR3miWCrvHR8c8mg== X-Google-Smtp-Source: AA0mqf5G8dhoxdxdsNqbby49Z8R+DLxiw0BqTOB6vLWUPI74ZphiFYIDUsml1Fzl8YwZUOYfcWenCg== X-Received: by 2002:a17:90a:990d:b0:212:d909:a41e with SMTP id b13-20020a17090a990d00b00212d909a41emr18042535pjp.48.1669730631347; Tue, 29 Nov 2022 06:03:51 -0800 (PST) Received: from google.com ([240f:75:7537:3187:9a17:1728:aa10:47a1]) by smtp.gmail.com with ESMTPSA id k2-20020a170902d58200b00179e1f08634sm10864906plh.222.2022.11.29.06.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 06:03:50 -0800 (PST) Date: Tue, 29 Nov 2022 23:03:45 +0900 From: Sergey Senozhatsky To: Vitaly Wool Cc: Nhat Pham , akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org Subject: Re: [PATCH v7 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Message-ID: References: <20221128191616.1261026-1-nphamcs@gmail.com> <20221128191616.1261026-5-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669730632; a=rsa-sha256; cv=none; b=JBKuN9tuUXqqvaW8zbeFdaVIRGaLtxoT8bVblTgURQjP8w9GsoAvzlNqwKfiQwSjT3Qwq3 +qwJenMqvqtjyinyPI5/mmYyejC1WN8wly0ivWg0UFGcI5c3QWXEFG5F6r9CVRSrHzhcTc 4LB0zs6Hr7LBIMqB2wnsczCqHVt90J8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=X1JUWSnB; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669730632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7Z+IcAbiLKvMQ/ifv4+wjr02j49KjulQRaKardeM4iU=; b=IUadUfdNb+HFj2Jx6d5ZgE/Po0PrpVsvhF0ohE+Hd/qk/EGemaM0C+ysGapZsR9lM25EIH Mcya5tNb2a9sPNMDOOwPw5HAdIoqul0CHpahQxpWuSVbdF7kpiN9ZhntKRpaetf6eMymsR 6duFVUN2Qbn/EA4SklPJHUvfAsajc6g= X-Stat-Signature: pnerp9u6ya9adwm5rasoc38rcdc3te7e X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 74EDD1400D7 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=X1JUWSnB; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspam-User: X-HE-Tag: 1669730632-979130 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/29 12:53), Vitaly Wool wrote: > I think the amount of #ifdefs here becomes absolutely overwhelming. > Not that zsmalloc code was very readable before, but now it is > starting to look like a plain disaster. Presumably most of them will go away once LRU moved from allocator to upper level.