From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F15E1C433FE for ; Mon, 28 Nov 2022 19:28:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9221A6B0071; Mon, 28 Nov 2022 14:28:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D2236B0075; Mon, 28 Nov 2022 14:28:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 799D26B0078; Mon, 28 Nov 2022 14:28:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 688366B0071 for ; Mon, 28 Nov 2022 14:28:33 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3F84540775 for ; Mon, 28 Nov 2022 19:28:33 +0000 (UTC) X-FDA: 80183837706.24.F6EFD72 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf19.hostedemail.com (Postfix) with ESMTP id D4A0C1A000D for ; Mon, 28 Nov 2022 19:28:32 +0000 (UTC) Received: by mail-qt1-f172.google.com with SMTP id s4so7435274qtx.6 for ; Mon, 28 Nov 2022 11:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E4K7CdrO1bVG1lma0UHiRT4m0Q8nKmohqqgtpJrE588=; b=j4I86y6wdhKn8Hv3cB1Ggw3Y3oZkLus35E2C4t/nVedgQZYs6BmhQQjn5ZvqNwDkR4 DhN0G81WwvwckgmQ3WuYV88zFUTjiqMfRcvdytnxZ5SIzQqYSxhRRVnhi4yq+ovF2n9O knl1EFAaO34BZsV7+cclB5D61z2P7xJ/BQBAVpy8d3NusKOmXtgzLVZIOt1/Hlbiygm9 IgVuVmTZMCkCi5nyG0vW5l38IUObFiWMsTGER4xwi04jJTi6v9UsFYgc5JgQQAzaEQ5J xaG4uM+JKZthiyA/OAxJbv1Z0qAQiC7/vc542rVWOjn3zoKQWCgjVFLfeCbXvUHT09nQ UEUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E4K7CdrO1bVG1lma0UHiRT4m0Q8nKmohqqgtpJrE588=; b=4xH3MO9IPi2EMRhcxWE6S29o6RBKMQx/h7hCd3IQ7uj6ta6yy/QbzETb8dR5i1A2TI LdQh+rEWSZvGu9ZbKtaBg/dZ3R/R3cmrztQ2Ue//+Vt9+eV9t0kJBli3659sqgFaF/YY E3YU0a7rkNxQzE+aFT4XRBLoKv8sMhscOyIxxkeh7M46VYbP3qIU3pF/5n4mR6eTCYa+ Bt2uzwsIL9PT2GSmeZCFlHWg3i9wGbTd0F8/PKYvRouS3iyV5dV1MXMpH2hu8xV7Lyt1 WobOtUzf0UpYSXjJmOHGRCKp/xD9VN8ewJqe9NqwClBbcqSSWXqMSX3us6q6JbA9Ce4u +0KQ== X-Gm-Message-State: ANoB5plJz3NsEcKrUww1pkwhGPRvJt6Lo2kRlYBDHJU5Gkn7AVqqzp7D sOpOJc5fuNx4zhy91a3sA9gfuA== X-Google-Smtp-Source: AA0mqf4Jlo9bPOKU+NFC/VMZWSkEpQ/6kmrsGl9mG2CaDd2xNKrIysNaLrErxchfEsx9azuFvOOaDQ== X-Received: by 2002:a05:622a:480e:b0:39c:e18e:758f with SMTP id fb14-20020a05622a480e00b0039ce18e758fmr31278458qtb.187.1669663712166; Mon, 28 Nov 2022 11:28:32 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-9175-2920-760a-79fa.res6.spectrum.com. [2603:7000:c01:2716:9175:2920:760a:79fa]) by smtp.gmail.com with ESMTPSA id w18-20020a05620a445200b006fafc111b12sm9166183qkp.83.2022.11.28.11.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 11:28:31 -0800 (PST) Date: Mon, 28 Nov 2022 14:28:31 -0500 From: Johannes Weiner To: Nhat Pham Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v7 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221128191616.1261026-1-nphamcs@gmail.com> <20221128191616.1261026-7-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221128191616.1261026-7-nphamcs@gmail.com> ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=j4I86y6w; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669663712; a=rsa-sha256; cv=none; b=m71a1U4SEAAkQts2zG9237acLziwvC5P/n9NGj5TIOhQEuMgSvi0VG4hzTGFJACJxM+TOC AfB4FifuoNCZjo6BWFyXqOjUxRJ9gzznQxTeNH1E/xc4CljWTaXa9ZJ0/gYU2G/5TdNJxv 0YcqOgzYKK/O2xLyMsh1KDtqZc43y0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669663712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E4K7CdrO1bVG1lma0UHiRT4m0Q8nKmohqqgtpJrE588=; b=yub+wg7c4V15o0y7uDMNk6GcWUXJEWomdEdq/OnKbO6uL+lH1+A86BGt1aJpL2TDGXAhZ/ M59ExoWMQhyUtdSjnS34rkuf9NT/o6ezCjmaCTDT1bZoDYX0dtYVRvG5ehG8JNIuZDv5FJ 7O2FUlQRviBytxZRmaMuAjemzzfIyOM= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=j4I86y6w; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam01 X-Stat-Signature: p3e8nja558c3tcgrrydpyphy17ifqypm X-Rspamd-Queue-Id: D4A0C1A000D X-Rspam-User: X-HE-Tag: 1669663712-99382 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 28, 2022 at 11:16:15AM -0800, Nhat Pham wrote: > This commit adds the writeback mechanism for zsmalloc, analogous to the > zbud allocator. Zsmalloc will attempt to determine the coldest zspage > (i.e least recently used) in the pool, and attempt to write back all the > stored compressed objects via the pool's evict handler. > > Signed-off-by: Nhat Pham Ok, this now also has the get_first_page() and the cond_resched() that Sergey had asked for. Looks good to me. Acked-by: Johannes Weiner