From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE00C433FE for ; Mon, 28 Nov 2022 07:13:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A35856B0072; Mon, 28 Nov 2022 02:13:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E5256B0073; Mon, 28 Nov 2022 02:13:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AD916B0074; Mon, 28 Nov 2022 02:13:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7B9AE6B0072 for ; Mon, 28 Nov 2022 02:13:39 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3F3311A0377 for ; Mon, 28 Nov 2022 07:13:39 +0000 (UTC) X-FDA: 80181985758.25.3F5998B Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf21.hostedemail.com (Postfix) with ESMTP id 712D51C0002 for ; Mon, 28 Nov 2022 07:13:38 +0000 (UTC) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AS4uwAF025118; Mon, 28 Nov 2022 07:13:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pp1; bh=e+ETaPQfpW5mJTFEGN6GIsdERaL2Gm2kkcs5aOlFvWE=; b=gbTuzT5OzVSnzDerOaIMYIhivAbf624SjA9XVTGdHMvIyduqoixVoPEd+/Wj8bRYJczP nhtJUMtIp1HwqeQOb0U1tvbcAzVkUx759JrTOCw3aWmeb921fzddmfAq5tkvOnb0KlpX ozAnj/a6K25N1RgWJKmxP0TSmmPhA9svhrGiUU13SNwBayLK2/kR62M2tmZb188RQKVH i+Ctugh25iOeA/qrFrD/gyVLdXThyqI9W4pbrT0nr4ElYuIP6F4zLOndOtre11ffurJb Vz9TwGM84hvFUhcoqitQXlwmSraz2yw0qPF2qHEzrJRrMFjKG5bUwNOposuoTLtHm+rv dQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m3vjd0m49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 07:13:34 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2AS70Aks027736; Mon, 28 Nov 2022 07:13:34 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m3vjd0m3k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 07:13:33 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2AS763Bm013358; Mon, 28 Nov 2022 07:13:31 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma06ams.nl.ibm.com with ESMTP id 3m3a2ht3fu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 07:13:31 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2AS773hW39518542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Nov 2022 07:07:03 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D0E24C044; Mon, 28 Nov 2022 07:13:28 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B38D4C040; Mon, 28 Nov 2022 07:13:28 +0000 (GMT) Received: from li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com (unknown [9.145.84.206]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 28 Nov 2022 07:13:28 +0000 (GMT) Date: Mon, 28 Nov 2022 08:13:26 +0100 From: Alexander Gordeev To: Anshuman Khandual Cc: linux-mm@kvack.org, Christian Borntraeger , David Hildenbrand , Heiko Carstens , Andrew Morton , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390/mm: Use pmd_pgtable_page() helper in __gmap_segment_gaddr() Message-ID: References: <20221125034502.1559986-1-anshuman.khandual@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: FWR_xoUXUUyH8vi0vfqVIEiwBoAhZC03 X-Proofpoint-ORIG-GUID: elk5BfkrpiYR_B8lMP2RePnJVG5SK_Yv X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-28_05,2022-11-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 mlxlogscore=469 bulkscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211280055 ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=gbTuzT5O; spf=pass (imf21.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669619618; a=rsa-sha256; cv=none; b=4EaGLGmG5rbPt4Nl4bxKdyengCam+LW3ZG8cYZwju1hzNdMuOsY5PFKGIlVFn90lw6CNVV iYuH2KFmQyI3/PEYIRFCheNrNsEDT0NS1gquBZmkcxIu44lLDlC3YhtaphlBk6gUd09Db9 h5aVH9NlPZuT8MvsdDEDLXSi9Om6eMQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669619618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e+ETaPQfpW5mJTFEGN6GIsdERaL2Gm2kkcs5aOlFvWE=; b=TvUtLCIbNIJ1cneKJG8nudf6JbPGdQphgVilRGKDX0PpRsRUUlCUudv2S17hS/dZrNNKm8 qrtWVuTSq3rcOhaE8EWbLb3TlqODQ0STxIeOKV9yHk4ruYDBEGfq123bFB3Y/umPvJxuTl pFBAZuei2PQ7yO9Zz1V0xNEBW2Kv4nw= Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=gbTuzT5O; spf=pass (imf21.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspam-User: X-Rspamd-Queue-Id: 712D51C0002 X-Rspamd-Server: rspam01 X-Stat-Signature: 9mk1c6p9o47cdftiap6n5jxb9nh8t151 X-HE-Tag: 1669619618-434555 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 28, 2022 at 12:01:06PM +0530, Anshuman Khandual wrote: > >> diff --git a/include/linux/mm.h b/include/linux/mm.h > >> index e9e387caffac..5ead9e997510 100644 > >> --- a/include/linux/mm.h > >> +++ b/include/linux/mm.h > >> @@ -2403,7 +2403,7 @@ static inline void pgtable_pte_page_dtor(struct page *page) > >> > >> #if USE_SPLIT_PMD_PTLOCKS > >> > >> -static struct page *pmd_pgtable_page(pmd_t *pmd) > >> +static inline struct page *pmd_pgtable_page(pmd_t *pmd) > >> { > >> unsigned long mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); > >> return virt_to_page((void *)((unsigned long) pmd & mask)); > > > > This chunk does not appear to belong to this patch. > > Should not this helper be made a 'static inline' before using it else where ? Probably yes, but it is not kvm s390-specific change. I guess, you wanted to make it together or as a follow-up to this one? https://lore.kernel.org/all/20221124131641.1523772-1-anshuman.khandual@arm.com/